Re: [FFmpeg-devel] [PATCH 1/2] avformat/file: Constify android content protocol

From: Matthieu Bouron <matthieu.bouron@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/file: Constify android content protocol
Date: Mon, 25 Mar 2024 09:06:26 +0100
Message-ID: <ZgEwgs3XkY4HvLk9@kusa> (raw)
In-Reply-To: <GV1P250MB0737400E7159F0496201224F8F362@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

On Mon, Mar 25, 2024 at 02:55:32AM +0100, Andreas Rheinhardt wrote:
> Andreas Rheinhardt:
> > (The discrepancy between the definition and the declaration
> > in protocols.c is actually UB.)
> > 
> > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> > ---
> > This and the next patch have not been tested (apart from "it compiles
> > when the android content protocol is disabled").
> > 
> >  libavformat/file.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/file.c b/libavformat/file.c
> > index dd5819c06f..8f3b35c795 100644
> > --- a/libavformat/file.c
> > +++ b/libavformat/file.c
> > @@ -670,7 +670,7 @@ done:
> >      return ret;
> >  }
> >  
> > -URLProtocol ff_android_content_protocol = {
> > +const URLProtocol ff_android_content_protocol = {
> >      .name                = "content",
> >      .url_open            = android_content_open,
> >      .url_read            = file_read,
> 
> Will apply this patchset tomorrow unless there are objections.

Patchset tested locally and working as intended. LGTM.
Thanks.

-- 
Matthieu B.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".