From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 331114945A for ; Tue, 12 Mar 2024 13:50:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C5F1768D030; Tue, 12 Mar 2024 15:50:38 +0200 (EET) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5683A68C82F for ; Tue, 12 Mar 2024 15:50:33 +0200 (EET) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5682360e095so6771132a12.1 for ; Tue, 12 Mar 2024 06:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710251432; x=1710856232; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=UYlho6BriGDKI4IG5eF0AH7Wi2QDWJO/u8KtXqU61hs=; b=cYcLo6XbGZTlWQXJwVAq0a+aP6wbhc8vCtmakACRsVYOGtxumd9pr2Ku41g1h9W5E1 8SZIwlgsfCFd5hbQJo4x0nEQnLwDQU4qIkJhtTLT1xgYa7VhRv0ijgM6SXx+nMzUR6gi EWTGMeeqGlZrCvPW6LoeyqapF8QXL7RXtQkz8I8vJWhg0qkj+cYuoXd3LtpinFfZX1BR 2bBhN7rdjBICMmi5s6hUD6eOrk1mGkjeY9T3g5KacZ6R49IVA3yzX/G384rlnL+bs9gX ynnxgM3Sa0ppHY6ERE1Cxr5A5FnlBrhNVdWOZXSCm17y6QWE1tcqzYzDswN4J/hZCSHy /CMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710251432; x=1710856232; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UYlho6BriGDKI4IG5eF0AH7Wi2QDWJO/u8KtXqU61hs=; b=q72ML6IQzCY4RacPdB55g1+p7P7JT0FoJ+9Zvi8k6/olOBD7uFOnP2vkyruQqnTi4g A7V7ovlQeknEuL10oTsT48UbJBCoV3aCA/xZmw+rDPyaw5W/NHXARIGv3ZB0+2RE3RwY VZCXVaxGSTzBzM7KUJJoKQr4a43b/w4brG+h4sxqFTFLUI5Y6nWwHR+Re82NWOLq26Kt feh3pKuqgP4Lb0qI2lmik2xrOEmug+W5mR6sHkHxHEvnqXGGUy2Zr05j1lPBZgNtgbmN CqRYSo2WXRdb3CyyytrqNQZGTeuTiCoG966UplwneUl9iANMz4mPQvibb+ccn/Jn+3dD Bi7Q== X-Gm-Message-State: AOJu0Yx4bH5UQdWdS/EwltEDpUzQisE/XOIjT3UbUBuumhvhI3f7Cjeg HatnhRapvdp9ZgNdvI82+Ow6m3knmzwFfgIihiKRxaI+53TGFxG5opCgTQ5a X-Google-Smtp-Source: AGHT+IEqXbx7luX0rAdyY1c+KYb0ggob6TddAIiIxBBMtXN7cx45KHlT4B9pYTGW2rqp/YIf/SrHIQ== X-Received: by 2002:a17:907:160a:b0:a40:2c33:1f42 with SMTP id cw10-20020a170907160a00b00a402c331f42mr7103773ejd.15.1710251431649; Tue, 12 Mar 2024 06:50:31 -0700 (PDT) Received: from mariano ([188.210.239.79]) by smtp.gmail.com with ESMTPSA id a10-20020a17090640ca00b00a4550e8ae70sm3896184ejk.63.2024.03.12.06.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 06:50:31 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 2B985BFCDC; Tue, 12 Mar 2024 14:50:30 +0100 (CET) Date: Tue, 12 Mar 2024 14:50:30 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Marth64 References: <20240312060005.2111135-1-marth64@proxyid.net> <20240312060005.2111135-4-marth64@proxyid.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240312060005.2111135-4-marth64@proxyid.net> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v3 3/6] avcodec/ccaption_dec: ignore leading non-breaking spaces X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marth64 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2024-03-12 01:00:02 -0500, Marth64 wrote: > In Closed Captions (US), the non-breaking space (0xA0) can be used to > align text horizontally from the left when used as a leading character. > However, CC decoder does not ignore it as a leading character > like it does an ordinary space, so a blank padding is rendered > on the black CC box. This is not the intended viewing experience. > > Ignore the leading non-breaking spaces, thus creating the intended > transparency which aligns the text. Since all characters are > fixed-width in CC, it can be handled the same way as we currently > treat leading ordinary spaces. > > Also, as a nit, lowercase the NBSP's hex code in the entry table to match > casing of the other hex codes. > > Signed-off-by: Marth64 > --- > libavcodec/ccaption_dec.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Still LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".