From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C59D648BD7 for ; Sat, 9 Mar 2024 10:58:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3969268CD43; Sat, 9 Mar 2024 12:58:16 +0200 (EET) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E4EE68C1AA for ; Sat, 9 Mar 2024 12:58:10 +0200 (EET) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-512e4f4e463so4122074e87.1 for ; Sat, 09 Mar 2024 02:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709981889; x=1710586689; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=6ug1wpbUQHBd89hB3PRbRjppZmPiiNVk1ZeJD0xdZUo=; b=cKvmuGO0daryGiRmZcUQ7joSdOegp9EkyV/YZ9PorGNf0bLWP+pSp1h4clH6EQKFGE iVy+6hf1aFATkqGffDsyO0VrlbSJPZYBjPx4EwVH4ACwKGI2iItdRpeOHEmdspkeeA7p mHyNggsEIVT76SWKtgvpywchZCxGLacr2SpkmsJ88xoas2MhTbvjgkqcbkteJWOo6/rX ml3gwOzdjOLvYOqYZdCQPHafhsfaTt3Ay4XhcmvHfsNKm0nuXP/JJpVLSTLgchZI0MvY Dlt4le7eT7gRRDo3YLk2K6a6OXclC96F0tIpntqwXSmtbmHZuSvGqQJ9W3QcrLRwmA1T U+9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709981889; x=1710586689; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6ug1wpbUQHBd89hB3PRbRjppZmPiiNVk1ZeJD0xdZUo=; b=GuSaKkah8Kg7pebI50wJGtZvJNToZVedWbVLDtakt5L2YmwRwAVrFlLg+JNYgfz2hi HkEvsr/IHqkP5nhhlpp9kmwbUYKF+WcfxJRRz9pT8+rCQ3plDi2QYTbu+0ZoTZBGB+tS 7uosjhoyRDsMzBRx88mPOITuWf98xXnpXmLWEtUjJAH09cOZdObtru0iBOiuYujkeL3F CQeE3FxKT0zQ2LWGh/FIpWjqqtpgXW+y0sMPe04a0LhOMMSYrhhRzriVmHqZ+eloafvP rdXNLXuegLfB6SPJc9l9TClZ7VMYpa4lyG/3Qa9jg7/HTY3GvG0h+qcGVUJbn256kC4/ Jl3Q== X-Gm-Message-State: AOJu0YxAKiRtu5Ytc1OqGr6E9oUB9fC+A0gzTxoopDLVfxdArFRbuAz/ 0SOCYm5JWHARERUjHDpaqBASzVoJHg10e8whkLi1rcLbkqUfr0TRhZvsb74e X-Google-Smtp-Source: AGHT+IGRnGHsVk5bYBsB260QdcENk4xAaDUXgRqeMCYmqDJER4vF5R8gG48rzKd+DfpbMuteX+adMA== X-Received: by 2002:ac2:5151:0:b0:513:64c5:105b with SMTP id q17-20020ac25151000000b0051364c5105bmr942675lfd.27.1709981888763; Sat, 09 Mar 2024 02:58:08 -0800 (PST) Received: from mariano ([188.210.239.79]) by smtp.gmail.com with ESMTPSA id iv6-20020a05600c548600b0041294d015fbsm2186559wmb.40.2024.03.09.02.58.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 02:58:08 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id B3ACFBFCDC; Sat, 9 Mar 2024 11:58:06 +0100 (CET) Date: Sat, 9 Mar 2024 11:58:06 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240308202448.62576-1-jamrial@gmail.com> <20240308202448.62576-2-jamrial@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240308202448.62576-2-jamrial@gmail.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 2/2 v2] fftools/ffprobe: export IAMF Stream Group parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2024-03-08 17:24:48 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > doc/ffprobe.xsd | 39 ++++++ > fftools/ffprobe.c | 160 +++++++++++++++++++++++- > tests/fate/iamf.mak | 12 +- > tests/fate/mov.mak | 8 +- > tests/ref/fate/iamf-5_1_4 | 92 ++++++++++++++ > tests/ref/fate/iamf-7_1_4 | 92 ++++++++++++++ > tests/ref/fate/iamf-ambisonic_1 | 39 ++++++ > tests/ref/fate/iamf-stereo | 67 ++++++++++ > tests/ref/fate/mov-mp4-iamf-5_1_4 | 92 ++++++++++++++ > tests/ref/fate/mov-mp4-iamf-7_1_4 | 92 ++++++++++++++ > tests/ref/fate/mov-mp4-iamf-ambisonic_1 | 39 ++++++ > tests/ref/fate/mov-mp4-iamf-stereo | 67 ++++++++++ > 12 files changed, 787 insertions(+), 12 deletions(-) You might also want to add a changelog entry. > > diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd > index bd52000725..6d5d094d97 100644 > --- a/doc/ffprobe.xsd > +++ b/doc/ffprobe.xsd > @@ -366,10 +366,49 @@ > > > > + > > > > > + > + > + > + > + > + > + > + > + > + > + > + > + > + nit: I'd use Subpiece since it's considered as a single word > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > > > [...] No more comments from me, looks nice otherwise, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".