From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2 v2] fftools/ffprobe: export IAMF Stream Group parameters
Date: Sat, 9 Mar 2024 11:58:06 +0100
Message-ID: <ZexAvog7Af1aO4lP@mariano> (raw)
In-Reply-To: <20240308202448.62576-2-jamrial@gmail.com>
On date Friday 2024-03-08 17:24:48 -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> doc/ffprobe.xsd | 39 ++++++
> fftools/ffprobe.c | 160 +++++++++++++++++++++++-
> tests/fate/iamf.mak | 12 +-
> tests/fate/mov.mak | 8 +-
> tests/ref/fate/iamf-5_1_4 | 92 ++++++++++++++
> tests/ref/fate/iamf-7_1_4 | 92 ++++++++++++++
> tests/ref/fate/iamf-ambisonic_1 | 39 ++++++
> tests/ref/fate/iamf-stereo | 67 ++++++++++
> tests/ref/fate/mov-mp4-iamf-5_1_4 | 92 ++++++++++++++
> tests/ref/fate/mov-mp4-iamf-7_1_4 | 92 ++++++++++++++
> tests/ref/fate/mov-mp4-iamf-ambisonic_1 | 39 ++++++
> tests/ref/fate/mov-mp4-iamf-stereo | 67 ++++++++++
> 12 files changed, 787 insertions(+), 12 deletions(-)
You might also want to add a changelog entry.
>
> diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
> index bd52000725..6d5d094d97 100644
> --- a/doc/ffprobe.xsd
> +++ b/doc/ffprobe.xsd
> @@ -366,10 +366,49 @@
>
> <xsd:complexType name="streamGroupSubComponentType">
> <xsd:sequence>
> + <xsd:element name="pieces" type="ffprobe:streamGroupPieceList" minOccurs="0" maxOccurs="1"/>
> <xsd:element name="subcomponent_entry" type="ffprobe:streamGroupEntryType" minOccurs="0" maxOccurs="unbounded"/>
> </xsd:sequence>
> </xsd:complexType>
>
> + <xsd:complexType name="streamGroupPieceList">
> + <xsd:sequence>
> + <xsd:element name="piece" type="ffprobe:streamGroupPieceType" minOccurs="0" maxOccurs="unbounded"/>
> + </xsd:sequence>
> + </xsd:complexType>
> +
> + <xsd:complexType name="streamGroupPieceType">
> + <xsd:sequence>
> + <xsd:element name="subpieces" type="ffprobe:streamGroupSubPieceList" minOccurs="0" maxOccurs="1"/>
> + <xsd:element name="piece_entry" type="ffprobe:streamGroupEntryType" minOccurs="0" maxOccurs="unbounded"/>
> + </xsd:sequence>
> + </xsd:complexType>
> +
> + <xsd:complexType name="streamGroupSubPieceList">
nit: I'd use Subpiece since it's considered as a single word
> + <xsd:sequence>
> + <xsd:element name="subpiece" type="ffprobe:streamGroupSubPieceType" minOccurs="0" maxOccurs="unbounded"/>
> + </xsd:sequence>
> + </xsd:complexType>
> +
> + <xsd:complexType name="streamGroupSubPieceType">
> + <xsd:sequence>
> + <xsd:element name="blocks" type="ffprobe:streamGroupBlockList" minOccurs="0" maxOccurs="1"/>
> + <xsd:element name="subpiece_entry" type="ffprobe:streamGroupEntryType" minOccurs="0" maxOccurs="unbounded"/>
> + </xsd:sequence>
> + </xsd:complexType>
> +
> + <xsd:complexType name="streamGroupBlockList">
> + <xsd:sequence>
> + <xsd:element name="block" type="ffprobe:streamGroupBlockType" minOccurs="0" maxOccurs="unbounded"/>
> + </xsd:sequence>
> + </xsd:complexType>
> +
> + <xsd:complexType name="streamGroupBlockType">
> + <xsd:sequence>
> + <xsd:element name="block_entry" type="ffprobe:streamGroupEntryType" minOccurs="0" maxOccurs="unbounded"/>
> + </xsd:sequence>
> + </xsd:complexType>
> +
> <xsd:complexType name="streamGroupEntryType">
> <xsd:attribute name="key" type="xsd:string"/>
> <xsd:attribute name="value" type="xsd:string"/>
[...]
No more comments from me, looks nice otherwise, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-09 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 20:24 [FFmpeg-devel] [PATCH 1/2 v3] fftools/ffprobe: export Tile Grid " James Almer
2024-03-08 20:24 ` [FFmpeg-devel] [PATCH 2/2 v2] fftools/ffprobe: export IAMF " James Almer
2024-03-09 10:58 ` Stefano Sabatini [this message]
2024-03-09 10:36 ` [FFmpeg-devel] [PATCH 1/2 v3] fftools/ffprobe: export Tile Grid " Stefano Sabatini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZexAvog7Af1aO4lP@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git