From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffprobe: export Tile Grid Stream Group parameters
Date: Thu, 7 Mar 2024 17:46:37 +0100
Message-ID: <Zenvbff9v06+3ESK@mariano> (raw)
In-Reply-To: <Zenogu8O+kVM1WY9@mariano>
On date Thursday 2024-03-07 17:17:06 +0100, Stefano Sabatini wrote:
> On date Wednesday 2024-03-06 21:49:51 -0300, James Almer wrote:
> > Signed-off-by: James Almer <jamrial@gmail.com>
> > ---
> > fftools/ffprobe.c | 53 ++++++++++++++++---
> > tests/fate/mov.mak | 6 +--
> > .../ref/fate/mov-heic-demux-still-image-grid | 29 ++++++++++
> > .../ref/fate/mov-heic-demux-still-image-iovl | 19 +++++++
> > .../fate/mov-heic-demux-still-image-iovl-2 | 19 +++++++
> > 5 files changed, 115 insertions(+), 11 deletions(-)
> >
> > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> > index 4d4a85b5b0..c2ed8336f9 100644
> > --- a/fftools/ffprobe.c
> > +++ b/fftools/ffprobe.c
> > @@ -113,6 +113,7 @@ static int do_show_frames = 0;
> > static int do_show_packets = 0;
> > static int do_show_programs = 0;
> > static int do_show_stream_groups = 0;
> > +static int do_show_stream_group_components = 0;
> > static int do_show_streams = 0;
> > static int do_show_stream_disposition = 0;
> > static int do_show_stream_group_disposition = 0;
> > @@ -209,6 +210,10 @@ typedef enum {
> > SECTION_ID_STREAM_GROUP_STREAM_DISPOSITION,
> > SECTION_ID_STREAM_GROUP_STREAM_TAGS,
> > SECTION_ID_STREAM_GROUP,
> > + SECTION_ID_STREAM_GROUP_COMPONENTS,
> > + SECTION_ID_STREAM_GROUP_COMPONENT,
> > + SECTION_ID_STREAM_GROUP_SUB_COMPONENTS,
> > + SECTION_ID_STREAM_GROUP_SUB_COMPONENT,
> > SECTION_ID_STREAM_GROUP_STREAMS,
> > SECTION_ID_STREAM_GROUP_STREAM,
> > SECTION_ID_STREAM_GROUP_DISPOSITION,
> > @@ -309,7 +314,11 @@ static struct section sections[] = {
> > [SECTION_ID_PROGRAMS] = { SECTION_ID_PROGRAMS, "programs", SECTION_FLAG_IS_ARRAY, { SECTION_ID_PROGRAM, -1 } },
> > [SECTION_ID_STREAM_GROUP_STREAM_DISPOSITION] = { SECTION_ID_STREAM_GROUP_STREAM_DISPOSITION, "disposition", 0, { -1 }, .unique_name = "stream_group_stream_disposition" },
> > [SECTION_ID_STREAM_GROUP_STREAM_TAGS] = { SECTION_ID_STREAM_GROUP_STREAM_TAGS, "tags", SECTION_FLAG_HAS_VARIABLE_FIELDS, { -1 }, .element_name = "tag", .unique_name = "stream_group_stream_tags" },
> > - [SECTION_ID_STREAM_GROUP] = { SECTION_ID_STREAM_GROUP, "stream_group", SECTION_FLAG_HAS_TYPE, { SECTION_ID_STREAM_GROUP_TAGS, SECTION_ID_STREAM_GROUP_DISPOSITION, SECTION_ID_STREAM_GROUP_STREAMS, -1 }, .get_type = get_stream_group_type },
> > + [SECTION_ID_STREAM_GROUP] = { SECTION_ID_STREAM_GROUP, "stream_group", 0, { SECTION_ID_STREAM_GROUP_TAGS, SECTION_ID_STREAM_GROUP_DISPOSITION, SECTION_ID_STREAM_GROUP_COMPONENTS, SECTION_ID_STREAM_GROUP_STREAMS, -1 } },
> > + [SECTION_ID_STREAM_GROUP_COMPONENTS] = { SECTION_ID_STREAM_GROUP_COMPONENTS, "components", SECTION_FLAG_IS_ARRAY, { SECTION_ID_STREAM_GROUP_COMPONENT, -1 }, .element_name = "component", .unique_name = "stream_group_components" },
> > + [SECTION_ID_STREAM_GROUP_COMPONENT] = { SECTION_ID_STREAM_GROUP_COMPONENT, "component", SECTION_FLAG_HAS_VARIABLE_FIELDS|SECTION_FLAG_HAS_TYPE, { SECTION_ID_STREAM_GROUP_SUB_COMPONENTS, -1 }, .unique_name = "stream_group_component", .element_name = "component_entry", .get_type = get_stream_group_type },
>
> > + [SECTION_ID_STREAM_GROUP_SUB_COMPONENTS] = { SECTION_ID_STREAM_GROUP_SUB_COMPONENTS, "subcomponents", SECTION_FLAG_IS_ARRAY, { SECTION_ID_STREAM_GROUP_SUB_COMPONENT, -1 }, .element_name = "component" },
> > + [SECTION_ID_STREAM_GROUP_SUB_COMPONENT] = { SECTION_ID_STREAM_GROUP_SUB_COMPONENT, "subcomponent", SECTION_FLAG_HAS_VARIABLE_FIELDS|SECTION_FLAG_HAS_TYPE, { -1 }, .element_name = "sub_component_entry", .get_type = get_raw_string_type },
>
> consistency: subcomponent or sub_component (probably I'd go with
> SUBCOMPONENT/subcomponent everywhere).
also, missing ffprobe.xsd update?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-07 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 0:49 James Almer
2024-03-07 0:49 ` [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: export IAMF " James Almer
2024-03-07 16:45 ` Stefano Sabatini
2024-03-07 17:49 ` James Almer
2024-03-07 16:17 ` [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffprobe: export Tile Grid " Stefano Sabatini
2024-03-07 16:46 ` Stefano Sabatini [this message]
2024-03-07 17:53 ` James Almer
2024-03-07 17:52 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zenvbff9v06+3ESK@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git