From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 93315491D0 for ; Wed, 6 Mar 2024 16:00:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D81368CB86; Wed, 6 Mar 2024 18:00:49 +0200 (EET) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACC7668BF4B for ; Wed, 6 Mar 2024 18:00:42 +0200 (EET) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a4467d570cdso739895566b.3 for ; Wed, 06 Mar 2024 08:00:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709740841; x=1710345641; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=6RLIUadvk6GqgM8FrkXQZ1WQw+m0pemMc7drD7eU2jY=; b=EOiRnHF+SoGuuHIK/wG9bQwpuy1VnoU5/0E8sBTmw0yL+VTiGBdw6IGbHY/SsTscKp onPCYvI/XSUCewlRgH/nNQPVWtfSBVlg5MrH/JmiWGi8ZuMLbZd2NE4mhpFkAX/02Aea tSSqt1B63CxXDAB/UNI8P1cCfS6fuDBO5QTfODkr9E2r/juX1vzJnb02w2HaAFEt4fvC q66SCVv3+DsNK4XFoXNnvNqpiVsIsFSdtPGAj1VQ9FSW8CJV5vsu4mM/bO1eDdhv7DIH Id+njSLQ2hjzbqhzLEGDB7VYTnnu6v5lRFs9SbDe57M51sakgi/x5sj0F5oIckk50/mf kGDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709740841; x=1710345641; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6RLIUadvk6GqgM8FrkXQZ1WQw+m0pemMc7drD7eU2jY=; b=ezE/UP1+lKwufYN1lPoGL1dX2sWXyvrfa+t+ECAsPKdKW0TAQZ7Y3ucVWj1WHs7und jWNVjbvS0hhjoZGAW1Gu7cVrSUI2RifNonQkiSzK0uisP5mkouZ+R8+KbSz4H8P6UCn1 QNKKBr7XT4hSeq4cofGzrodySxiWLY8/ePEuZyXb+d0rVYXTsAnfc8NyOQRcn7u0fXCt 076xs2DtpLJQ0qh/+kq6nQrT3sDO8+pUdAvlTGB23sBsuA6StVbGVJWzMR+c4Oy5/j1M /1W/hRSJa6EQBvPLHEeDSTV2Ez6tqV+W8LDp+/HkTlsetJNfT254uioZGPq0iYFLIvmN eVUw== X-Gm-Message-State: AOJu0YyLU2Hp96ROacSM0F5kOrdQRFbIq+aZG7U6HvWhapvFLtc6jrr+ qF7SkhyUz+YYrcfwXIVHIJJH2oCxn0DhMLYLWB4cI4sZlsC8M2Jg0g8Uy0X1 X-Google-Smtp-Source: AGHT+IG1jgXuuwDS1mMpmEv87zbPYoWmmJ1x4Kg39Lasjv9rlOQNIC4bvNVhzF6YXIwQPskvy2tPww== X-Received: by 2002:a17:906:5fd9:b0:a45:a7f8:1b6b with SMTP id k25-20020a1709065fd900b00a45a7f81b6bmr3853120ejv.46.1709740840689; Wed, 06 Mar 2024 08:00:40 -0800 (PST) Received: from mariano ([188.210.239.72]) by smtp.gmail.com with ESMTPSA id k6-20020a170906680600b00a45b9660bd7sm864894ejr.38.2024.03.06.08.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 08:00:40 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id D23D5BFCDC; Wed, 6 Mar 2024 17:00:38 +0100 (CET) Date: Wed, 6 Mar 2024 17:00:38 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Marth64 References: <20240306071913.2735832-1-marth64@proxyid.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/dvdvideodec: add CLUT utilities and subtitle palette support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marth64 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Wednesday 2024-03-06 09:43:26 -0600, Marth64 wrote: > It is true that this is necessary when muxing to Matroska, but it is also > the case for MOV - the MOV muxer expects RGB prior to converting to YUV > again. So this would be needed for MOV also, despite the awkward conversion > circle. I should update the document to reflect this. So we might drop the reference to Matroska, or change to something as: Output subtitle palettes (CLUTs) as RGB, as required for example when for subtitles rendering in Matroska or MP4 video. ... I assume there is no heuristic to distinguish RGB/YUV (one trick might be to add some custom metadata for the colorspace so that it can then be read by the encoder). Also I wonder if this is should not rather be an option for the Matroska/MP4 renderer, to avoid duplicating the code. > On Wed, Mar 6, 2024 at 09:36 Marth64 wrote: > > > Good morning, > > > > DVD subtitle palettes, which are natively YUV, are currently carried as > > a hex string in their respective subtitle streams and have > > no concept of colorspace tagging (even predating dvd demuxer). The > > convention is to convert > > them to RGB prior to storage. Common players will only render > > the palettes properly if they are stored as RGB. Even ffmpeg itself > > expects this, and already does -in libavformat- the YUV-RGB conversions, > > specifically in mov.c and movenc.c. > > > > The point of this patch is to provide a consolidation of the code > > that deals with creating the extradata as well as the RGB conversion. > > That can then (1) enable usable palette support for DVD demuxer if it is > > merged > > and (2) start the process of consolidating the related conversions in > > MOV muxer/demuxer and eventually find a way to properly tag > > the colorspace. > > > > Thank you! _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".