From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marth64 <marth64@proxyid.net>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/dvdvideodec: assign mono channel layout explicitly
Date: Wed, 6 Mar 2024 16:10:42 +0100
Message-ID: <ZeiHckFeeQrU0BMk@mariano> (raw)
In-Reply-To: <20240306071913.2735832-3-marth64@proxyid.net>
On date Wednesday 2024-03-06 01:19:13 -0600, Marth64 wrote:
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
> libavformat/dvdvideodec.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
> index 2c7ffdd148..6136060288 100644
> --- a/libavformat/dvdvideodec.c
> +++ b/libavformat/dvdvideodec.c
> @@ -1142,7 +1142,9 @@ static int dvdvideo_audio_stream_analyze(AVFormatContext *s, audio_attr_t audio_
> return AVERROR_INVALIDDATA;
> }
>
> - if (nb_channels == 2)
> + if (nb_channels == 1)
> + ch_layout = (AVChannelLayout) AV_CHANNEL_LAYOUT_MONO;
> + else if (nb_channels == 2)
> ch_layout = (AVChannelLayout) AV_CHANNEL_LAYOUT_STEREO;
> else if (nb_channels == 6)
> ch_layout = (AVChannelLayout) AV_CHANNEL_LAYOUT_5POINT1;
LGTM, but when this is needed?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-06 15:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 7:19 [FFmpeg-devel] [PATCH 1/3] avformat/dvdvideodec: add CLUT utilities and subtitle palette support Marth64
2024-03-06 7:19 ` [FFmpeg-devel] [PATCH 2/3] avformat/dvdvideodec: add menu demuxing support Marth64
2024-03-06 15:41 ` Stefano Sabatini
2024-03-06 16:35 ` Marth64
2024-03-06 7:19 ` [FFmpeg-devel] [PATCH 3/3] avformat/dvdvideodec: assign mono channel layout explicitly Marth64
2024-03-06 15:10 ` Stefano Sabatini [this message]
2024-03-06 15:37 ` Marth64
2024-03-06 15:09 ` [FFmpeg-devel] [PATCH 1/3] avformat/dvdvideodec: add CLUT utilities and subtitle palette support Stefano Sabatini
2024-03-06 15:17 ` Timo Rothenpieler
2024-03-06 15:36 ` Marth64
2024-03-06 15:43 ` Marth64
2024-03-06 16:00 ` Stefano Sabatini
2024-03-07 9:53 ` Anton Khirnov
2024-03-07 10:36 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeiHckFeeQrU0BMk@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=marth64@proxyid.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git