From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8FE8C491B3 for ; Wed, 6 Mar 2024 15:09:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2C1F668CBCB; Wed, 6 Mar 2024 17:09:26 +0200 (EET) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E988368C4F0 for ; Wed, 6 Mar 2024 17:09:19 +0200 (EET) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-563cb3ba9daso1151021a12.3 for ; Wed, 06 Mar 2024 07:09:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709737758; x=1710342558; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=+DRPVtTWhWkvRvMWkQulh3MkC5RgYit9mOmsArUyvQs=; b=KKObeR1yiNql60Zg8ZDmya2KgtSkeezuMVgwEzcoPpXLukcv0L5xdyzEQw/PWzXIkm EgSuqpUwJbOTkq5xlP0QyCYStz9nHNph8MzvSK81ihi62sxeRQZgeYCQKxq+bndBGlOa 7XhpWnuBiXYNdcBq9DRYk/tMg39Ts0J0OucfyGx/Rp7JcW/22dET1s6rOGdj3+rPA4e8 y11zi9x5qXcsLQaUnUE/tD5eqOdj0AV37VC541H7+XU8fEugRotbyQSy/KyupeahDYPj bK/ikAuxwhI0FEiiRJxXwtkW5sqFF1ZVzNiJjxNI64TBV8qMy7DlBvh1TG84Fu7qUXlc 8ztA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709737758; x=1710342558; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+DRPVtTWhWkvRvMWkQulh3MkC5RgYit9mOmsArUyvQs=; b=iP4VxDRq/xn/TrK/nvNnYR3V6iRJ0g7G3mOqjzSgiF7jtG7E22QfP/knqHRP3qWdeC 5cKJFSpG00eFv09O4shM0dSs/jo8zfpT2lOd5ZQocaIGskBIBVJ7BOr/aLoz/sZc9MTc YipSapP/KT7Q3OJzl3WKG2x8MadgyQYAVp0wyDRv04efhb0pCiNWxZncFGxMIkDNwJlF HzO1KzUbrOSnoadrkEXRczvB+I91pGBn+HQAQPB0gEcSalw1KNxeMxybNKbsxSJwlHMX pYU2JNzWMbZnBbu/0Bz66cfwvga5e+7vJt0eMPx4mKQ2iAANERrByCyuEztjqsSN+Ciw LiVQ== X-Gm-Message-State: AOJu0YzOMe3x8mzlbVe/WtWO90PA4qFlMGWqan9n69xJWwCuGEvbJ9eX vZ+wK7sDcVjKMnthD9E2CG4rhZ6OVKCwwt64757O/gHLi4misSI1uMlhuWXL X-Google-Smtp-Source: AGHT+IGtNFg20pYyMAoX0WJp5vlv0vPs6BGKcYOISbq1JXwj5BOsdY4kKSLH3fvBd5+iS+r3l2FoTg== X-Received: by 2002:a50:d60f:0:b0:567:824:e36c with SMTP id x15-20020a50d60f000000b005670824e36cmr10111395edi.14.1709737758070; Wed, 06 Mar 2024 07:09:18 -0800 (PST) Received: from mariano ([188.210.239.72]) by smtp.gmail.com with ESMTPSA id r18-20020aa7cb92000000b005653c441a20sm7028002edt.34.2024.03.06.07.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 07:09:17 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 76734BFCDC; Wed, 6 Mar 2024 16:09:15 +0100 (CET) Date: Wed, 6 Mar 2024 16:09:15 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Marth64 References: <20240306071913.2735832-1-marth64@proxyid.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240306071913.2735832-1-marth64@proxyid.net> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/dvdvideodec: add CLUT utilities and subtitle palette support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marth64 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Wednesday 2024-03-06 01:19:11 -0600, Marth64 wrote: > Since last iteration: removes unused variable in dvdclut.c > > Signed-off-by: Marth64 > --- > doc/demuxers.texi | 5 +++ > libavformat/Makefile | 2 +- > libavformat/dvdclut.c | 75 +++++++++++++++++++++++++++++++++++++++ > libavformat/dvdclut.h | 37 +++++++++++++++++++ > libavformat/dvdvideodec.c | 15 ++++++++ > 5 files changed, 133 insertions(+), 1 deletion(-) > create mode 100644 libavformat/dvdclut.c > create mode 100644 libavformat/dvdclut.h > > diff --git a/doc/demuxers.texi b/doc/demuxers.texi > index f4bac8f3b3..1a17c6db16 100644 > --- a/doc/demuxers.texi > +++ b/doc/demuxers.texi > @@ -394,6 +394,11 @@ often with junk data intended for controlling a real DVD player's > buffering speed and with no other material data value. > Default is 1, true. > > +@item clut_rgb @var{bool} > +Output subtitle palettes (CLUTs) as RGB, required for Matroska. > +Disable to output the palette in its original YUV colorspace. > +Default is 1, true. Can you expand about this? When is matroska used in a DVD? Can we make the setting automatic in case matroska is detected? [...] LGTM otherwise. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".