From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 09BEC47F9F for ; Wed, 6 Mar 2024 13:47:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CEED768CAF7; Wed, 6 Mar 2024 15:47:12 +0200 (EET) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B03F68BDDF for ; Wed, 6 Mar 2024 15:47:06 +0200 (EET) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a44d084bfe1so569477066b.1 for ; Wed, 06 Mar 2024 05:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709732825; x=1710337625; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=xVMdbwBy7pry+rzlalsBGxpfflzv2ZCaRaXQUx/dXUk=; b=UzZv7PdUPtlEDSvdlp9bArn7N4kZ1QIGr9Jeh/yuUOOpKiCRLDFmjwbS2083voEvsO WqOJFlj9D15V6iKBRv1UDxEZ+8cX4kdYlocsVJwtDXT2kR+naTCij2WLBkvzXWArwNz8 AS2yuHZf66q+CN/5g1E9liaww3G+2cBJyYY8v8l5HcEbd0wAX3shw3H8gQN50d/hvYlu FJutoGp3hnVnalThraJujqzW+Q0H/4iL7E4vE+96SGxeUODmxGpMSDOkKgb2fGHl+uvh tA/YnWJ/4oU+gPNyrWtRVGpYoLnxRup7Onfp8sTSRO0Vfc6nDFH7ELCy2UFhFsy6+7+9 wotw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709732825; x=1710337625; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xVMdbwBy7pry+rzlalsBGxpfflzv2ZCaRaXQUx/dXUk=; b=nQTAGQOWQw/0N1EnnJnHYH0kubLjr4CKgD+O64wQbKuKfXuqdeHl6E3Uu4GTXCXpY9 6OLSpOXmwg6GNKLgf7m9S0qI4Lxg+wE8pzGOiSDm9EYuRyS8NPp1O/0bKfP5TiOucSI3 t/gXQaydGZERq1a0pe7UBXPrsa6xnT7siJz6m55PGdlb+RaduXzZIrAuZTVZ4bNJS3tj KHuf7ZVfTPOuxk+PhtM4S32cT4QeV/u+mmLbUTiJc7Jt/GO5w5OAPC7vWyL7cANshMCf FugvHEKf21lNqprwUbKZQm6IFSZna9leX0lruQACkKtmsIk717FwPqdJKmMxYD3wunf0 ZFuQ== X-Gm-Message-State: AOJu0YwSwvj8K09pKX0Rb0SS6XJ4g3EtGW8NH6yKMGADUfzSxpu5+jQ6 TZiPK6eUNjZKovOHg5Lqml522+gy7NqyUaEai/YSTcEg9oNhLNpTBJUb6Kd+ X-Google-Smtp-Source: AGHT+IG/Nade+SVCx02m2acpjTaIs8JXwxHccLW/TSXibmhOkezSh2q/aqntnYTRNsa2boy3/aIzWw== X-Received: by 2002:a17:906:b792:b0:a3e:eb81:ab5b with SMTP id dt18-20020a170906b79200b00a3eeb81ab5bmr9903448ejb.54.1709732824659; Wed, 06 Mar 2024 05:47:04 -0800 (PST) Received: from mariano ([188.210.239.72]) by smtp.gmail.com with ESMTPSA id j23-20020a170906279700b00a45a62e0ed0sm1915566ejc.98.2024.03.06.05.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 05:47:04 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 4AB4EBFCDC; Wed, 6 Mar 2024 14:47:02 +0100 (CET) Date: Wed, 6 Mar 2024 14:47:02 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Marton Balint References: <20240305225147.6849-1-cus@passwd.hu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240305225147.6849-1-cus@passwd.hu> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 1/9] avcodec/bsf/pcm_rechunk: reorder supported codec list X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2024-03-05 23:51:39 +0100, Marton Balint wrote: > Should be easier to add new codecs by using the same order as in > av_get_exact_bits_per_sample(). > > Signed-off-by: Marton Balint > --- > libavcodec/bsf/pcm_rechunk.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/bsf/pcm_rechunk.c b/libavcodec/bsf/pcm_rechunk.c > index 28b5722ac9..9bbc5a74d6 100644 > --- a/libavcodec/bsf/pcm_rechunk.c > +++ b/libavcodec/bsf/pcm_rechunk.c > @@ -193,21 +193,26 @@ static const AVClass pcm_rechunk_class = { > }; > > static const enum AVCodecID codec_ids[] = { > - AV_CODEC_ID_PCM_S16LE, > - AV_CODEC_ID_PCM_S16BE, > + // 8 bit > AV_CODEC_ID_PCM_S8, > - AV_CODEC_ID_PCM_S32LE, > - AV_CODEC_ID_PCM_S32BE, > - AV_CODEC_ID_PCM_S24LE, > + // 16 bit > + AV_CODEC_ID_PCM_S16BE, > + AV_CODEC_ID_PCM_S16LE, > + // 24 bit > AV_CODEC_ID_PCM_S24BE, > + AV_CODEC_ID_PCM_S24LE, > + // 32 bit > + AV_CODEC_ID_PCM_S32BE, > + AV_CODEC_ID_PCM_S32LE, > AV_CODEC_ID_PCM_F32BE, > AV_CODEC_ID_PCM_F32LE, > + AV_CODEC_ID_PCM_F24LE, > + AV_CODEC_ID_PCM_F16LE, > + // 64 bit > AV_CODEC_ID_PCM_F64BE, > AV_CODEC_ID_PCM_F64LE, > - AV_CODEC_ID_PCM_S64LE, > AV_CODEC_ID_PCM_S64BE, > - AV_CODEC_ID_PCM_F16LE, > - AV_CODEC_ID_PCM_F24LE, > + AV_CODEC_ID_PCM_S64LE, > AV_CODEC_ID_NONE, or just use lexical order (given than AV_CODEC_ID_PCM_F24LE/AV_CODEC_ID_PCM_F16LE => 32 might be confusing). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".