From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 771BE49199 for ; Wed, 6 Mar 2024 14:24:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E5DD368CB57; Wed, 6 Mar 2024 16:24:42 +0200 (EET) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E1CF68CB57 for ; Wed, 6 Mar 2024 16:24:36 +0200 (EET) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a45aa7cb2b3so235126066b.3 for ; Wed, 06 Mar 2024 06:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709735075; x=1710339875; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ypTJM6ZJsA0T2AHMcHa4vZHFINhOyxO/nieJLUZQS40=; b=heMdift8QhcNKVnDWcyIGGXcceKJ+S/TqJwuE9JZpFBLQTLrt8bAFK1HPkPET8TO08 X8aMh1kSgknshTrk0ETvlAG3MguGV2wSyNTl3Etwz4IE98NN1WBG5Eh/OpSROhv5ihZO dNbIeeknxEA5MMBJMf0E85rLw0wAsqYG6pIJzC7zlBYtY3J9Or8uyZf0Khhhq383JNPQ X4eWCDVJ80fjEhTs+0cB3/NbY6k1wmJdEjSrFCIuIcqZmZ7IaHVnhZCpu4YA6aGVjlJs cfrCHO28LHhe2b+NwCGDz9SRJLyZ8bf7pD86uOCWF9tty7JtoncV+ecqh0NKvNHCLmAS rOTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709735075; x=1710339875; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ypTJM6ZJsA0T2AHMcHa4vZHFINhOyxO/nieJLUZQS40=; b=YhR8m89ptyjiGkeiuZtL/vcJ7s/Parm/QzOtfYBNnCayV4WpIuXucFvNwFpii1CDif FPtstHvPyyHEybIe8uJPJufNXE8RWDuw4aKtzSwLHZI3DR2RAyxt8toJ21qTYGLeFMLP LD+MsbCA58iUJHOm3UIai2AcV7Co2ejw7gxzdgUOZj5mQWwUDdh54DIy1/64dC1UQok+ fNwRWQJ35/TcYSlJ0nACmMGNJjncuIUZ9NkCM/Ve9QJXUMl7uULVpEBywo+pek0Jri38 33s7Wy6+TMp3CtbS2Ko1swROT26L7n11oNGfU6YYksXQ2yqh9nfgrxACcpHvIJ3F9mN+ If1w== X-Gm-Message-State: AOJu0YxSHhd0DIL3NIAcvidyYUIFeYDeVuyTwdNrGfx58/8XC7WKybyA SmfBZzc0Xa6s5iC/gKMUz4Ej3M/826n788Uik/MXcWi91FPKYEfu1D7KA7O/ X-Google-Smtp-Source: AGHT+IH18+m3D7rKbV9PsAdatmrBXAjVEwKKcGw7AXac/PVp66CkupYsWU/fJEbjdPBB/aoCAF7xbA== X-Received: by 2002:a17:906:f148:b0:a43:ef41:e9e2 with SMTP id gw8-20020a170906f14800b00a43ef41e9e2mr10463582ejb.52.1709735074702; Wed, 06 Mar 2024 06:24:34 -0800 (PST) Received: from mariano ([188.210.239.72]) by smtp.gmail.com with ESMTPSA id oy29-20020a170907105d00b00a43fe57b2basm7175328ejb.61.2024.03.06.06.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 06:24:34 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 69298BFCDC; Wed, 6 Mar 2024 15:24:32 +0100 (CET) Date: Wed, 6 Mar 2024 15:24:32 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Marton Balint References: <20240305225147.6849-1-cus@passwd.hu> <20240305225147.6849-3-cus@passwd.hu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240305225147.6849-3-cus@passwd.hu> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 3/9] avformat/daudenc: force 2000 sample packet size with a bsf X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2024-03-05 23:51:41 +0100, Marton Balint wrote: > The samples I found all have 2000 sample packets, and by forcing the packet > size with a bsf we could automagically make muxing work for packets containing > more than 3640 samples. > > Signed-off-by: Marton Balint > --- > configure | 1 + > libavformat/daudenc.c | 11 +++++------ > tests/ref/fate/dcinema-encode | 31 +++++++++++-------------------- > 3 files changed, 17 insertions(+), 26 deletions(-) > > diff --git a/configure b/configure > index bbf1a70731..4ac8758a03 100755 > --- a/configure > +++ b/configure > @@ -3525,6 +3525,7 @@ caf_demuxer_select="iso_media" > caf_muxer_select="iso_media" > dash_muxer_select="mp4_muxer" > dash_demuxer_deps="libxml2" > +daud_muxer_select="pcm_rechunk_bsf" > dirac_demuxer_select="dirac_parser" > dts_demuxer_select="dca_parser" > dtshd_demuxer_select="dca_parser" > diff --git a/libavformat/daudenc.c b/libavformat/daudenc.c > index 37c20618bd..a995838351 100644 > --- a/libavformat/daudenc.c > +++ b/libavformat/daudenc.c > @@ -25,6 +25,7 @@ > static int daud_init(struct AVFormatContext *s) > { > AVCodecParameters *par = s->streams[0]->codecpar; > + int ret; > > if (par->ch_layout.nb_channels != 6) { > av_log(s, AV_LOG_ERROR, > @@ -40,17 +41,15 @@ static int daud_init(struct AVFormatContext *s) > return AVERROR(EINVAL); > } > > + ret = ff_stream_add_bitstream_filter(s->streams[0], "pcm_rechunk", "n=2000:pad=0"); > + if (ret < 0) > + return ret; > + > return 0; > } Cannot really comment about the implication of adding an automatic bsf a the muxer level, but if this is acceptable probably you can also simplify the doc/muxers/daud documentation (also I think we have a ticket about this issue), since this lift the need to use setnsamples. [...] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".