From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3A42D48526 for ; Wed, 6 Mar 2024 14:18:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6BBBD68CB6E; Wed, 6 Mar 2024 16:18:50 +0200 (EET) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5E3AC68C7E6 for ; Wed, 6 Mar 2024 16:18:44 +0200 (EET) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-56454c695e6so1647767a12.0 for ; Wed, 06 Mar 2024 06:18:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709734723; x=1710339523; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=VbNPBN4a3FVwODocqcIFWGIoprYF53uYfxHG35H6EeI=; b=kcMIhQmJkJVPHJU0tciqMKqHmHtvyMLn5UZ+TyFjDZQJqs9RCi7UpTCi6ZLR6WkHlL PtqnNZW2vcznm8KHrzDP7ekx9szQPSTICZlTZVuDp6iuwqT4geFyNyGT5K8qyuGsQVlI N/ZwXWSA+2xfz8VUvgBUEf8LpcyFQS0ah5IUFo7AbyD0tInUK+IxHCt8+at7vAKs/aVO CXh+SGv7a5p3tb+8f7hS0am57z5Ppng+a12hvHJcZu2J1Fe1cyYKB8cn3txsua9kFblL TzsRfHKJB53r3/QJtVBZSCm1Bb3rIgbq1udWksqAzb4D1jVDQs+mTZgGJ/NGElabJYiI 95JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709734723; x=1710339523; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VbNPBN4a3FVwODocqcIFWGIoprYF53uYfxHG35H6EeI=; b=BH1D9j1gknkyKxg8qAhQbhFxncqsKKcfmtEJ5Wm1KRgkefb1ndUQaXwVw6zwTrLLNZ IxewU6J9Zshau7DYyA6neWqMn2BCZxl4HjJGtgxw+Cfu7XCr6K48Ux3bNPD8FOQVBy8A x/3guHuLJNGw8fPcepJs/Bn8zcpP9049fPhEjUojpDGNvhAKk9TKkJD79r2euvzPokR/ BVxSG+oivUkYNvsyCGArYLEuVJoNyz4qIq1KrEbYEKo15v4OcnTWaK7vTS1hr7S9+QBL lHbnQeaGhSFgFGQrs9pZ7ym86CkRYaBebebfHW403BPU9tKn6l7clzRQ1z1MkmwavTrW a5dg== X-Gm-Message-State: AOJu0Yy1/40OwjS6kibD/xdcTEay+b1wAO6PvK/5XpHKuUlkup+44x8y nj/fTZzLXpDGt6M+p56tRAQQgV09YdDnNzj2JHnkwIMBRlipdh8l72LJR/DJ X-Google-Smtp-Source: AGHT+IHp6XgE0qeJGMJdiGXENsm+uTt2yJMS3IE6ORpJNL7UO/X+rDtHqfzpQnWazlqG6i/cNWftsg== X-Received: by 2002:a05:6402:902:b0:566:201e:c18d with SMTP id g2-20020a056402090200b00566201ec18dmr5768802edz.13.1709734722378; Wed, 06 Mar 2024 06:18:42 -0800 (PST) Received: from mariano ([188.210.239.72]) by smtp.gmail.com with ESMTPSA id t1-20020a056402240100b0056671c5c1a1sm7052960eda.80.2024.03.06.06.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 06:18:42 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id BBFCDBFCDC; Wed, 6 Mar 2024 15:18:40 +0100 (CET) Date: Wed, 6 Mar 2024 15:18:40 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Marton Balint References: <20240305225147.6849-1-cus@passwd.hu> <20240305225147.6849-2-cus@passwd.hu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240305225147.6849-2-cus@passwd.hu> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 2/9] avcodec/bsf/pcm_rechunk: add some more supported PCM formats X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2024-03-05 23:51:40 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavcodec/bsf/pcm_rechunk.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/bsf/pcm_rechunk.c b/libavcodec/bsf/pcm_rechunk.c > index 9bbc5a74d6..7198554c17 100644 > --- a/libavcodec/bsf/pcm_rechunk.c > +++ b/libavcodec/bsf/pcm_rechunk.c > @@ -108,6 +108,18 @@ static int get_next_nb_samples(AVBSFContext *ctx) > } > } > > +static void set_silence(AVCodecParameters *par, uint8_t *buf, size_t size) > +{ > + int c = 0; > + switch (par->codec_id) { > + case AV_CODEC_ID_PCM_ALAW: c = 0xd5; break; > + case AV_CODEC_ID_PCM_MULAW: > + case AV_CODEC_ID_PCM_VIDC: c = 0xff; break; > + case AV_CODEC_ID_PCM_U8: c = 0x80; break; > + } > + memset(buf, c, size); > +} Didn't verify these. > + > static int rechunk_filter(AVBSFContext *ctx, AVPacket *pkt) > { > PCMContext *s = ctx->priv_data; > @@ -158,7 +170,7 @@ static int rechunk_filter(AVBSFContext *ctx, AVPacket *pkt) > ret = ff_bsf_get_packet_ref(ctx, s->in_pkt); > if (ret == AVERROR_EOF && s->out_pkt->size) { > if (s->pad) { > - memset(s->out_pkt->data + s->out_pkt->size, 0, data_size - s->out_pkt->size); > + set_silence(ctx->par_in, s->out_pkt->data + s->out_pkt->size, data_size - s->out_pkt->size); > s->out_pkt->size = data_size; > } else { > nb_samples = s->out_pkt->size / s->sample_size; > @@ -194,11 +206,17 @@ static const AVClass pcm_rechunk_class = { > > static const enum AVCodecID codec_ids[] = { > // 8 bit > + AV_CODEC_ID_PCM_ALAW, > + AV_CODEC_ID_PCM_MULAW, > + AV_CODEC_ID_PCM_VIDC, > AV_CODEC_ID_PCM_S8, > + AV_CODEC_ID_PCM_SGA, > + AV_CODEC_ID_PCM_U8, > // 16 bit > AV_CODEC_ID_PCM_S16BE, > AV_CODEC_ID_PCM_S16LE, > // 24 bit > + AV_CODEC_ID_PCM_S24DAUD, > AV_CODEC_ID_PCM_S24BE, > AV_CODEC_ID_PCM_S24LE, > // 32 bit Looks good to me. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".