From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 782AB49C3C for ; Tue, 5 Mar 2024 14:52:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A3AE668CFCE; Tue, 5 Mar 2024 16:52:16 +0200 (EET) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C6A4068CD06 for ; Tue, 5 Mar 2024 16:52:10 +0200 (EET) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-563d32ee33aso6971937a12.2 for ; Tue, 05 Mar 2024 06:52:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709650330; x=1710255130; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=GCF4MgYdm3l0ormxm5jIiix5Cv3Wvz7TdFc32bs70qA=; b=j0/5mLXAPmHl6rk2n9E1hakY+Vc9PUDi+r5vfiimXHxIg3IEYpy3M/n7HyC7xzf0Dc fhVxYBz8E96jiY8utBh2YdV+LsCK1vXtoD7JAfqhppSmkARINIgmKa2mQzLjuCsHl6WI QXGFuZoi5jabaBxHKD/sFFLaMfpgrLJvCLhsNjX9jncztbZu1pA5gDriKNEU4K2U9ROH SH/Erw0LTv5jROkEbrl9fso08YmNAg+GRP0QeZq8R/A4s/9iyguXmQipqEhZLhqTT202 PWGSTOWq0cuyS6SjqsGtV8/MaiDiW+uUmqt6JJfILYaFxsjjtvZYUPqoH085mqp6KS3d 0iVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709650330; x=1710255130; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GCF4MgYdm3l0ormxm5jIiix5Cv3Wvz7TdFc32bs70qA=; b=lQxrQIvVY0n+zReLDipAC/TiBWgphcol2ft0tllYk2ryZrWFvzDm9UiNCdvaG11bzG mU6vVGWpp/0xKr469wJoHe7lnd9Z7+AVA9NKtQRWJ6eo0IS+XFQeAo2JFggqqU/6QtjU dZPuT7KlLJkk8yeR4g+Zs1qrPEgbzWrqVY6eqo1EqXusYNB3BIOeUBh3dzql9mkZCbpi lUm8u3qxu8F/qAbpF3lUl0WWHx6xj4yJHTRpZ5oeo0YzOT72M+j5XOCUWATJTz6bom89 wFTG7Y+dBq/HK7KblNudyLwaIlO3S8FNhqoawXw7ay5dKVFYmclW3lqgHmzM4qx4VICc n6ow== X-Gm-Message-State: AOJu0Yys3PHypNU9aDSGeNq784YMUiXhUPrv/U0dCBki/yx2xUOi5Bgm KxDFUqX/x7sghGn8lt+5JWtk+u+8o3aaZdjnI1GS19wlQ1H0Kz0ZzT+pYRfR X-Google-Smtp-Source: AGHT+IFZgKMYQ+Gpb8y7QduUUTueD/yKj1odxe4a/vWERckH/TYwLf53qmgVXwrrmsLdMC2P5NnWMg== X-Received: by 2002:a50:8d89:0:b0:566:16f4:1bc with SMTP id r9-20020a508d89000000b0056616f401bcmr7885916edh.7.1709650329575; Tue, 05 Mar 2024 06:52:09 -0800 (PST) Received: from mariano ([188.210.239.69]) by smtp.gmail.com with ESMTPSA id i17-20020aa7c9d1000000b00567566227a5sm2212173edt.18.2024.03.05.06.52.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 06:52:09 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 5C511BFCDC; Tue, 5 Mar 2024 15:52:08 +0100 (CET) Date: Tue, 5 Mar 2024 15:52:08 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240305000033.10379-1-jamrial@gmail.com> <20240305000033.10379-2-jamrial@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 2/9] avformat/avformat: add a function to return the name of stream groups X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2024-03-05 15:50:23 +0100, Stefano Sabatini wrote: > On date Monday 2024-03-04 21:00:22 -0300, James Almer wrote: > > Signed-off-by: James Almer > > --- > > Missing version bump and APIChanges entry. > > > > libavformat/avformat.c | 10 ++++++++++ > > libavformat/avformat.h | 5 +++++ > > 2 files changed, 15 insertions(+) > > > > diff --git a/libavformat/avformat.c b/libavformat/avformat.c > > index eb898223d2..98dfac2f89 100644 > > --- a/libavformat/avformat.c > > +++ b/libavformat/avformat.c > > @@ -321,6 +321,16 @@ AVStream *ff_stream_clone(AVFormatContext *dst_ctx, const AVStream *src) > > return st; > > } > > > > +const char *avformat_stream_group_name(enum AVStreamGroupParamsType type) > > +{ > > + switch(type) { > > + case AV_STREAM_GROUP_PARAMS_IAMF_AUDIO_ELEMENT: return "IAMF Audio Element"; > > + case AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION: return "IAMF Mix Presentation"; > > + case AV_STREAM_GROUP_PARAMS_TILE_GRID: return "Tile Grid"; > > + } > > + return NULL; > > +} > > + > > AVProgram *av_new_program(AVFormatContext *ac, int id) > > { > > AVProgram *program = NULL; > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > > index f4506f4cf1..c41041b1bc 100644 > > --- a/libavformat/avformat.h > > +++ b/libavformat/avformat.h > > @@ -2120,6 +2120,11 @@ const AVClass *av_stream_get_class(void); > > */ > > const AVClass *av_stream_group_get_class(void); > > > > +/** > > + * @return a string identifying the stream group type > > + */ Also add a note that this will return NULL in case of unknown stream group type. > > +const char *avformat_stream_group_name(enum AVStreamGroupParamsType type); > > + > > LGTM (remember to bump minor and add entry to doc/APIchanges before > pushing). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".