From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3ECDA49C2F for ; Tue, 5 Mar 2024 14:43:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6D1B968CF0B; Tue, 5 Mar 2024 16:43:09 +0200 (EET) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7131F68CC5D for ; Tue, 5 Mar 2024 16:43:03 +0200 (EET) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-56759dc7ea6so2943345a12.1 for ; Tue, 05 Mar 2024 06:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709649782; x=1710254582; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=3fy/ZK0G4S4bvl2ZndfdCBNm+n7uGJFixuNZUBmIp5U=; b=fb/1oM5VFnZ4ZQIAEdEtSv/8aTsc73WG+wIwUz8zM0jK2CcIEMVq9P/daYHK7paXJ8 vicRJ6Y39y8KWxJT4Je9GbvpGtBTqD4AwyP5TloXNbaItk3ph7HPp0R1/dp05wyLY3mC 5Bc0DEdrDle12uGPM5Hwm55uX+MyLx2gYzDtJxwxXf3Nto55flwT78lBTl6AwgfIZI0E IWve1ILO97YtiAvdmJjpXivP/xynIKKuPkbCaX9f4jj/I5ymo4T2KI9syudNvuzFeYlb QTUQnq+2Lu9NH9ZwB4uLFdS/2gxDAf732G5RpC5qWi/9rqmFs92MhS1oloY7UBoidIDt 05Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709649782; x=1710254582; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3fy/ZK0G4S4bvl2ZndfdCBNm+n7uGJFixuNZUBmIp5U=; b=ioyDTwIcPLaFi4jsSpB/0dH0FsnTuzGL45UUVGLGftRSke4cKKa92CRYMMDZtjR3hk qG/dG4b5Rwr+lYYvCjAAe2ORuavJbmCAaWb6fnyhJKKGPX+liNW2mj7jwpgKqYa5bvAb Bywo8MRp/BOmAHRabeUIBqFqNcWZa9KYn/UFjJ0U+f753wZQsp6L2bgyD+CDsak+8WMO ehORn9iBxeZlOF95T71K8nf3i7p2h5lpR9Od3EA/P4hewylQIQJPXVw2ASZb3g39BUoi WQc7KNmN40pw3CUTdrOoejaKm4PGGmqCM7E8xK09urjvA7xL1Gl3R0Qp1AW6bQzHkms3 vY3Q== X-Gm-Message-State: AOJu0Yzds5/p1T7NrwfXhXORcIKTZet79pBxiiQRGA4xhY+TzRWap3YE y4WV84bmdRfBnkRnKlwgm5A42ABoI8YLI/elpkDhOmoUHqwEYqptpjnd5uqm X-Google-Smtp-Source: AGHT+IFOfJNZgWVIxRFCdBq0hyxghq+2aghfFhDYkXKRPbwIyRHk+ABR4kBsZmFCApf76oolFvR/JQ== X-Received: by 2002:a17:906:ff53:b0:a3e:c818:b7f with SMTP id zo19-20020a170906ff5300b00a3ec8180b7fmr9034771ejb.29.1709649782116; Tue, 05 Mar 2024 06:43:02 -0800 (PST) Received: from mariano ([188.210.239.69]) by smtp.gmail.com with ESMTPSA id o7-20020a170906288700b00a42ed7421b8sm6175933ejd.93.2024.03.05.06.43.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 06:43:01 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 76A12BFCDC; Tue, 5 Mar 2024 15:43:00 +0100 (CET) Date: Tue, 5 Mar 2024 15:43:00 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240304185646.9755-1-jamrial@gmail.com> <96729593-7417-46f8-8b3c-f7ea646bb5b2@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <96729593-7417-46f8-8b3c-f7ea646bb5b2@gmail.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix printing side data components and pieces X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2024-03-05 11:38:20 -0300, James Almer wrote: > On 3/5/2024 11:34 AM, Stefano Sabatini wrote: > > On date Monday 2024-03-04 15:56:46 -0300, James Almer wrote: > > > Components and pieces are side data specific fields and there's a variable > > > amount of them. > > > They also need to be identified in some form, so print a type too. > > > > > > Signed-off-by: James Almer > > > --- > > > You can see the difference with > > > > > > ffprobe -show_frames -of compact $fate_samples/mov/dovi-p7.mp4 > > > ffprobe -show_frames -of xml $fate_samples/mov/dovi-p7.mp4 > > > > > > fftools/ffprobe.c | 33 +++++++++++++++++++++++++++------ > > > 1 file changed, 27 insertions(+), 6 deletions(-) > > > [...] > > LGTM. Not clear if this is fixing a regression or if the format (at > > least for XML/compact) was always wrong. > > I'm on the fence on this. Try removing the SECTION_FLAG_HAS_TYPE from > SECTION_ID_FRAME_SIDE_DATA_COMPONENT and SECTION_ID_FRAME_SIDE_DATA_PIECE > and the output is broken again for the compact output. So at least > compact_print_section_header() may be faulty. I did not investigate much > because I'm not familiar with the code. That is, if you define the type (as in the current implementation) it looks correct? > In any case, this change is needed because of the > SECTION_FLAG_HAS_VARIABLE_FIELDS addition for side data where the printed > fields are not a fixed amount. Agree. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".