From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 923CC49DBB for ; Mon, 11 Mar 2024 16:28:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E88E468D098; Mon, 11 Mar 2024 18:28:47 +0200 (EET) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0130768CB61 for ; Mon, 11 Mar 2024 18:28:41 +0200 (EET) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5682360e095so5256259a12.1 for ; Mon, 11 Mar 2024 09:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710174520; x=1710779320; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=E2ZXw7b6cYc+7pBfmsKi0StYn3xxCdiau4tJKYJ8Mq8=; b=HRxJUtJ3nEO3pnjmmMVi8NH/q1kNnC5u8zqJNeEyPjwHGyDdgWuUr7s3HuWe/CJJ4t tuB3vlF//2el9MDY4EMaNz7CIvCcQHY2kWWwCMlIErQrqTWR95KsMPpHF2Q+Zk/cA9L9 Wu8iADBQupxX2mWDq9UrKWB6beAyFkLEoMHVs6g08Q4eozdvPPbqjjQi/sfvXvxG6q7+ K4+S7lfPggOcaDPdHby3ms4F9CO8OPduUH/Z0RBowx5Sag62dSXQTD5lmH+RgoCzXjBM iB2jmRdqC2W9jC0ZfIg/HMovkDk6ETez6BrHhEkfLFVdQITH/goz95/80Jru+7ShHUzu qrsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710174520; x=1710779320; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E2ZXw7b6cYc+7pBfmsKi0StYn3xxCdiau4tJKYJ8Mq8=; b=BvwlPL4UrNFToIBNg/gzK9+7fRA3ee9KqIdO6TJk9i5s5ORQ9YQyHPVIB3XK0rcoXf 3WlOP3YdZgPC6k41jCtl2f7JjN14A2WxzBp8Nj24gCSklWT5wIreJng75sHMD2Qxs/8c 9EI4zG8jCIVjzFx/Muw69mkPDqijebwLiJiVS6QEdEIb2hnlZHa1nyt1LwwJW6qX0OJo syL7hHf9zu6lQuIBTZZV4bUrEkfWgVXRonkD+ab312cgfBoMnP57cAo9cQqHFH1s4gXi a8Szc56+AbfvA1353TULB+/OcrdwgPeniLEpw2PBHWZtJXOHGCKjHk9xFpf8QQc6ApO4 Tpvw== X-Gm-Message-State: AOJu0YzCN9prbChwzz5/0kgKeSWhSAdkZi5TllupNJrw9sko6IoIbiRp z+I4RuzZaNUhdiWVKC4f+LghNiVPMbBTKeSRwvrEyg2jTZjnOMDXtIvSNTAj X-Google-Smtp-Source: AGHT+IFfXIAnukGjCrkGjLXNYHJL3k/nVqzSP76sYxibYvFJwYxEwKXT0XJYxyiE8mVhWzNf3ZlIAA== X-Received: by 2002:a17:907:a707:b0:a46:31e:e308 with SMTP id vw7-20020a170907a70700b00a46031ee308mr4663870ejc.31.1710174520425; Mon, 11 Mar 2024 09:28:40 -0700 (PDT) Received: from mariano ([188.210.239.79]) by smtp.gmail.com with ESMTPSA id bx21-20020a170906a1d500b00a45ff890df0sm2877519ejb.35.2024.03.11.09.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 09:28:40 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 0917ABFCDC; Mon, 11 Mar 2024 17:28:39 +0100 (CET) Date: Mon, 11 Mar 2024 17:28:38 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Marth64 References: <20240311004047.140612-1-marth64@proxyid.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240311004047.140612-1-marth64@proxyid.net> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: don't print multiple \pos tags per cue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marth64 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-03-10 19:40:47 -0500, Marth64 wrote: > Currently, Closed Captions decoder prints multiple \pos ASS tags per line, > per cue. This is invalid behavior, because only the first \pos tag in a cue > is honored by ASS anyway. Don't write multiple \pos tags. > > Signed-off-by: Marth64 > --- > libavcodec/ccaption_dec.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c > index faf058ce97..9d4a93647c 100644 > --- a/libavcodec/ccaption_dec.c > +++ b/libavcodec/ccaption_dec.c > @@ -456,7 +456,7 @@ static void roll_up(CCaptionSubContext *ctx) > > static int capture_screen(CCaptionSubContext *ctx) > { > - int i, j, tab = 0; > + int i, j, tab = 0, seen_row = 0; > struct Screen *screen = ctx->screen + ctx->active_screen; > enum cc_font prev_font = CCFONT_REGULAR; > enum cc_color_code prev_color = CCCOL_WHITE; > @@ -496,7 +496,11 @@ static int capture_screen(CCaptionSubContext *ctx) > > x = ASS_DEFAULT_PLAYRESX * (0.1 + 0.0250 * j); > y = ASS_DEFAULT_PLAYRESY * (0.1 + 0.0533 * i); > - av_bprintf(&ctx->buffer[bidx], "{\\an7}{\\pos(%d,%d)}", x, y); > + > + if (!seen_row) { > + av_bprintf(&ctx->buffer[bidx], "{\\an7}{\\pos(%d,%d)}", x, y); > + seen_row = 1; > + } > > for (; j < SCREEN_COLUMNS; j++) { > const char *e_tag = "", *s_tag = "", *c_tag = "", *b_tag = ""; LGTM, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".