From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C111E49DAC for ; Mon, 11 Mar 2024 15:39:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E5C3C68CEE5; Mon, 11 Mar 2024 17:39:56 +0200 (EET) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 992A568C3D2 for ; Mon, 11 Mar 2024 17:39:50 +0200 (EET) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-51381021af1so4104030e87.0 for ; Mon, 11 Mar 2024 08:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710171589; x=1710776389; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=vVIZHtxZU1zy59SVEclu7MW5dTkjDPqUJuxhAzOIWCI=; b=Bp8iy/rJjYozJe3Ao7lCDBN0MrWV1/8HNZlex6otWPPaLG3cZPRkWxP1wjjw4da8f/ wlFcFq43u7wiLoDdo7xY1HKmSKtv3yHvcJx36EHhMOntVLpKJNsxN1vuJwrhvLTdWqPU X4amsKYMI1DSzK5NdXPKWrMGyemmanjL0th4nB2TeRaY1RhgCsX6hrBsntVuTz6E7/t5 qljvhjbEPIdh8mF/0R9eN/749IH+fUsOKlRaJXS3DXIfJZqCL9X0dhSTOTgtOYDtCTam Bt+VqOD0b+6eC+0SeJZffw17dgDrFtOxH+XVxGymbcsA9BmPSN5k+jVRTQetzNaJrlhd +kOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710171589; x=1710776389; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vVIZHtxZU1zy59SVEclu7MW5dTkjDPqUJuxhAzOIWCI=; b=C8A7qYJUpPKeHMc050c/KBAFlwFcFMiyDAfpft4FjEOoeCCYsbMXtYGv96QI+tMLNh wxADrtZnTDGD4MyWz3FxzDXdYQuHrbYmttfbxaMOYPVWbzCPhJxKgUPjsb0xEv5gdXSJ ER/w2AKueWcBKDToV0hwRYbzgPRac0AYeBe4/b3QLD901VuHJZwbQCZymgxSoMJhrNDe jSqJTMQtdNAyyn1ItGVfcDO4Yo/lX9vP0vHzMYQ6uwCiGpE4L9nx89NeiDdMN8DA1Q1B BUbBRS38WdDdrIQbYADYhB3GbZ+Nlc/LFJm0AnFRxlmsW8LLBfNpyFaT2zzERUKGIhDg 6bjg== X-Gm-Message-State: AOJu0YwoOI66cO9sMbSODmwpnGUjMAYEL9zRsco17icImXpnzwKZmTEG bLfgt/nG+sqCtJHA/wZrcBTxgbesbuuAYsl5W2nWHlusvaf4trjQEGmTrAVu X-Google-Smtp-Source: AGHT+IF4xmsAtxVlx6Ul5VSOxpUwWnAhR5kFVtAaZDF0MFy5a7EuhFPZMtw4arbwbFa0z7zzPOF2QQ== X-Received: by 2002:a19:2d1b:0:b0:513:9ccd:2ae0 with SMTP id k27-20020a192d1b000000b005139ccd2ae0mr4339993lfj.15.1710171588621; Mon, 11 Mar 2024 08:39:48 -0700 (PDT) Received: from mariano ([188.210.239.79]) by smtp.gmail.com with ESMTPSA id m17-20020a170906721100b00a450b817705sm2929284ejk.154.2024.03.11.08.39.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 08:39:47 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 767E6BFCDC; Mon, 11 Mar 2024 16:39:46 +0100 (CET) Date: Mon, 11 Mar 2024 16:39:46 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 4/6] avcodec/tiff: Improve inclusions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-03-10 17:06:18 +0100, Andreas Rheinhardt wrote: > Stefano Sabatini: > >> diff --git a/libavcodec/tiff.h b/libavcodec/tiff.h > >> index e67c59abad..2dd21dea52 100644 > >> --- a/libavcodec/tiff.h > >> +++ b/libavcodec/tiff.h > >> @@ -30,9 +30,6 @@ > >> #ifndef AVCODEC_TIFF_H > >> #define AVCODEC_TIFF_H > >> > >> -#include > > > >> -#include "tiff_common.h" > > > > why? there are cases where only tiff.h must be used? > > > > Must? Like in most header matters, this is not a question of "must". > tiff.h provides (mostly) TIFF related defines that are independent of > any particular implementation, whereas tiff_common.h mostly provides > auxiliary functions for decoder/parser (the encoder only uses > type_sizes*). And not even all of these need it: faxcompr only needs > tiff.h, not tiff_common.h and mjpegdec.c needs only tiff_common.h. Makes sense, patch LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".