From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/6] avcodec/tiff: Improve inclusions
Date: Mon, 11 Mar 2024 16:39:46 +0100
Message-ID: <Ze8lwosFnrXXI+VW@mariano> (raw)
In-Reply-To: <AS8P250MB0744E7E937B609275798449F8F252@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On date Sunday 2024-03-10 17:06:18 +0100, Andreas Rheinhardt wrote:
> Stefano Sabatini:
> >> diff --git a/libavcodec/tiff.h b/libavcodec/tiff.h
> >> index e67c59abad..2dd21dea52 100644
> >> --- a/libavcodec/tiff.h
> >> +++ b/libavcodec/tiff.h
> >> @@ -30,9 +30,6 @@
> >> #ifndef AVCODEC_TIFF_H
> >> #define AVCODEC_TIFF_H
> >>
> >> -#include <stdint.h>
> >
> >> -#include "tiff_common.h"
> >
> > why? there are cases where only tiff.h must be used?
> >
>
> Must? Like in most header matters, this is not a question of "must".
> tiff.h provides (mostly) TIFF related defines that are independent of
> any particular implementation, whereas tiff_common.h mostly provides
> auxiliary functions for decoder/parser (the encoder only uses
> type_sizes*). And not even all of these need it: faxcompr only needs
> tiff.h, not tiff_common.h and mjpegdec.c needs only tiff_common.h.
Makes sense, patch LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-11 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 14:12 [FFmpeg-devel] [PATCH 1/6] avcodec/tiff: Fix handling of av_strdup() failures Andreas Rheinhardt
2024-03-10 14:15 ` [FFmpeg-devel] [PATCH 2/6] avcodec/tiff: Avoid duplicating strings Andreas Rheinhardt
2024-03-10 15:34 ` Stefano Sabatini
2024-03-10 14:15 ` [FFmpeg-devel] [PATCH 3/6] avcodec/tiff: Don't check before av_freep() Andreas Rheinhardt
2024-03-10 15:38 ` Stefano Sabatini
2024-03-10 14:15 ` [FFmpeg-devel] [PATCH 4/6] avcodec/tiff: Improve inclusions Andreas Rheinhardt
2024-03-10 15:44 ` Stefano Sabatini
2024-03-10 16:06 ` Andreas Rheinhardt
2024-03-11 15:39 ` Stefano Sabatini [this message]
2024-03-10 14:15 ` [FFmpeg-devel] [PATCH 5/6] avcodec/tiff_data: Avoid relocations for TiffGeoTagNameType Andreas Rheinhardt
2024-03-14 10:46 ` Andreas Rheinhardt
2024-03-10 14:15 ` [FFmpeg-devel] [PATCH 6/6] avcodec/tiff_data: Remove incorrect GeoTIFF entries Andreas Rheinhardt
2024-03-10 15:25 ` [FFmpeg-devel] [PATCH 1/6] avcodec/tiff: Fix handling of av_strdup() failures Stefano Sabatini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ze8lwosFnrXXI+VW@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git