Re: [FFmpeg-devel] [PATCH 2/6] avcodec/tiff: Avoid duplicating strings

From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH 2/6] avcodec/tiff: Avoid duplicating strings
Date: Sun, 10 Mar 2024 16:34:14 +0100
Message-ID: <Ze3S9uE0rjcOkbC5@mariano> (raw)
In-Reply-To: <AS8P250MB07443C42651DB49BC08708068F252@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

On date Sunday 2024-03-10 15:15:00 +0100, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/tiff.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
> index 4c7460cf41..afa1289e27 100644
> --- a/libavcodec/tiff.c
> +++ b/libavcodec/tiff.c
> @@ -2028,7 +2028,8 @@ again:
>              av_log(avctx, AV_LOG_WARNING, "Type of GeoTIFF key %d is wrong\n", s->geotags[i].key);
>              continue;
>          }
> -        ret = av_dict_set(&p->metadata, keyname, s->geotags[i].val, 0);
> +        ret = av_dict_set(&p->metadata, keyname, s->geotags[i].val, AV_DICT_DONT_STRDUP_VAL);
> +        s->geotags[i].val = NULL;
>          if (ret<0) {
>              av_log(avctx, AV_LOG_ERROR, "Writing metadata with key '%s' failed\n", keyname);
>              return ret;

Should be OK, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".