From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3EE2648BDA for ; Sun, 10 Mar 2024 14:00:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 33ED668C1CC; Sun, 10 Mar 2024 16:00:15 +0200 (EET) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 136CB680088 for ; Sun, 10 Mar 2024 16:00:08 +0200 (EET) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a45f257b81fso239934566b.0 for ; Sun, 10 Mar 2024 07:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710079206; x=1710684006; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=XwNu4BXPoMvkZVRjPT5+xYuHlEqrgngv9nAevWdA8WY=; b=clDBwaU00hBmAZ8FghvXWObj6jGBkz12h7Sic1p1Hh++oUC+IkVrgZf0U04PkCma+M +hgQ0eK9pAdwoTL1Ef0ndym0AximQWOJ1cQbR4TWhuSutfMXxxGzzBaWP8XtMNk0LiJg DcQa8j8U6oWNsztLOSjJq3J9aW/PhvjTGsE8YvaTmSM1PqNjE+TarradGUwHhfWaBto0 tDPEaKI1jmly9E2rjFXqe952goEN9kwG4/M61FsdwIKxbI5u4IHjaiCO/tec7VUhRsbG a9WBkVOhMXPUQ4N1+O61acVuyXSlbvvjrJsKH3Y7Az7A7hOtN6sA/CuPrTa5m+Yyctb/ XG8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710079206; x=1710684006; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XwNu4BXPoMvkZVRjPT5+xYuHlEqrgngv9nAevWdA8WY=; b=R+1PiINvSVlFqByYC9vE1boC0tfE8jt88wXI59brgWORFWwEmIbUkPYMKUlJCaqoYm xaL49hSDpYVHmspGH/gWxypegjyytHP87/qlYeHWjcS+3Xn9CMuUd9w0z/myQv02/P73 00fx+6F48NOf5JjzQN0E2DrVUQ8X6y1SSWWVm8jDXGGjD1kzFEtd1nuZyXF/X71vIzfx wh6rnzBex4lwB2u6Gji/GA7QBuy2isP/jXLc/Z8jCP/yOOtGbqICxKjAX6ssqrihCLFz VB0Qm1U/NQgWIYMNn18PsjCy/JjKac39fn7a0d+VRsRqwp+SBXEYTU/YUDK4YTLfY2Xi x00Q== X-Gm-Message-State: AOJu0YwezWDYV0AL+OptXd8e6lA0DLXbNIXM6RsyvehNBPhU6wFRQtET jpwUbGTPnfsIhtLJySiibrreERn9He3vtuI72y29lXq9sFJWBbcqbIrDtD11 X-Google-Smtp-Source: AGHT+IEmLyk7gOpk36vOa1r34Nme5HYKf94ZeJyDpHG9GYqbjWRNbXkHWjNaB9DmAlgmnzQmTQFUrQ== X-Received: by 2002:a17:906:6a11:b0:a46:1538:9279 with SMTP id qw17-20020a1709066a1100b00a4615389279mr1621909ejc.16.1710079206295; Sun, 10 Mar 2024 07:00:06 -0700 (PDT) Received: from mariano ([188.210.239.79]) by smtp.gmail.com with ESMTPSA id e27-20020a170906315b00b00a46220c3c39sm432044eje.39.2024.03.10.07.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 07:00:05 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 6410BBFCDC; Sun, 10 Mar 2024 15:00:03 +0100 (CET) Date: Sun, 10 Mar 2024 15:00:03 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , asivery References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: asivery Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Saturday 2024-03-09 17:20:49 +0000, ffmpeg-devel Mailing List wrote: > Thank you both for the suggestions. I've updated the code as requested, and I apologize for the AV_LOG_WARNING instead of AV_LOG_ERROR - it was an oversight on my part. > I have also added the stream codec check, and it did get triggered when I tried to feed it audio that was not ATRAC1, so it seems it is required. > Regarding titles being truncated - that was my intention. However I've now added a warning if it was going to happen. > As for the block count in the header - none of the modern software which uses AEA reads that field, but for the older software, it will now be truncated to UINT32_MAX if needed. > Is there anything else that needs changes? > > From ee1d4c93c66e729d9d0456b2e8e789f3f98389e3 Mon Sep 17 00:00:00 2001 > From: asivery > Date: Fri, 8 Mar 2024 14:45:02 +0100 > Subject: [PATCH] avformat/aea: Add aea muxer > > Signed-off-by: asivery > --- > doc/muxers.texi | 10 +++ > libavformat/Makefile | 3 +- > libavformat/{aea.c => aeadec.c} | 0 > libavformat/aeaenc.c | 115 ++++++++++++++++++++++++++++++++ > libavformat/allformats.c | 1 + > 5 files changed, 128 insertions(+), 1 deletion(-) > rename libavformat/{aea.c => aeadec.c} (100%) > create mode 100644 libavformat/aeaenc.c > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index 2104cc4a95..a4df8f736d 100644 > --- a/doc/muxers.texi > +++ b/doc/muxers.texi > @@ -663,6 +663,16 @@ when enabled, write a CRC checksum for each packet to the output, > default is @code{false} > @end table > > +@anchor{aea} > +@section aea nit: sort order (should go after adts) > +MD STUDIO audio muxer. out of my own curiosity, what is MD STUDIO? [...] You might also add an entry to the Changelog. Looks good to me otherwise, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".