[FFmpeg-devel] [PATCH] avfilter/ff_filter_frame_framed: Fix setting up filter frame

[FFmpeg-devel] [PATCH] avfilter/ff_filter_frame_framed: Fix setting up filter frame

[Hanna Ciebiera]

Up to now filter_frame was incorrectly set up to dst->filter_frame in if statement. It was causing conversion failure during the transcoding.
Now, when condition in if statement is met filter_frame is set up to default_filter_frame.

Signed-off-by: Hanna Ciebiera <hanna.ciebiera@intel.com>
---
 libavfilter/avfilter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index ab7782862a..5da17f3160 100644
--- a/libavfilter/avfilter.c
+++ b/libavfilter/avfilter.c
@@ -951,7 +951,7 @@ static int ff_filter_frame_framed(AVFilterLink *link, AVFrame *frame)
     AVFilterPad *dst = link->dstpad;
     int ret;
 
-    if (!(filter_frame = dst->filter_frame))
+    if (!(filter_frame == dst->filter_frame))
         filter_frame = default_filter_frame;
 
     if (dst->flags & AVFILTERPAD_FLAG_NEEDS_WRITABLE) {
-- 
2.43.0

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/ff_filter_frame_framed: Fix setting up filter frame

[Nicolas George]

Hanna Ciebiera (12024-02-26):
> Up to now filter_frame was incorrectly set up to dst->filter_frame in
> if statement. It was causing conversion failure during the
> transcoding.
> Now, when condition in if statement is met filter_frame is set up to
> default_filter_frame.
> 
> Signed-off-by: Hanna Ciebiera <hanna.ciebiera@intel.com>

Hi. This is completely wrong. And I am pretty sure with this patch the
compiler produces a new warning that tell that it is wrong.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".