From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B5A3349552 for ; Mon, 12 Feb 2024 22:35:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0192868D09F; Tue, 13 Feb 2024 00:35:25 +0200 (EET) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AE89B68C4E1 for ; Tue, 13 Feb 2024 00:35:17 +0200 (EET) X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from metallschleimette ([91.4.236.254]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mn2WF-1r9ymB1eGl-00k8vY for ; Mon, 12 Feb 2024 23:35:16 +0100 Date: Mon, 12 Feb 2024 23:35:15 +0100 To: FFmpeg development discussions and patches Message-ID: References: <20240129184215.16685-1-anton@khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240129184215.16685-1-anton@khirnov.net> X-Provags-ID: V03:K1:UA68Bc/ujrF5Hx2qJzKUnk780lWMG/nGb7GmpPTKR9dY67jptCf 1tgORBEFTbhMUrNCsRDqtNqwdnpyhweTqi0DcghtQmkDePVJCfylxwF6KyUv3YDX5zbcp4d vtbbSn//vGlcV9BVkI0Uu+u9nkUeOLgxFloAZIKuuIGW6P70S3xkQZ7M3+Z746vsISXt9SA ygOFIL1xYujF8s1z9RTDQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:h+fNhlDKhes=;OS0/WH/U++f7BG0Tb19yFoX9GwN 76QAoUOrTgrBLm4CVr8F7VBHGhLqYMBXOPL53+hm+20FQSDftzu0bxLz1TfSMHqica+B95CLz BBHcEufcTSPmwK1cfzinJcnE4NblMZT77jcDLNqh38oIv5VKwR0XzYigTtc8m+SIH9gN7eNku c/2amD31befK0oiM8+BKIbMrgy5FG+icCg6pNvaGH1z3ix2yxrpwTndhYB9kZRHWEe47Mmeq0 3YDW+SW7zWeDnfdelBbpg3OAfjZVHo7qBrgNKzHJyAh1nW0O0SkfHj0rWQHI0OKKjTKvuykA+ 0yFHhvDugM5K7bPhUCK7yDceFnZhGcLc/FJL0KKhpH7bHhU5+sKbd2vQwTbniqY29CAL1W7ql lMBttwYBkb/NFKcH1ek1SFQKC/6IOH3d6UDBns9zT8hn5rQtxXdK6YwedSIUyuOKnfT/04Rd/ J2QDc8ITrhU39AsOyNZyEuGhVwb3m32znz/3fKWwVCn2muUbvyEDACtBTmoQzKGgIWeyEmZLr aSe2n75JFFzgIkLiHR1iYBgGxqqktiq3FkbJJ81P4JHxnlndVN80r8hFQf8yQYDt56J7ROita 4oI3ayvm//AaZPbMQN3tHdafm+mhBNQMQLJ7ACnLhjssdZ6i1ySuzxvs2sLZc72en7b4mpl6e QtvnVewgR2/p/JVH7DS/O5fpgBAL/YnEGju46/P091eY8hkdYG/iv4tQiLNJXrKP80JnoX1Km 78bX/Yy+EzfcB3JcoGHpaaLpRbN6nqKLFj7uUmAXveg/G1NNgcpjALJ6k6jU3KqHjiTWS3NMz swWFveubiVsLI4/0KJCHZ7J//qbYj9rqai6bb/sk2Oiuc= Subject: Re: [FFmpeg-devel] [PATCH] lavc/bsf: add a showinfo filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Strasser via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Alexander Strasser Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2024-01-29 19:42 +0100, Anton Khirnov wrote: [...] > --- a/doc/bitstream_filters.texi > +++ b/doc/bitstream_filters.texi > @@ -887,6 +887,10 @@ For example, to set PTS equal to DTS (not recommended if B-frames are involved): > ffmpeg -i INPUT -c:a copy -bsf:a setts=pts=DTS out.mkv > @end example > > +@section showinfo > +Log basic packet information. Mainly useful for testing, debugging, > +and development. > + Maybe it's a good idea to state something about the stability of the output format. I assume it's to be treated like other logging and is not expected to stay stable. Not sure how much it helps to state it clearly, but it can't hurt IMHO. [...] > --- /dev/null > +++ b/libavcodec/bsf/showinfo.c [...] > +static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt) > +{ > + ShowinfoContext *priv = ctx->priv_data; > + > + while (1) { > + int ret; > + > + ret = ff_bsf_get_packet_ref(ctx, pkt); > + if (ret < 0) > + return ret; > + > + av_log(ctx, AV_LOG_INFO, > + "n:%7"PRIu64" " > + "size:%7d " > + "pts:%s pt:%s " > + "dts:%s dt:%s " > + "ds:%"PRId64" d:%s " > + "\n", > + priv->nb_packets, pkt->size, > + av_ts2str(pkt->pts), av_ts2timestr(pkt->pts, &ctx->time_base_in), > + av_ts2str(pkt->dts), av_ts2timestr(pkt->dts, &ctx->time_base_in), > + pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in)); > + > + priv->nb_packets++; > + > + return 0; > + } > +} It's late here and I surely must be missing something. Anyway, why do we use a while loop here? Best regards, Alexander [...] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".