From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marth64 <marth64@proxyid.net>
Subject: Re: [FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread
Date: Mon, 12 Feb 2024 16:47:24 +0100
Message-ID: <Zco9jIIZ0iH5EJHW@mariano> (raw)
In-Reply-To: <20240211180917.1675603-1-marth64@proxyid.net>
On date Sunday 2024-02-11 12:09:16 -0600, Marth64 wrote:
> No critical changes since v12.
> - Removes unused context variable
> - Removes unnecessary if statement
> - Whitespace cleanup
> - Rebase with master
>
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
> Changelog | 2 +
> configure | 8 +
> doc/demuxers.texi | 130 ++++
> libavformat/Makefile | 1 +
> libavformat/allformats.c | 1 +
> libavformat/dvdvideodec.c | 1418 +++++++++++++++++++++++++++++++++++++
> 6 files changed, 1560 insertions(+)
> create mode 100644 libavformat/dvdvideodec.c
>
> diff --git a/Changelog b/Changelog
> index c5fb21d198..88653bc6d3 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -24,6 +24,8 @@ version <next>:
> - ffmpeg CLI options may now be used as -/opt <path>, which is equivalent
> to -opt <contents of file <path>>
> - showinfo bitstream filter
> +- DVD-Video demuxer, powered by libdvdnav and libdvdread
> +
No more comments from me, I think this is already good enough and can
go in. Further tweaks/cleanups/fixes can be applied on top.
Thanks Marth64 for the cool contribution!!
PS I won't be available in the next week or so, so I won't be able to
push this, or I'll push when I'll be back if this was not done already
and there are no further comments.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-12 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 18:09 Marth64
2024-02-11 18:09 ` [FFmpeg-devel] [PATCH v13 2/2] libavformat/dvdvideo: add CLUT utilities and enable subtitle palette support Marth64
2024-02-12 15:47 ` Stefano Sabatini [this message]
2024-02-12 15:59 ` [FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread Marth64
2024-02-16 11:38 ` Anton Khirnov
2024-02-16 15:52 ` Marth64
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zco9jIIZ0iH5EJHW@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=marth64@proxyid.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git