From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E97F64849B for ; Mon, 5 Feb 2024 00:02:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8F47A68CFE4; Mon, 5 Feb 2024 02:02:30 +0200 (EET) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 92ECA68B184 for ; Mon, 5 Feb 2024 02:02:23 +0200 (EET) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a37721e42feso110528166b.2 for ; Sun, 04 Feb 2024 16:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707091342; x=1707696142; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=M8sajopEHXZVT8qKHLGaNqez8hma0sbFBwbY7qsiG4Y=; b=cKEtQZVfK9JzUurRSM4BMsXKrptsi+cAvHqIBAQtZZLKcQlDiakNSOJ3zRrlzmAOjB WF5KP+mmd+FvykRDAM977QiOH39MHo76F69RJA4O8Q72Bzkb0DOu7C0d7jwHBUnuvoqF 0u6SAUEoXhGif9DqAcXAZlbEL1glGaTXk3prXgujRt9yiWObwdLM5Vxe0yUK6yZSh8cb iAGyUvk0lEyE9BUXnFOlSdFF8xiZIt2r4Ymp7QjOXrHc/rM3X475GYL74Pzs+roqxaUG YHXEyHjqMBqYg9JT3AitoH/LGYhQ6BuUnkEuDyWGlabbZ5hPNbtSpZBnYnrWrLNpfBYl Kwbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707091342; x=1707696142; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=M8sajopEHXZVT8qKHLGaNqez8hma0sbFBwbY7qsiG4Y=; b=gDd6re0/p4qrDiM7NGRwyE1H6akQNqZJdyuV/WObaBms63R/5x3GiXo7DQ4C8KwLzQ tRyrXUacpWrxkE8ZZSFyvQvuo2BgnUvWWgI78EC8NI07IzM2ivfbO+8uk4j7hfgNlFH1 2Og4O8aGaZfZwmeGdicCoJ1GwKEx4MFofO+D8G3H05lwoMzTYWCSHsSqwx4taDJ+JV3b bQPVkFNOQC7aRGyTpBCkzk0Ki7y35ypHuZ6b4jgu5Os3yYWQ5uKZb0fTDcu9ZfjUoyJW 8KmCWFGoJkLkC3eFmh8Gu1B0EstMz14M/fEC5WEg04GCGr4w31kM9EkrlPZbjKB4Ng7w tnow== X-Gm-Message-State: AOJu0Yzzo3WMU7jJ9o2TNtmm3ItdzWPWm2lvEwI40wc14ojDT9twcW7D XxUqlN0xp8R1791RRIBUebiEDqPiEu6wQlMdu6uX9nfOIU34Hay0JxbpjW1Q X-Google-Smtp-Source: AGHT+IHotFSr3ySM2+eusL0YTQNhX+MI3mLdbiqhOHxEI4PKFBkAKnwUrWSvoq2wuDyFEiZ5SdeQvw== X-Received: by 2002:a17:906:300e:b0:a29:4267:ac9 with SMTP id 14-20020a170906300e00b00a2942670ac9mr4667844ejz.52.1707091341813; Sun, 04 Feb 2024 16:02:21 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id ig8-20020a1709072e0800b00a372132718esm3051358ejc.90.2024.02.04.16.02.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 16:02:21 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 5C5AABFCDC; Mon, 5 Feb 2024 01:02:20 +0100 (CET) Date: Mon, 5 Feb 2024 01:02:20 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240204090233.1157950-1-jdek@itanimul.li> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240204090233.1157950-1-jdek@itanimul.li> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-02-04 10:02:31 +0100, J. Dekker wrote: > With the addition of threading in ffmpeg.c, the SDL2 devices no longer have the > 'main' thread. This means that both the SDL2 and OpenGL output device are broken > in master. Rather than attempting to fix it, they should be removed instead as > there are better alternatives for debugging or viewing streams. > > The 'pipe:' output can be used with a real video player such as mpv, vlc, or > even ffplay. For cases where the user was an application using the API they > should supply their own renderer. > > J. Dekker (2): > avdevice: remove sdl2 outdev > avdevice: remove OpenGL device I am against this. 1. If at all, the devices should be deprecated and removed only after a given timeframe, so users can switch to something else (you don't know what they are using). 2. > With the addition of threading in ffmpeg.c, the SDL2 devices no longer have the > 'main' thread. This implies a misunderstanding of what these components are. If they are broken with ffmpeg.c this is not a good reason to remove them (ffmpeg.c is not the only user). Also, it was already suggested some way to fix it, it's not like they are "broken by design", it is just that the assumptions done previuosly apply no more. Probably ffmpeg.c should not use the main thread or make this selectable. If this cannot be supported in a given OS, the feature should be disabled only for that OS. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".