From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D104B48DF9 for ; Sun, 28 Jan 2024 22:28:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1CB6868D1A8; Mon, 29 Jan 2024 00:28:20 +0200 (EET) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 465CE68D116 for ; Mon, 29 Jan 2024 00:28:14 +0200 (EET) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a35c1793d02so19691266b.3 for ; Sun, 28 Jan 2024 14:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706480893; x=1707085693; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=6sS3muK3hrGwAJqe6XW5UvOrhP1hGO6HsvGateVyBkE=; b=g24tBQsz58tCTxHGDrXRbwwg4i865zsqWhy9A1I62M9ScXehK/d3IyPnvrKajr0YuK 80va6QBMaFVPgWDMSe4udUlS9UaxyPQol6KwctxLRw1MOpP944EdCIQjJwpKEOm8ksmM JMKJcaCboQHkymK/uN07WGs/AQQM/t8LZxUQYLMib/1lY5hb3y1LijuCvm8LI0U5hslA dXRNSrkcF6rpHxg9ylH2+KSnmy/ZnICLZYH023QIxGRKgLKTCJ1QTgQbVHhc275B4FaW fy8ARRGl6IYyF/nstCh/5+khNiEbPOYf+9ITKI89LCd+DkoLpAb1TUL3+3j5lWfzO6HV 4e8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706480893; x=1707085693; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6sS3muK3hrGwAJqe6XW5UvOrhP1hGO6HsvGateVyBkE=; b=DdhHifXKx964rHv82RGICtL+CWl97bK8VNA6nAWSHWUMAsqsnEVoFbgPOu1u7TXYUl 7aD3Cq5kZzSGRhiBtHv+n7EaCXcBwDGVff//0EZ5Al+RYxpv6LUBmds7SeVJNHA1I8kE ilsMULi3rqHPQGmIGxzWgfYj/BKQbqIa+zReD+MuK/vvpOtWq3VsIy3VUpChgBXvcuC7 tRdWaTlA5xYkDuo6MLlC92CSOC0iiNZCGdm92OC17a6rUdCVAXhBGNHNC66phpDwn/CU EfvPRCTh1Jsl9GimD1Jv/0gd+Qsiz1X6yMPQqo+t1f08goSxuecR6bf6fODDrWCeB3fe VjBg== X-Gm-Message-State: AOJu0Yyqf3aZJvh7N65qaehJyeWKN6ls/PlqyO9cwiA5uSzRYF8GINXV HWj1Tf36NYTJmAbq4S4U8+u52Ke3D2uy2n+ntP0siGJtYEuLdaTY/vj8gaKL X-Google-Smtp-Source: AGHT+IF3blfRXJXVYONyhthVNB03Aqgj4HHXxHM4hZvPMRqvJSKhFcrM2pj1xu4MGJkKMYJS/kJqWg== X-Received: by 2002:a17:906:dfd1:b0:a35:9ad5:fcae with SMTP id jt17-20020a170906dfd100b00a359ad5fcaemr1421234ejc.12.1706480892686; Sun, 28 Jan 2024 14:28:12 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id sn24-20020a170906629800b00a3040040011sm3224069ejc.45.2024.01.28.14.28.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 14:28:12 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 75D49BFB9D; Sun, 28 Jan 2024 23:28:11 +0100 (CET) Date: Sun, 28 Jan 2024 23:28:11 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240115235802.525608-1-stefasab@gmail.com> <170608247298.8914.6612893899316918963@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <170608247298.8914.6612893899316918963@lain.khirnov.net> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Wednesday 2024-01-24 08:47:52 +0100, Anton Khirnov wrote: > Quoting Stefano Sabatini (2024-01-16 00:58:02) > > --- > > fftools/opt_common.c | 28 +++++++++++++++++++++------- > > 1 file changed, 21 insertions(+), 7 deletions(-) > > > > diff --git a/fftools/opt_common.c b/fftools/opt_common.c > > index f5b73c9f2f..e263a5297e 100644 > > --- a/fftools/opt_common.c > > +++ b/fftools/opt_common.c > > @@ -853,14 +853,23 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg, > > const char *last_name; > > int is_dev; > > > > - printf("%s\n" > > - " D. = Demuxing supported\n" > > - " .E = Muxing supported\n" > > - " --\n", device_only ? "Devices:" : "File formats:"); > > + if (device_only) { > > + printf("Devices:\n" > > + " D. = Demuxing supported\n" > > + " .E = Muxing supported\n" > > + " --\n"); > > + } else { > > + printf("Formats:\n" > > + " D.. = Demuxing supported\n" > > + " .E. = Muxing supported\n" > > + " ..d = Is a device\n" > > + " ---\n"); > > I don't like this duplication. will apply with the code re-factored _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".