From: Stefano Sabatini <stefasab@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 7/8] fftools/ffmpeg_demux: implement -bsf for input Date: Sat, 20 Jan 2024 12:32:42 +0100 Message-ID: <ZauvWnPOI+fA9aIn@mariano> (raw) In-Reply-To: <170548215151.8914.14196080795223407302@lain.khirnov.net> On date Wednesday 2024-01-17 10:02:31 +0100, Anton Khirnov wrote: > Quoting Stefano Sabatini (2024-01-06 13:12:19) > > > > This looks spurious, since this suggests the example is about the > > listing, and it's applying a weird order of example/explanation > > (rather than the opposite). Use the @code{-bsfs} option to get the list of bitstream filters. E.g. @example ... The problem here is that "E.g." is placed close to a statement about the listing, therefore it might sound like the example is about the listing (which is not). > I see nothing weird about this order, it's the standard way it is done > in most literature I encounter. I find the reverse order you're > suggesting far more weird and unnatural. When you present an example you usually start with an explanation (what it does) and then present the command, not the other way around. Also the following: -------------------------------------- ffmpeg -bsf:v h264_mp4toannexb -i h264.mp4 -c:v copy -an out.h264 @end example applies the @code{h264_mp4toannexb} bitstream filter (which converts MP4-encapsulated H.264 stream to Annex B) to the @emph{input} video stream. On the other hand, @example ffmpeg -i file.mov -an -vn -bsf:s mov2textsub -c:s copy -f rawvideo sub.txt @end example applies the @code{mov2textsub} bitstream filter (which extracts text from MOV subtitles) to the @emph{output} subtitle stream. Note, however, that since both examples use @code{-c copy}, it matters little whether the filters are applied on input or output - that would change if transcoding was hapenning. --------------------------------------- this makes the reader need to correlate the two examples to figure them out, that's why I reworked the presentation in my suggestion as a more linear sequence of presentation/command/presentation/command. In general examples should focus on how a task can be done, not on the explanation of the command itself. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-20 11:32 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-05 16:42 [FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg_demux: replace abort() by av_assert0(0) Anton Khirnov 2024-01-05 16:42 ` [FFmpeg-devel] [PATCH 2/8] doc/ffmpeg: drop documentation for non-existent -sbsf Anton Khirnov 2024-01-06 11:22 ` Stefano Sabatini 2024-01-05 16:42 ` [FFmpeg-devel] [PATCH 3/8] fftools/ffmpeg_demux: do not set bitexact directly on the decoder Anton Khirnov 2024-01-06 11:24 ` Stefano Sabatini 2024-01-05 16:42 ` [FFmpeg-devel] [PATCH 4/8] fftools/ffmpeg_demux: set options on codec parameters rather than decoder Anton Khirnov 2024-01-06 11:31 ` Stefano Sabatini 2024-01-06 14:22 ` James Almer 2024-01-16 19:49 ` Anton Khirnov 2024-01-16 22:37 ` James Almer 2024-01-05 16:42 ` [FFmpeg-devel] [PATCH 5/8] fftools/ffmpeg_demux: only allocate the decoder when actually decoding Anton Khirnov 2024-01-06 11:34 ` Stefano Sabatini 2024-01-16 19:50 ` Anton Khirnov 2024-01-05 16:42 ` [FFmpeg-devel] [PATCH 6/8] fftools/ffmpeg_demux: add demuxing thread private data Anton Khirnov 2024-01-06 11:44 ` Stefano Sabatini 2024-01-16 19:52 ` Anton Khirnov 2024-01-05 16:42 ` [FFmpeg-devel] [PATCH 7/8] fftools/ffmpeg_demux: implement -bsf for input Anton Khirnov 2024-01-06 12:12 ` Stefano Sabatini 2024-01-17 9:02 ` Anton Khirnov 2024-01-20 11:32 ` Stefano Sabatini [this message] 2024-01-21 17:43 ` Anton Khirnov 2024-01-21 18:22 ` Stefano Sabatini 2024-01-21 18:35 ` Anton Khirnov 2024-01-21 19:15 ` Stefano Sabatini 2024-01-22 8:57 ` Anton Khirnov 2024-01-05 16:42 ` [FFmpeg-devel] [PATCH 8/8] fftools/ffmpeg_opt: mark -stream_group as expert option Anton Khirnov 2024-01-06 12:12 ` Stefano Sabatini 2024-01-06 11:18 ` [FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg_demux: replace abort() by av_assert0(0) Stefano Sabatini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZauvWnPOI+fA9aIn@mariano \ --to=stefasab@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git