From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 80091400AB for ; Sun, 14 Jan 2024 11:32:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D10E868CD96; Sun, 14 Jan 2024 13:32:53 +0200 (EET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CB71968C954 for ; Sun, 14 Jan 2024 13:32:47 +0200 (EET) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-33761e291c1so4459368f8f.0 for ; Sun, 14 Jan 2024 03:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705231966; x=1705836766; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=DMQWsXizPsvNog1YL3mL4uqqULl1iaBm1cWO7SgR+SE=; b=MVy7UZGku4faHGXU/t6uxObLJAvAKz2J35MXvT6R93S/jZi2T9KXGhgVVggnXZAgOj eCTbvbAf5nok23FPWmijkWjmauIDxD8e78alKAspNOLIJH74JuWGBGSnx08SxeBRLCjz lZBSwgzngYgcOOrekxBMMmSyRtX6K5wDLCFdGxV5m5S9oLImV/Jc59F/KRCM7K/FG3Kd q4bp7mhc2FT3bbd7b0+iw8a4zZ3p50QQwQxsmyX7zHodLdHgATcikejPgDpABI45F1eT lyDR26DlHgr4RVbyFXE9XCe1DC97BHHw2wu+dPAnGAdLkGwv77QF82cB4ipkuxYBJMoC 0j3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705231966; x=1705836766; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DMQWsXizPsvNog1YL3mL4uqqULl1iaBm1cWO7SgR+SE=; b=ARQ3wZt4+JUlTVLXKwmTi+G5bZy67ShECTwQMK6zLz96h2HhzICBKldK+JR2kF3/V3 OPNzgqxQ3WaCtdIZi6Ns68bklaQOCfzpON38KOhz5HYqkZakKe4aQdesETzvbewGm42Q 3T8YylfBAxo/LQ0BhYDJEYVZ70HoumZEXb+99ru8wXi3jkaSe2oY0y28n7aB0xRk5U5w SqnkWEkhG65w61qpkdRpBgvjiv7gMo1GOYK00AIXYbo3tFJiA8pY93FKQ1ph+KhQZngC WEFl+ek+R2xakTGMyu6ZUiZYvzOFR49K3JIHk075caj3cwdL4xXGQs0qqtUIqEK3ECsh mEIg== X-Gm-Message-State: AOJu0Yw67vQgO8vNJ8lDnHitXrBxdXOYi+91qSCcVHKVr+fCnP/KNyys UH06YiwgGVwMt3V8kLKIT7+3nHgdb1c= X-Google-Smtp-Source: AGHT+IE+DC4tFhhhjkqXHiB9vokZOSLQ/q1Ji/Uqo18RUNUGMxeMCGcVmgPejGlcr9sGfUdJ6LS4qw== X-Received: by 2002:a5d:5a09:0:b0:336:c21b:4583 with SMTP id bq9-20020a5d5a09000000b00336c21b4583mr3385363wrb.67.1705231965939; Sun, 14 Jan 2024 03:32:45 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id h6-20020adf9cc6000000b003375d8b0460sm8936017wre.1.2024.01.14.03.32.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jan 2024 03:32:45 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 5DBC7BFCDC; Sun, 14 Jan 2024 12:32:44 +0100 (CET) Date: Sun, 14 Jan 2024 12:32:44 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Jeffrey Knockel References: <20240108145336.380094-1-jeff@jeffreyknockel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240108145336.380094-1-jeff@jeffreyknockel.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] avutil/pixfmt: fix AV_PIX_FMT_RGB8 description X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jeffrey Knockel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2024-01-08 09:53:37 -0500, Jeffrey Knockel wrote: > Previously the description was partially mistaken, explaining the format > as RGB 3:3:2, (msb)2R 3G 3B(lsb). While the RGB 3:3:2 part is correct, > the latter part should be: (msb)3R 3G 2B(lsb). The corresponding bit > masks are red: 0xE0, green: 0x1C, blue: 0x03. > > Signed-off-by: Jeffrey Knockel > --- > libavutil/pixfmt.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h > index 58f9ad28bd..9c87571f49 100644 > --- a/libavutil/pixfmt.h > +++ b/libavutil/pixfmt.h > @@ -83,7 +83,7 @@ enum AVPixelFormat { > AV_PIX_FMT_BGR8, ///< packed RGB 3:3:2, 8bpp, (msb)2B 3G 3R(lsb) > AV_PIX_FMT_BGR4, ///< packed RGB 1:2:1 bitstream, 4bpp, (msb)1B 2G 1R(lsb), a byte contains two pixels, the first pixel in the byte is the one composed by the 4 msb bits > AV_PIX_FMT_BGR4_BYTE, ///< packed RGB 1:2:1, 8bpp, (msb)1B 2G 1R(lsb) > - AV_PIX_FMT_RGB8, ///< packed RGB 3:3:2, 8bpp, (msb)2R 3G 3B(lsb) > + AV_PIX_FMT_RGB8, ///< packed RGB 3:3:2, 8bpp, (msb)3R 3G 2B(lsb) This is not consistent with pixdesc definition: [AV_PIX_FMT_RGB8] = { .name = "rgb8", .nb_components = 3, .log2_chroma_w = 0, .log2_chroma_h = 0, .comp = { { 0, 1, 0, 6, 2 }, /* R */ { 0, 1, 0, 3, 3 }, /* G */ { 0, 1, 0, 0, 3 }, /* B */ }, .flags = AV_PIX_FMT_FLAG_RGB, }, so either the documentation or the pixdesc description is wrong. Do you confirm "(msb)3R 3G 2B(lsb)" is the correct definition? In this case pixdesc should be fixed accordingly. Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".