From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 80BEE4CF90 for <ffmpegdev@gitmailbox.com>; Tue, 15 Apr 2025 19:14:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 08830687D23; Tue, 15 Apr 2025 22:14:50 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D122A687AAE for <ffmpeg-devel@ffmpeg.org>; Tue, 15 Apr 2025 22:14:42 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 53FJEg4G015939 for <ffmpeg-devel@ffmpeg.org>; Tue, 15 Apr 2025 21:14:42 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 1E9412EFD9; Tue, 15 Apr 2025 21:14:42 +0200 (CEST) Date: Tue, 15 Apr 2025 21:14:42 +0200 From: Nicolas George <george@nsup.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <Z_6wIk52_3NeQBlv@phare.normalesup.org> References: <20250415181433.530161-1-michael@niedermayer.cc> <20250415181433.530161-5-michael@niedermayer.cc> <Z_6pR62oq4act_V1@phare.normalesup.org> <20250415190631.GS4991@pb2> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250415190631.GS4991@pb2> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Tue, 15 Apr 2025 21:14:42 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH v2 5/6] libavutil: Add AVMap X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/Z_6wIk52_3NeQBlv@phare.normalesup.org/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> Michael Niedermayer (HE12025-04-15): > Where exactly would that benefit FFmpeg ? > Dictionaries generally are used to move stuff aorund, like metadata or > options. > Or may be used in the future to keep track of some mappings like > timestamps to file positions during demuxing or muxing > Or maybe codecs/formats lookup from name > None of these are confined to a single local function AVMap opts = av_map_create(cmp, NULL, NULL); av_map_add(opts, "threads", "12"); av_map_add(opts, "crf", "18"); av_map_add(opts, "preset", "veryslow"); av_map_assert_small(opts); ret = av_codec_open3(ctx, codec, opts); > i like av_map_new() because "new" is short The exact name does not matter to me. I forgot that we usually use _alloc() for the case you implemented, so _new() is absolutely fine for this. av_map_assert_small() should assert that no dynamic allocation happened, and at assert level 2 that the internal buffer is less than halfway full. > and sizeof(AVMap) is not public API It should be public API like I did for BPrint, that is my point. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".