From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7B30F4802A for ; Mon, 8 Jan 2024 20:23:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D567868CD64; Mon, 8 Jan 2024 22:23:13 +0200 (EET) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5251E68C416 for ; Mon, 8 Jan 2024 22:23:08 +0200 (EET) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a27733ae1dfso243366666b.3 for ; Mon, 08 Jan 2024 12:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704745387; x=1705350187; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OMvKDXey0JvAZ9O+66MhZTyzk2OTrGWBCFLIRh/COys=; b=AB3we4QCch+1M5W+l6ryN2KYYZqR2aTBAjW3fF2A4QRVmzvN/4948ncXUS/UIm7t6c s93p/WhdzheYu9OHdBaYCG5wXnq+ou0rGxeeMNwz4Hz1ilasPlCqz5RxOOdRYlNicrFl 32HOZrNj3Z9ts7ET0zgeJdpHsTcMDWiM2WPWwX4uLCIqZYVAxni9GW2Ma6+BFc3MR1hb FONqpVPZzNfGecSZAfRDBB2wGPiSQb/IzpNqgkgzch35lWxoJgQjd7J9LJ89RH9xLctx 0NgwAOja2D5exOYvBm65ClbPC+yna6ZE5qdkIbb09B4Hias8cxbZHmdO8745622ggkLG 7Q7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704745387; x=1705350187; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OMvKDXey0JvAZ9O+66MhZTyzk2OTrGWBCFLIRh/COys=; b=vgOW8ioI1Jtor25syBnfapKKsTqqdch5YVLfvtWba08Y+T9IZUtFY9wBI/yk9ArBrS R51u17R42wEdcRkf3EBgQ683fvEt5s/N4nRdK/tPnK4Ruv0BQI5C+wxX/0VEvvuHLomb GiftIPc9evcWMes+mxgZyAImSiM4JfA4F/hSA+JpmZBFpqbpxmvg+Bv1djwwoVz/u/2F vsqQnoGfObq6nvxCgl7DoUeVua7W8EdXD5+NofUCtPTKB6g3EUAJfZGuVOHUXeaaa08N EyQ9VjoCOfGmwTaCXoeMa8wrIWQvOVRluq9xjzlmHc+2RMz+YrIIsrxK9yV7diINTKS+ nAKQ== X-Gm-Message-State: AOJu0YyDz+9ytoUXhiQZwzLorK7HOvkqhBTgbjFdu7IVuCTvGAnQcH2u lR0W1lBGPNE/YIrNEuav9KUTS36Q06c= X-Google-Smtp-Source: AGHT+IGhK+4AgbeI8/W4gqKvvZnczQbI9PsjN2wT/xcWBrt6X9/EAQ2Vzy6QgfFoRbvtl/G2Z4Ac6Q== X-Received: by 2002:a17:906:17d8:b0:a28:b34d:8693 with SMTP id u24-20020a17090617d800b00a28b34d8693mr865007eje.186.1704745387082; Mon, 08 Jan 2024 12:23:07 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id u21-20020a170906069500b00a2a67731f31sm221300ejb.109.2024.01.08.12.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 12:23:06 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id A0517BFCDC; Mon, 8 Jan 2024 21:23:05 +0100 (CET) Date: Mon, 8 Jan 2024 21:23:05 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211190908.1882569-1-u@pkh.me> <20240107181647.3049578-1-u@pkh.me> <20240107181647.3049578-4-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240107181647.3049578-4-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 4/5] avcodec/proresenc_anatoliy: do not write into alpha reserved bitfields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-01-07 19:16:46 +0100, Cl=E9ment B=BDsch wrote: > This byte represents 4 reserved bits followed by 4 alpha_channel_type bit= s. > = > alpha_channel_type currently has 3 differents defined values: 0 (no > alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are > reserved. The 4 initial reserved bits are expected to be 0. > --- > libavcodec/proresenc_anatoliy.c | 10 +--------- > tests/ref/vsynth/vsynth1-prores | 2 +- > tests/ref/vsynth/vsynth1-prores_444 | 2 +- > tests/ref/vsynth/vsynth1-prores_444_int | 2 +- > tests/ref/vsynth/vsynth1-prores_int | 2 +- > tests/ref/vsynth/vsynth2-prores | 2 +- > tests/ref/vsynth/vsynth2-prores_444 | 2 +- > tests/ref/vsynth/vsynth2-prores_444_int | 2 +- > tests/ref/vsynth/vsynth2-prores_int | 2 +- > tests/ref/vsynth/vsynth3-prores | 2 +- > tests/ref/vsynth/vsynth3-prores_444 | 2 +- > tests/ref/vsynth/vsynth3-prores_444_int | 2 +- > tests/ref/vsynth/vsynth3-prores_int | 2 +- > tests/ref/vsynth/vsynth_lena-prores | 2 +- > tests/ref/vsynth/vsynth_lena-prores_444 | 2 +- > tests/ref/vsynth/vsynth_lena-prores_444_int | 2 +- > tests/ref/vsynth/vsynth_lena-prores_int | 2 +- > 17 files changed, 17 insertions(+), 25 deletions(-) > = > diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anato= liy.c > index 2223721aa0..1112cb26f1 100644 > --- a/libavcodec/proresenc_anatoliy.c > +++ b/libavcodec/proresenc_anatoliy.c > @@ -794,15 +794,7 @@ static int prores_encode_frame(AVCodecContext *avctx= , AVPacket *pkt, > pict->color_trc, valid_trc, 0); > *buf++ =3D int_from_list_or_default(avctx, "frame colorspace", > pict->colorspace, valid_colorspace= , 0); > - if (avctx->profile >=3D AV_PROFILE_PRORES_4444) { > - if (avctx->pix_fmt =3D=3D AV_PIX_FMT_YUV444P10) { > - *buf++ =3D 0xA0;/* src b64a and no alpha */ > - } else { > - *buf++ =3D 0xA2;/* src b64a and 16b alpha */ > - } > - } else { > - *buf++ =3D 32;/* src v210 and no alpha */ > - } > + *buf++ =3D ctx->need_alpha ? 0x2 /* 16-bit alpha */ : 0; Is 8-bit alpha mode supported? (it doesn't seem from a quic look). Should be good if not, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".