From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 58EB647482 for ; Mon, 8 Jan 2024 20:10:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 95C5C68CD45; Mon, 8 Jan 2024 22:10:18 +0200 (EET) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5E44968BFFF for ; Mon, 8 Jan 2024 22:10:12 +0200 (EET) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-50e835800adso2051495e87.0 for ; Mon, 08 Jan 2024 12:10:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704744611; x=1705349411; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=133SWsQKu3mDGU73Im3FjjQTuomXbOzrVMWMyfQfpVs=; b=RvRQXjp7FFYI8YA54HZ4g/TgUwQ4ZpFmemz+G/fyQUHayFkNxDvCDDE6KRexIIERyF EbRk7aFYbCr5jl1l+VDRwFbw1oehGOi1ypDl5Xjy/+VTTaK43cxHjfRY4zmpQlMwyd/T yH7mT/NpmLK8OsDKSYVf1mN4LofQIpUVvLQmUG9nbVhJlsZE4J0yKlZXWDMMTX4xTDZa UQQgcI+m/NWiK69oQBIvcpscYY3kGZPmTDCCc8QPIFkHAeDvOT70AZySIvaTb0I6Yqtb af5HdxXsdQkVGhh18AGPljrfdeg6MQG4SEoWpMe89d/t/B9XHxUtixsXLdxSaXdBtrOM 7plA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704744611; x=1705349411; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=133SWsQKu3mDGU73Im3FjjQTuomXbOzrVMWMyfQfpVs=; b=C7K4YNWBE+0CiQLU625u8inKdBpqpfXhY+9BtLJTXWsYmj4b0UaWxTLyiC2C47RYFu Dsgb3zSOy2ivpwALYUUw4gPDh/IhUZyk7Hgx3xkuR7q+CSgAOiqI6tiHj9d254Mmlho8 +OFRxwC70HwznXEHJgrEh16rE8DSt5sIAEV7pVnxOFO/iR+7Oy/drPh/IeTyh/jfpnT2 TbXGGgBQRFavbzBWJWpQwa9ObSKBaxRWtw5ScSD+3kRL9uxTt2exu2c1sO19LU/EqcfO 9RQ2CDmg5BBwZM52XgnuEoSHuBp1SUKvmiuwzw7PSTeL6F8N32RAY6H06+oUUKES3p0T Zp8Q== X-Gm-Message-State: AOJu0Yycu28+f6hmRYq8Hz+j1VUq1e9peAxKHXYnQlBu+ScsTN5HppD8 JMS8urguPwsMvIx/U3o5BaO3jKETYfA= X-Google-Smtp-Source: AGHT+IE1nNMFFyTcvWSTg3jkX92knghJxxX2mGliwSho+ml2Wj/ViXvFT/RteebJaZiWv7DtKMKmRQ== X-Received: by 2002:ac2:5f6f:0:b0:50e:67f6:18d7 with SMTP id c15-20020ac25f6f000000b0050e67f618d7mr1090234lfc.156.1704744611027; Mon, 08 Jan 2024 12:10:11 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id jx15-20020a170906ca4f00b00a290920c78csm210538ejb.187.2024.01.08.12.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 12:10:10 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id BBD2CBFCDC; Mon, 8 Jan 2024 21:10:09 +0100 (CET) Date: Mon, 8 Jan 2024 21:10:09 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211190908.1882569-1-u@pkh.me> <20240107181647.3049578-1-u@pkh.me> <20240107181647.3049578-3-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240107181647.3049578-3-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-01-07 19:16:45 +0100, Cl=E9ment B=BDsch wrote: > This byte represents 4 reserved bits followed by 4 alpha_channel_type bit= s. > = > alpha_channel_type currently has 3 differents defined values: 0 (no > alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are > reserved. This part is correctly written (alpha_bits>>3 does the correct > thing), but the 4 initial bits are reserved. > --- > libavcodec/proresenc_kostya.c | 2 +- > tests/ref/vsynth/vsynth1-prores_ks | 2 +- > tests/ref/vsynth/vsynth2-prores_ks | 2 +- > tests/ref/vsynth/vsynth3-prores_ks | 2 +- > tests/ref/vsynth/vsynth_lena-prores_ks | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > = > diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c > index de63127192..f6c71c2b86 100644 > --- a/libavcodec/proresenc_kostya.c > +++ b/libavcodec/proresenc_kostya.c > @@ -1051,7 +1051,7 @@ static int encode_frame(AVCodecContext *avctx, AVPa= cket *pkt, > bytestream_put_byte (&buf, pic->color_primaries); > bytestream_put_byte (&buf, pic->color_trc); > bytestream_put_byte (&buf, pic->colorspace); > - bytestream_put_byte (&buf, 0x40 | (ctx->alpha_bits >> 3)); > + bytestream_put_byte (&buf, ctx->alpha_bits >> 3); Shall be good, I wonder why it was done that way (probably there was no open specification at the time?). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".