From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4C9C44746A for ; Mon, 8 Jan 2024 19:57:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6AC2568CD3F; Mon, 8 Jan 2024 21:57:23 +0200 (EET) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 015E368BFFF for ; Mon, 8 Jan 2024 21:57:16 +0200 (EET) Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-557bfc7f7b4so1698770a12.0 for ; Mon, 08 Jan 2024 11:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704743835; x=1705348635; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ROIEPOC2qkmb+4yNauIZ+3yQx7wGbXTGl8CSjYKoWls=; b=jLc+FOeBKmeBA8ebaIAYyzAtLWxGxN/xYRntG7W2UEoWo2LLB39m0EBEadF+L2nQq2 lzSnwTppLEklUYXGLe7eTWA4Wyrwijz6b1OVIEQVXTUDLQq4/Af2SPPIAdZ2CRGWaV2Z cTnFQcE9KkR72pj6wrAE+CtAnsSGfI8xr1vwd/Q8XT2nMp9rSsKpCfn1EZDe/3I6J+iG HR5zdXYTTt7ug4ltF9nAGIKkuY2+y25oBb8HWga4JN0dt+rxRR6yy58SM7CZqJnPzhSC r3Tay2MVGShWpY18dWtRtGQD2NPa//MQjcX6kr7AmTxK342Rs50hqj4zCDhx6y3kh5Mq lm/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704743835; x=1705348635; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ROIEPOC2qkmb+4yNauIZ+3yQx7wGbXTGl8CSjYKoWls=; b=eckzUWMIPmAXjdytrpujqAYQSNknQOFs6dKGEiAdPtT6uA0bUnVMKokk2/rL+MhAnn S594O2Jkbj4zwlrGOP399qfPstWOx36eDyMH69LjnK5hFjoaOGz8q+tgt3VWlb0UyZLl uHsMqLxAyPx07CD9CzSy+zt0Xy5eXkqcEHpeTOUtt256VPbXHN6E8LdyFwNS8fnTTM2m FxNcJoNM7veiDr68vTkV34yhDKtePhn6gNtJs3uh7WWet2I++eOqBviFa+HTyi5dN0Mi PlpG83IpU8QmIE3r6KjnxF1Zsi8SCqSmcAFxQnU/yhqSwilZjFB1yVERuqkwUrtk7SXO eIxw== X-Gm-Message-State: AOJu0YzcOzu6GN2bNfD2b/LHnbfye2M410ZWoHw90QHJ7Ou8ZHqJuT7Q MnQUisQXtcvVsI9tJefgBTR5UK2S7yU= X-Google-Smtp-Source: AGHT+IG86XzaDoq8KXNwtAuqoN5lHNYEJg3gdPCXNcdnP7q8UT6pG1BXKnChsrBMdTJDJhmZA144Zw== X-Received: by 2002:a17:907:a1a6:b0:a2a:212:cfe5 with SMTP id om38-20020a170907a1a600b00a2a0212cfe5mr210830ejc.12.1704743835286; Mon, 08 Jan 2024 11:57:15 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id s10-20020a170906c30a00b00a28ba0c3821sm202478ejz.101.2024.01.08.11.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 11:57:14 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id BF12ABFCDC; Mon, 8 Jan 2024 20:57:13 +0100 (CET) Date: Mon, 8 Jan 2024 20:57:13 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211190908.1882569-1-u@pkh.me> <20240107181647.3049578-1-u@pkh.me> <20240107181647.3049578-2-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240107181647.3049578-2-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/proresenc_kostya: use a compatible bitstream version X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-01-07 19:16:44 +0100, Cl=E9ment B=BDsch wrote: > Quoting SMPTE RDD 36:2015: > A decoder shall abort if it encounters a bitstream with an unsupported > bitstream_version value. If 0, the value of the chroma_format syntax > element shall be 2 (4:2:2 sampling) and the value of the > alpha_channel_type element shall be 0 (no encoded alpha); if 1, any > permissible value may be used for those syntax elements. > = > So if we're not in 4:2:2 or if there is alpha, we are not allowed to use > version 0. > --- > libavcodec/proresenc_kostya.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c > index 8d45e42d1a..de63127192 100644 > --- a/libavcodec/proresenc_kostya.c > +++ b/libavcodec/proresenc_kostya.c > @@ -1037,7 +1037,7 @@ static int encode_frame(AVCodecContext *avctx, AVPa= cket *pkt, > // frame header > tmp =3D buf; > buf +=3D 2; // frame header size w= ill be stored here > - bytestream_put_be16 (&buf, 0); // version 1 > + bytestream_put_be16 (&buf, ctx->chroma_factor !=3D CFACTOR_Y422 || = ctx->alpha_bits ? 1 : 0); LGTM, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".