From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A7BDD4716F for ; Mon, 8 Jan 2024 19:54:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0C81968CD45; Mon, 8 Jan 2024 21:54:41 +0200 (EET) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D0C1768CA09 for ; Mon, 8 Jan 2024 21:54:34 +0200 (EET) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-555e07761acso2611951a12.0 for ; Mon, 08 Jan 2024 11:54:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704743673; x=1705348473; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=oBrn0qLfwBmPH90wTJ7UzGBnht0wRAhuNDplyQ6AqfI=; b=WK10wj23/lCDARiBRx5WGEHdhw51+AGJNk7v4NobXPiflbJoTCo6ygQ8eYZTtDKEE1 OkGOjHyAZrA/9fs6T5cdUBvEKzdtDJIm6tGOLROChQA1fAsDSgdsX30aV6TqIMHR6gjQ 4RYujVbgOPFK7F/cqy5qiIN2eWk2Cv550sCcU34lMJIpcSpwL3t181jBEdHUdhHnkqLV sdS+F0enqLE69VI2YpIRmUw5sMX5Cj5773VQVNug07M04nOXOnHG3wCerF9AJbFfPxCb OawqYpWE9bM2goqy6aaK/npq76GBvrXUFnQ6sSU/dFfKXOxBzXQw2lRexQhtgIlz6yWc PAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704743673; x=1705348473; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oBrn0qLfwBmPH90wTJ7UzGBnht0wRAhuNDplyQ6AqfI=; b=dNlm5OkHKC4C76m91VtCDq+9MPhK2HGXB9Hq6erXPlB2seckJELZYRAKJFdgmhITL4 v6P+fDO+ZN1ykBLJigXS4HD8atI4O9UpLvyUhgaemr0hHT+2YUj8iZyscE5uWie5PHs0 JahvqIuqfoCxD3jH4Gv38ZIq5v+L1p15YV5BW6ioXI7Jc6jer2sTQYgcpgq0JtI1z3KA R6oGEleqTL/kk4+NylBHHP4IUDKJERrgdvDVUf5HgRlAwJV99QeWY4TyGdSrFbjSf/Jr eAECG3i2WNd6jSmuseZhnazKnSI5AXI/2YvaRTBrC4AjfCgiWaVnqYOp43+JPKRbZVaQ 3DHA== X-Gm-Message-State: AOJu0YwldOqUc1dSUPvLEiIr/e58S1tPHgZK9BpFWWezFQj31dWsz/zo YMlMtwvqhsOT1v2FZUqLWoahTD5S6HY= X-Google-Smtp-Source: AGHT+IFvsee1LYB31PVBIER/r3Sn8xuB4ElA8Q2dSR0+q2eZxS26HBCIaTWpQnNpKI2fwzzLL2mxjQ== X-Received: by 2002:a50:d51a:0:b0:550:4412:e8f with SMTP id u26-20020a50d51a000000b0055044120e8fmr1434020edi.17.1704743673104; Mon, 08 Jan 2024 11:54:33 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id o19-20020aa7d3d3000000b0055537e76e94sm164413edr.57.2024.01.08.11.54.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 11:54:32 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id A1E69BFCDC; Mon, 8 Jan 2024 20:54:31 +0100 (CET) Date: Mon, 8 Jan 2024 20:54:31 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211190908.1882569-1-u@pkh.me> <20240107181647.3049578-1-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240107181647.3049578-1-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/proresenc_anatoliy: use a compatible bitstream version X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-01-07 19:16:43 +0100, Cl=E9ment B=BDsch wrote: > Quoting SMPTE RDD 36:2015: > A decoder shall abort if it encounters a bitstream with an unsupported > bitstream_version value. If 0, the value of the chroma_format syntax > element shall be 2 (4:2:2 sampling) and the value of the > alpha_channel_type element shall be 0 (no encoded alpha); if 1, any > permissible value may be used for those syntax elements. > = > So if we're not in 4:2:2 or if there is alpha, we are not allowed to use > version 0. > --- > libavcodec/proresenc_anatoliy.c | 2 +- > tests/ref/vsynth/vsynth1-prores_444 | 2 +- > tests/ref/vsynth/vsynth1-prores_444_int | 2 +- > tests/ref/vsynth/vsynth2-prores_444 | 2 +- > tests/ref/vsynth/vsynth2-prores_444_int | 2 +- > tests/ref/vsynth/vsynth3-prores_444 | 2 +- > tests/ref/vsynth/vsynth3-prores_444_int | 2 +- > tests/ref/vsynth/vsynth_lena-prores_444 | 2 +- > tests/ref/vsynth/vsynth_lena-prores_444_int | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > = > diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anato= liy.c > index 9b9ffa03be..2223721aa0 100644 > --- a/libavcodec/proresenc_anatoliy.c > +++ b/libavcodec/proresenc_anatoliy.c > @@ -765,7 +765,7 @@ static int prores_encode_frame(AVCodecContext *avctx,= AVPacket *pkt, > bytestream_put_buffer(&buf, "icpf", 4); > = > bytestream_put_be16(&buf, header_size); > - bytestream_put_be16(&buf, 0); /* version */ > + bytestream_put_be16(&buf, avctx->pix_fmt !=3D AV_PIX_FMT_YUV422P10 |= | ctx->need_alpha ? 1 : 0); /* version */ LGTM, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".