From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: "Clément Bœsch" <u@pkh.me>
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/proresenc_anatoliy: use a compatible bitstream version
Date: Mon, 8 Jan 2024 20:54:31 +0100
Message-ID: <ZZxS9zw3KNQAaJ4z@mariano> (raw)
In-Reply-To: <20240107181647.3049578-1-u@pkh.me>
On date Sunday 2024-01-07 19:16:43 +0100, Clément Bœsch wrote:
> Quoting SMPTE RDD 36:2015:
> A decoder shall abort if it encounters a bitstream with an unsupported
> bitstream_version value. If 0, the value of the chroma_format syntax
> element shall be 2 (4:2:2 sampling) and the value of the
> alpha_channel_type element shall be 0 (no encoded alpha); if 1, any
> permissible value may be used for those syntax elements.
>
> So if we're not in 4:2:2 or if there is alpha, we are not allowed to use
> version 0.
> ---
> libavcodec/proresenc_anatoliy.c | 2 +-
> tests/ref/vsynth/vsynth1-prores_444 | 2 +-
> tests/ref/vsynth/vsynth1-prores_444_int | 2 +-
> tests/ref/vsynth/vsynth2-prores_444 | 2 +-
> tests/ref/vsynth/vsynth2-prores_444_int | 2 +-
> tests/ref/vsynth/vsynth3-prores_444 | 2 +-
> tests/ref/vsynth/vsynth3-prores_444_int | 2 +-
> tests/ref/vsynth/vsynth_lena-prores_444 | 2 +-
> tests/ref/vsynth/vsynth_lena-prores_444_int | 2 +-
> 9 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c
> index 9b9ffa03be..2223721aa0 100644
> --- a/libavcodec/proresenc_anatoliy.c
> +++ b/libavcodec/proresenc_anatoliy.c
> @@ -765,7 +765,7 @@ static int prores_encode_frame(AVCodecContext *avctx, AVPacket *pkt,
> bytestream_put_buffer(&buf, "icpf", 4);
>
> bytestream_put_be16(&buf, header_size);
> - bytestream_put_be16(&buf, 0); /* version */
> + bytestream_put_be16(&buf, avctx->pix_fmt != AV_PIX_FMT_YUV422P10 || ctx->need_alpha ? 1 : 0); /* version */
LGTM, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-01-08 19:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 19:06 [FFmpeg-devel] Misc ProRes frame header conformity fixes Clément Bœsch
2023-12-11 19:06 ` [FFmpeg-devel] [PATCH 1/5] avcodec/proresenc_anatoliy: use a compatible bitstream version Clément Bœsch
2023-12-11 19:06 ` [FFmpeg-devel] [PATCH 2/5] avcodec/proresenc_kostya: " Clément Bœsch
2023-12-11 19:06 ` [FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields Clément Bœsch
2023-12-12 23:13 ` Michael Niedermayer
2023-12-12 23:16 ` Michael Niedermayer
2024-01-07 18:20 ` Clément Bœsch
2023-12-11 19:06 ` [FFmpeg-devel] [PATCH 4/5] avcodec/proresenc_anatoliy: " Clément Bœsch
2023-12-11 19:06 ` [FFmpeg-devel] [PATCH 5/5] avcodec/proresenc_anatoliy: do not write into chroma " Clément Bœsch
2024-01-07 18:16 ` [FFmpeg-devel] [PATCH 1/5] avcodec/proresenc_anatoliy: use a compatible bitstream version Clément Bœsch
2024-01-07 18:16 ` [FFmpeg-devel] [PATCH 2/5] avcodec/proresenc_kostya: " Clément Bœsch
2024-01-08 19:57 ` Stefano Sabatini
2024-01-07 18:16 ` [FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields Clément Bœsch
2024-01-08 20:10 ` Stefano Sabatini
2024-01-08 20:33 ` Clément Bœsch
2024-01-07 18:16 ` [FFmpeg-devel] [PATCH 4/5] avcodec/proresenc_anatoliy: " Clément Bœsch
2024-01-08 20:23 ` Stefano Sabatini
2024-01-08 20:34 ` Clément Bœsch
2024-01-07 18:16 ` [FFmpeg-devel] [PATCH 5/5] avcodec/proresenc_anatoliy: do not write into chroma " Clément Bœsch
2024-01-10 19:12 ` Clément Bœsch
2024-01-10 21:43 ` Stefano Sabatini
2024-01-10 22:37 ` Clément Bœsch
2024-01-08 19:54 ` Stefano Sabatini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZxS9zw3KNQAaJ4z@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=u@pkh.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git