From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DCFF948008 for ; Sun, 7 Jan 2024 12:05:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 88F8068CCCF; Sun, 7 Jan 2024 14:05:43 +0200 (EET) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 695CF68C9F6 for ; Sun, 7 Jan 2024 14:05:36 +0200 (EET) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a28a997f3dfso68108366b.0 for ; Sun, 07 Jan 2024 04:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704629135; x=1705233935; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=TF9Y1U1CSjDHwK2BRO3fTTBoZOqTBKvsxR0tcUPGwEI=; b=nXclg3Wcs64roYZXtO5JGRzw956h5WXz/9ECXCxs+wR0//RMka/K/qfyMRhvy4XOZi kBLtk6knX17FABBCaagiKfqjSelIErDKAKTXPZ+jlrgzva04RjByr+8eOoKZ4ZYsO7Sx IWngfmELuj/4PXtR4p9mZasMYQ75LaV1h65yYEERd2aDM+qebgqCdZW4bPxxJh9T4FTc rq4/8cfWJobjVkxAkjLaSwimL9DF5Ow5fBwU3Jpd1gIrXRx7d0srBS1JSwZ9P9YYKJ3+ tTsZnJLGODyOjL860fHDHD9RM0cvydXcSARaFRtTRn3t5l025mAYZ7xl7QaA729ibEPj HsIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704629135; x=1705233935; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TF9Y1U1CSjDHwK2BRO3fTTBoZOqTBKvsxR0tcUPGwEI=; b=U8CdjjFo8bjBCPxiku0Bj2UvnO0mntxB5zPBuRNWGtsJ0DKeMGre1sxY4lRrRa2G9l Voi6myeny0GDC66PqQA3825tdMcj6kj8t6NrY6w90GBa5xBe15yfUBCNdn4Ndqk6l4B1 WljtpI70zyJ+eRyFQWbvV1CdTb6PvY8tjiOMnYysfRh+TFH2z0TWED21/qhBZXCZqUWQ wagJCCq5QWVWxdHUp5EFEpP2zCT+YZ4M7PtPk9SfHgn3crYRYtEOZhK49qXp5Fk37y3T yeA3NlW1necE6JJxWXBrWDMTD0t98hnD8Q/3gQ8OfKEoA/y17PrR3yYhfMYIjlYMs76e S8fg== X-Gm-Message-State: AOJu0YwgEfWkMnFvEJGbym/suZxFwA0Ab+StNoonqefm2IjP+KL6VB8W KrWWz7daZilTg1MsnRLaSzoApC+xx8I= X-Google-Smtp-Source: AGHT+IFkV8swci95tfPeKDhka7dxLxzAChObTWN4fCit6j0GKj5Vmq5FOkYpTbpQX9dzu92MB4gcUg== X-Received: by 2002:a17:907:764c:b0:a27:5342:aca4 with SMTP id kj12-20020a170907764c00b00a275342aca4mr771025ejc.3.1704629134831; Sun, 07 Jan 2024 04:05:34 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id b21-20020a1709063f9500b00a269597d173sm2946586ejj.135.2024.01.07.04.05.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 04:05:34 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id DE9C7BFCDC; Sun, 7 Jan 2024 13:05:32 +0100 (CET) Date: Sun, 7 Jan 2024 13:05:32 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240106165246.274472-1-stefasab@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote: [...] > I'm not blocking the patch, however, I'm not sure whether the gain > outweighs the effort for such large code changes. It's very > unlikely to introduce new issues, but possible (e.g., typo while do > copy paste), and it's hard to check while review. It's true that it's hard to review, but in case of typos we should notice almost immediately (e.g. because compilation fails). And the readability boost it gives (sorted options means you don't need to read through all the options to find a given one) is well worth it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".