From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name
Date: Sun, 7 Jan 2024 13:05:32 +0100
Message-ID: <ZZqTjKqpHAR9c8pF@mariano> (raw)
In-Reply-To: <tencent_4B2D329A3B40769A939F15AB544EFB70A308@qq.com>
On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote:
[...]
> I'm not blocking the patch, however, I'm not sure whether the gain
> outweighs the effort for such large code changes. It's very
> unlikely to introduce new issues, but possible (e.g., typo while do
> copy paste), and it's hard to check while review.
It's true that it's hard to review, but in case of typos we should
notice almost immediately (e.g. because compilation fails).
And the readability boost it gives (sorted options means you don't
need to read through all the options to find a given one) is well
worth it.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-07 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 16:52 Stefano Sabatini
2024-01-07 5:10 ` Zhao Zhili
2024-01-07 12:05 ` Stefano Sabatini [this message]
2024-01-08 2:53 ` Zhao Zhili
2024-01-08 4:32 ` Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZqTjKqpHAR9c8pF@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git