Re: [FFmpeg-devel] [PATCH 09/35] avcodec/proresenc_kostya: fix chroma quantisation matrix in frame header

["Clément Bœsch" <u@pkh.me>]

On Sat, Dec 16, 2023 at 06:12:19PM +0100, Stefano Sabatini wrote:
> On date Monday 2023-12-11 02:35:10 +0100, Clément Bœsch wrote:
> > ---
> >  libavcodec/proresenc_kostya.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c
> > index 2d45f9a685..103051830a 100644
> > --- a/libavcodec/proresenc_kostya.c
> > +++ b/libavcodec/proresenc_kostya.c
> > @@ -1019,7 +1019,7 @@ static int encode_frame(AVCodecContext *avctx, AVPacket *pkt,
> >              bytestream_put_byte(&buf, ctx->quant_mat[i]);
> >          // chroma quantisation matrix
> >          for (i = 0; i < 64; i++)
> > -            bytestream_put_byte(&buf, ctx->quant_mat[i]);
> > +            bytestream_put_byte(&buf, ctx->quant_chroma_mat[i]);
> 
> Looks good, but I wonder, is this covered by tests and a results in a
> reference change?

Most of the time the quantisation matrices are tehe same, it only matters
with the "proxy" profile. I've added that last sentence to the commit
description to explain why it didn't cause any test ref change.

-- 
Clément B.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".