From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2BAA748517 for ; Sat, 6 Jan 2024 11:24:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8B90C68CCB5; Sat, 6 Jan 2024 13:24:34 +0200 (EET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3E04068CA09 for ; Sat, 6 Jan 2024 13:24:28 +0200 (EET) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-40d5aefcc2fso4445995e9.0 for ; Sat, 06 Jan 2024 03:24:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704540267; x=1705145067; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=uhyO8S+/WE4DAwVnzRgokKfMZT31gHeUEQSbfPUCUes=; b=f31qMQxp8f/wlYV8oK1j8TUJHAsnA6ZpLIQKcPwTO0a37XRyxEPKp1EgQWlw+rvU5m FP8Jkp3xD+P5+mzlUVRhy0b95PjFcC6u59srBq/LWSVKnRGA9cAR/IyM8IawbJoAgs/+ uVdi8KlnmKDTQOpcOExfZx6wKBZsw4f6nnx+7CAjwx+lIT4EFxvj9Gr3uw8cOAhnYNYb Y1vdJ1HQpYTKRtTL1txHqmoblNNNo2AnIb6pTglKyVYzmdhxFVRkEOGXsrD9paTBTUwz +yZgd6lYOI8bUO/fKtB9ANQ0AZqcEYxBeT6djTewvKfM7oO188WOBIxIfG4u7dc3EwSG OyOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704540267; x=1705145067; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uhyO8S+/WE4DAwVnzRgokKfMZT31gHeUEQSbfPUCUes=; b=Tp35nEzw56d25Y/r93lNxFHrRTS+k3TFdYWYfJugabg+wnWufipHlwI+kCMH8Gc9pz Gbvm8oUa6dSl+SPwDymMb17Nb7dwRyL+G1/LtLacF/hTHpDcU8SdLh2rcQ7VFPv2Ft8c woAeiPkv3Zl3YQ8hN/KyJFrYv3rPp3HxaR8KAgqc4kZa4kCLM1/lcazwmUAPLpS9pY2x D/sLcvIPEEI1WlPQM9CREVKIWk8wi3ZHSCE8Uazqkz56nGoZndHxKmedxEcXhrW5jKYs d4km0Fs5Q0jjIgA36PmRznj0OUHXFoobgQMkD/Sk4jl+SGBAOm96Icre2/WS+xQvaEB3 RSUw== X-Gm-Message-State: AOJu0YwFposregLrt6cp+9m2++vOX/TjdxrW2+Zexl/VH8vcI3hJpeYz xU3SUT1tRUQna0VbpReRRksdytg6mAQ= X-Google-Smtp-Source: AGHT+IGQS93jgDSOipMqVVQ8t6PbAFlqCvRxZRHGA48qD7oiup9GTTbDOPIKPbS3G9F0BHjd6EUR2A== X-Received: by 2002:a05:600c:220a:b0:40d:5c0b:d0d6 with SMTP id z10-20020a05600c220a00b0040d5c0bd0d6mr380496wml.140.1704540266585; Sat, 06 Jan 2024 03:24:26 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id fe1-20020a056402390100b005574787f023sm1031912edb.52.2024.01.06.03.24.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 03:24:26 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 33BF9BFCDC; Sat, 6 Jan 2024 12:24:25 +0100 (CET) Date: Sat, 6 Jan 2024 12:24:25 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240105164251.28935-1-anton@khirnov.net> <20240105164251.28935-3-anton@khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240105164251.28935-3-anton@khirnov.net> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 3/8] fftools/ffmpeg_demux: do not set bitexact directly on the decoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2024-01-05 17:42:46 +0100, Anton Khirnov wrote: > Add it to decoder options instead, to be processed when opening the > decoder. This way it won't be overridden by flags the user might be > setting otherwise. > --- > fftools/ffmpeg_demux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c > index 5d07b7153d..cacdc76a71 100644 > --- a/fftools/ffmpeg_demux.c > +++ b/fftools/ffmpeg_demux.c > @@ -1156,7 +1156,7 @@ static int ist_add(const OptionsContext *o, Demuxer *d, AVStream *st) > } > > if (o->bitexact) > - ist->dec_ctx->flags |= AV_CODEC_FLAG_BITEXACT; > + av_dict_set(&ist->decoder_opts, "flags", "+bitexact", AV_DICT_MULTIKEY); LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".