Re: [FFmpeg-devel] [PATCH 3/8] fftools/ffmpeg_demux: do not set bitexact directly on the decoder

From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/8] fftools/ffmpeg_demux: do not set bitexact directly on the decoder
Date: Sat, 6 Jan 2024 12:24:25 +0100
Message-ID: <ZZk4aTP3xoqD8wBh@mariano> (raw)
In-Reply-To: <20240105164251.28935-3-anton@khirnov.net>

On date Friday 2024-01-05 17:42:46 +0100, Anton Khirnov wrote:
> Add it to decoder options instead, to be processed when opening the
> decoder. This way it won't be overridden by flags the user might be
> setting otherwise.
> ---
>  fftools/ffmpeg_demux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
> index 5d07b7153d..cacdc76a71 100644
> --- a/fftools/ffmpeg_demux.c
> +++ b/fftools/ffmpeg_demux.c
> @@ -1156,7 +1156,7 @@ static int ist_add(const OptionsContext *o, Demuxer *d, AVStream *st)
>      }
>  
>      if (o->bitexact)
> -        ist->dec_ctx->flags |= AV_CODEC_FLAG_BITEXACT;
> +        av_dict_set(&ist->decoder_opts, "flags", "+bitexact", AV_DICT_MULTIKEY);

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".