From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D906E4850F for ; Sat, 6 Jan 2024 11:18:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D622368CC6C; Sat, 6 Jan 2024 13:18:17 +0200 (EET) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6B53068BCEC for ; Sat, 6 Jan 2024 13:18:11 +0200 (EET) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5574feb7958so379281a12.3 for ; Sat, 06 Jan 2024 03:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704539890; x=1705144690; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=3SafCAYIN5YIG97sZ7xvrLemnOIsoyNZeDMib+0a3DM=; b=G2GIdPUEcfuPOetLwvmPqkUIECryMbtBBZxmQHcV666qEahQ879j3AZw9k5+W0TiBl zdV/vBK7nScsF6urCkhStluppV09ir8z8MZcIBihWcBXkwJ1gYAG9z/7n5FFACda/wPf 631Yq2a0cxly2kWggtgqzJOfUdMbIq71UQ7omcDOL+LZ2AZ9kYrAM1E+9ZM4ugWTFaTN fjN7uvIQQKsi7robvRMaEQ5UBbf+UAIV+ocE/ljzPF0gUS/1H46DOEHrgsew+cECGLeP HK/mYvz5UVIlulzQqYI1SLO1qFaozwyjP12ZHQx6SFkJN0S5wXkzgzwkAxpFXieOrxL6 p8pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704539890; x=1705144690; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3SafCAYIN5YIG97sZ7xvrLemnOIsoyNZeDMib+0a3DM=; b=L0xcpV980kYjTYUOqAO/0UyM0E27fzBx9IOxZ2diWqwKSz7HhBTXbZAF6cOWbSJXCu 4R4+IxUDwqvRUPBVHWKKBna2PFjLNe3qZR6JxRMFfktWb6qbbajH96BeytnbQWIFWB7A uv2EvOOJPSq5SZPC37kvdR1NHav2YnWU7z0zAM7JOvDD5hPRBETXYhD89roc6UO1JMA7 hR5jSkAjS4tQ/hxDcqrqq91P2BYfOpo+4GyGim3CIfixY7mHuejawQvqp5J0ByCZ6dZa /ctu5uorOx9wBEiaYvLy4vvfdv0wnpNqzeWPFXgAbFldG30Ev/wHL/pbkvO/AGcBG2LG uRKg== X-Gm-Message-State: AOJu0Yy51LvC09AoLYRkiSFmyM1eR8WzVok6HtfHr+Tg1LM/MyJzBMD7 7WgHiLeTkbgUKNV7IxPCAKcr5UmC2+M= X-Google-Smtp-Source: AGHT+IHZDU0vyNxH3tpaY12ULtEVTGXCTlkhUcE9TqY43sQuiqIAlQVxMBJvj6IXqxR5vAfKsjCTqA== X-Received: by 2002:a05:6402:7d1:b0:553:8609:5431 with SMTP id u17-20020a05640207d100b0055386095431mr405737edy.48.1704539889808; Sat, 06 Jan 2024 03:18:09 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id y11-20020a50bb0b000000b005546ba152f4sm2062628ede.71.2024.01.06.03.18.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 03:18:09 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 2F2B2BFCDC; Sat, 6 Jan 2024 12:18:08 +0100 (CET) Date: Sat, 6 Jan 2024 12:18:08 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240105164251.28935-1-anton@khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240105164251.28935-1-anton@khirnov.net> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg_demux: replace abort() by av_assert0(0) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2024-01-05 17:42:44 +0100, Anton Khirnov wrote: > This is the standard way to mark unreachable cases in a switch > --- > fftools/ffmpeg_demux.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c > index 95af31e9ef..5d07b7153d 100644 > --- a/fftools/ffmpeg_demux.c > +++ b/fftools/ffmpeg_demux.c > @@ -1223,8 +1223,7 @@ static int ist_add(const OptionsContext *o, Demuxer *d, AVStream *st) > case AVMEDIA_TYPE_ATTACHMENT: > case AVMEDIA_TYPE_UNKNOWN: > break; > - default: > - abort(); > + default: av_assert0(0); LGTM, also probably we might employ a self-documentation trick of the kind: av_assert0(!"handled media type"); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".