From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6D63146B37 for ; Tue, 2 Jan 2024 21:13:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5AC3668CB0C; Tue, 2 Jan 2024 23:13:10 +0200 (EET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7EC1068C552 for ; Tue, 2 Jan 2024 23:13:04 +0200 (EET) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40d5f402571so64283975e9.0 for ; Tue, 02 Jan 2024 13:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704229983; x=1704834783; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=pzp4GCGP+azo7ljU7V7YUNrsD514IgLQhbH8WHGv+iM=; b=jkTHFH/OV8y3dEPcIA6S391j3sreUYOahcxc1kVfKwypzFW+B4JeOt+fZ/o+OXDjFL tk/wTYDgx4SRod8UyDOuIldSpYICpwU0P4DIK1rQ3KgGprPyEx9vHNKLeByYC4lzAum2 QsXOBK7eoXLTw5f0z44HdapnyGj6QjfX66T0fuuV3tx+EOvW5YspjMcYfnvQr8CvskJh P22Sfwk1gQ+2g+XfUHdbqd67c+4cw0H+zX/1+Bfu/nphjcNQMQj6BbOcfv+2pVJjpkO0 pPAjV33hDe8mPnbHY1zhkRfyi81o6rEASufBayTDYW6B7wPD0dQl8+2Skabje8YT0SHR UNNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704229983; x=1704834783; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pzp4GCGP+azo7ljU7V7YUNrsD514IgLQhbH8WHGv+iM=; b=gm1mTa3rS5sEv5NrFBKzcxelLEHIHFLUzdYtr0dxjsPt8IG6tGoWIErQbgzFrcEWE9 /FKzNoH1li3M1b+fW1IuICsz8KBiXtlpVE9b0zK/L2fuZrzqEQUHRAXAtK9M7wbjb3MY OjmEuq9R1nxXNDw0DdaEn0EvHK1/blWkO8JJsMqYsnQbbMiV0QVf+DMxrOT7Ny67Ot4h a55SthiPk5IWgXF5HM8eCHUr+yp1dhQ7CxNH4qRultymXOxrY2LMdPRFFirqRlVyNQgW J4rR49U8EKgTfcse/hSD2/HVRTZi++U74s0+SAriOeK0CZm6g3NBQUcSILjMHu+gB3kh YvyQ== X-Gm-Message-State: AOJu0YxgmuGFX+07D9G9zXwH2/NSFtjjd34amaemC5oiLjdK/qITpBJc 4V/u6Af8miw2JzWdbhqWdyuqn/7ofc4= X-Google-Smtp-Source: AGHT+IGlSV17v8ImyyFLf0gaRqKgM9Yxe4PnFLjeSQODtkxgC0XZ4xjekpWCnEeak/9zgfEG0oWdkA== X-Received: by 2002:a05:600c:ac7:b0:40d:5c4d:478a with SMTP id c7-20020a05600c0ac700b0040d5c4d478amr5465724wmr.32.1704229983502; Tue, 02 Jan 2024 13:13:03 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id f23-20020a7bc8d7000000b0040d5d5ac69asm152755wml.36.2024.01.02.13.13.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:13:03 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 29106BFCDC; Tue, 2 Jan 2024 22:13:02 +0100 (CET) Date: Tue, 2 Jan 2024 22:13:02 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20231226162033.782945-1-stefasab@gmail.com> <4425335c-a8d6-448f-9387-676e593ad3b8@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add quirc filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2023-12-29 12:57:15 +0100, Stefano Sabatini wrote: > On date Wednesday 2023-12-27 21:57:19 -0300, James Almer wrote: > > On 12/27/2023 8:20 PM, Stefano Sabatini wrote: > [...] > > > > I really think this should be ported as a native filter. It's not big and > > > > complex like a scaler (sws, zscale) which should not live within > > > > libavfilter. > > > > > > > Any change can be contributed back to libquirc > > > > > > This is not realistic, given that a reimplementation would be possibly > > > completely refactored to fit into FFmpeg. > > > > > > > (A library > > > > that's not going to be abandoned like it happened with libdcadec after it > > > > was merged into lavc, > > > > > > OTOH, this library is quite outside the scope of the FFmpeg, so it > > > makes sense to keep it as external dependency. This is a quite > > > different use case than a decoder, a QR-decoder library can make sense > > > outside of a multimedia library, for a decoder you would need a > > > complete multimedia library anyway. > > > > > > I was checking the code, and porting would be a serious effort and > > > comprise several thousands lines of code (against the moderate effort > > > of wrapping it - which is already done), also some of the logic would > > > not really fit into FFmpeg because it is quite specific to this > > > application domain (QR code decoding), so it makes sense for it to > > > live within an external library. Not to mention that this would be > > > a duplication of effort. > > > > Image analysis is within FFmpeg's scope, which QR code identification and > > decoding would be about. > > > > > > > > *Unless* someone is willing to port/reimplement the code, but this > > > should not be a blocker for the wrapper and can be done as a separate > > > step. > > > > No, i'm not blocking anything. Just stating that ideally this would be a > > native module. > > I'm not against this of course, but as I already stated this would > require more effort. It is probably worth it (polynomials and Galois > fields based error correction) as they would be probably reused in > other parts of the code. Ditto for the QR encoder. > > But I plan to have this functionality in with the wrappers - this > should also help with an eventual native port of the features. > > I plan to push this patch in a few days, unless I see comments. > > Thanks for the feedback. Applied. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".