From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 89BFE4818B for ; Wed, 10 Jan 2024 21:44:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C8D168CC16; Wed, 10 Jan 2024 23:44:09 +0200 (EET) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 715D268AABD for ; Wed, 10 Jan 2024 23:44:02 +0200 (EET) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-556c3f0d6c5so5516392a12.2 for ; Wed, 10 Jan 2024 13:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704923041; x=1705527841; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=UeRuftkSENBf57EsykT304bTvdu3j2BsFq6MDR1mT8E=; b=fSxlYGtKVRv8wsyQa0qB/RKLzW+gufEpWezC67KjBWDBbtvmk/O+J0MaxHaSdbhDRu v9fHrw9fr2zRMObPN/ZlEQp7jn3c0dC1jYFfG+ryGdoTwApl3bRdK3jHX79eDOVer45q kZm5Gv69PPhArKgCvKoG5pksL/KHG3OcYBXSoJxlA+xb/nVSobNR+7qZJ94rMrWMwMt1 fMNqQ8QIwZ74qhJ8NmXtnrSfzCOlYXO7cM023z8nyZS8h2savXIsj9+fZMcA3eGMVWUF cJYHcb+HdAc6QHhhx/0UPTSepKRW8y7jWm2bNC4E9bTE5MzAo8jz26isElDt9qrzVF/S 3BKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704923041; x=1705527841; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UeRuftkSENBf57EsykT304bTvdu3j2BsFq6MDR1mT8E=; b=I/ZJ/nu1C178evT/r8St2lQOijtXUZ8w55BTlVKNa6Mn9d/hmPyHmVacGScVy75THg IAZYSGsvryVFOPQFw9yKgQKyL2aexetvMG9Gak96gVSqI8C6aBXq/nYTEMVWxhBF81DZ 3yR1AaAYRQQCaB65QLOhkUE64rnR3NUizDdEToFIWbSMG10xGrGs3ZXcmGlzPqRAkgkN BKzIJE2xiGQpgvXI3/2BdfHpJn68olL6z+0mCV74esPBZzyKv8BvCn9Z4+IWAFJQ9MT8 P769Xp6HmUahUSWrCdwpQjpZDZTv8rbxn2vpEW+DqMrPgzArRsFRPIGHOp3gUjnx8208 reSw== X-Gm-Message-State: AOJu0YxSqIwv6xHwWsPEzx7FN9w95DGHwN5ju7YAUVL6XeGXAiggv1cC soIp2/JBFFJY2t/q1OYYkSTBSX/C5f4= X-Google-Smtp-Source: AGHT+IFM1n1wTSqlsYOxgkEZFCYgrRcHQMnLbVtNIVDnfBwnxWNHIAltHQXXzUO2MeGjn/PTHisHOQ== X-Received: by 2002:a17:907:c0d:b0:a23:4e3a:4356 with SMTP id ga13-20020a1709070c0d00b00a234e3a4356mr61419ejc.182.1704923041375; Wed, 10 Jan 2024 13:44:01 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id gw5-20020a170906f14500b00a2ae7fb3fc6sm2472179ejb.93.2024.01.10.13.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 13:44:01 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id D9F02BFCDC; Wed, 10 Jan 2024 22:43:59 +0100 (CET) Date: Wed, 10 Jan 2024 22:43:59 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211190908.1882569-1-u@pkh.me> <20240107181647.3049578-1-u@pkh.me> <20240107181647.3049578-5-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240107181647.3049578-5-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/proresenc_anatoliy: do not write into chroma reserved bitfields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-01-07 19:16:47 +0100, Cl=E9ment B=BDsch wrote: > The layout for the frame flags is as follow: > = > chroma_format u(2) > reserved u(2) > interlace_mode u(2) > reserved u(2) > = > chroma_format has 2 allowed values: > 0: reserved > 1: reserved > 2: 4:2:2 > 3: 4:4:4 > = > interlace_mode has 3 allowed values: > 0: progressive > 1: tff > 2: bff > 3: reserved > = > 0x80 is what we expect for "422 not interlaced", and the extra 0x2 from > 0x82 is actually writting into the reserved bits. nit: writting typo > --- > libavcodec/proresenc_anatoliy.c | 2 +- > tests/ref/vsynth/vsynth1-prores | 2 +- > tests/ref/vsynth/vsynth1-prores_444 | 2 +- > tests/ref/vsynth/vsynth1-prores_444_int | 2 +- > tests/ref/vsynth/vsynth1-prores_int | 2 +- > tests/ref/vsynth/vsynth2-prores | 2 +- > tests/ref/vsynth/vsynth2-prores_444 | 2 +- > tests/ref/vsynth/vsynth2-prores_444_int | 2 +- > tests/ref/vsynth/vsynth2-prores_int | 2 +- > tests/ref/vsynth/vsynth3-prores | 2 +- > tests/ref/vsynth/vsynth3-prores_444 | 2 +- > tests/ref/vsynth/vsynth3-prores_444_int | 2 +- > tests/ref/vsynth/vsynth3-prores_int | 2 +- > tests/ref/vsynth/vsynth_lena-prores | 2 +- > tests/ref/vsynth/vsynth_lena-prores_444 | 2 +- > tests/ref/vsynth/vsynth_lena-prores_444_int | 2 +- > tests/ref/vsynth/vsynth_lena-prores_int | 2 +- > 17 files changed, 17 insertions(+), 17 deletions(-) > = > diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anato= liy.c > index 1112cb26f1..bee4a14181 100644 > --- a/libavcodec/proresenc_anatoliy.c > +++ b/libavcodec/proresenc_anatoliy.c > @@ -769,7 +769,7 @@ static int prores_encode_frame(AVCodecContext *avctx,= AVPacket *pkt, > bytestream_put_buffer(&buf, ctx->vendor, 4); > bytestream_put_be16(&buf, avctx->width); > bytestream_put_be16(&buf, avctx->height); > - frame_flags =3D 0x82; /* 422 not interlaced */ > + frame_flags =3D 0x80; /* 422 not interlaced */ LGTM, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".