From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9CD8E4712B for ; Wed, 27 Dec 2023 11:54:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1A91E68C99B; Wed, 27 Dec 2023 13:54:40 +0200 (EET) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F037368C77C for ; Wed, 27 Dec 2023 13:54:32 +0200 (EET) Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-50e7e55c0f6so1536472e87.0 for ; Wed, 27 Dec 2023 03:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703678071; x=1704282871; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=j/yT85SLkEZzFyoogLhguK+z67+rSAPtIB4ra1nxPNM=; b=JMN/WA9DpqAJBnnsorbUYOljbBaTmRF46B+DZ0otUAutk5DW/ZjfzOQZ7AmNzOdC4b iNsftL0e5E8FRDX9COuyhJwqM9qANS3zHMPVbiYPRktW4UD0SWPaiaSDl9H3OpViYlwd A2wYOMS7n9oi04hsXP7oxnKFQ+nSROjfvdv0+bK6FGkDVBzwQ10rZ82hCFvB3K2OjQYY Y93VN/pmT1oyyDn9jeFLeRfXXCIv8L1ko+foIuq9yomTZr7/ZHBNHjf/18kwR9g/3eRk 1abXMwIUFMbFz1Ewfj4sVMHk3pLcg6THh9MrNUJFaZpgSlOy8mPpUSm3uV1CYIIU3l4f Kl3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703678071; x=1704282871; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j/yT85SLkEZzFyoogLhguK+z67+rSAPtIB4ra1nxPNM=; b=xEqFjo3MSOgwtFe4fC3An4+YQad6KdDwj0LCPZB/EytL3blCVgzrR1fJ/abiuEZTZa AnUA8FIvm3NSIlQ4Hy4EvZbN1eSAZDq79BN2GEykj7l1VVwsOLKMn66ipTYNj3V8yLQC lwwFwoWU4e1EXrYMJsXrIhV1Zp6XLKzpPIsLFxPZaGkk6JdSWqV08z6wdotLjRDR0452 psc9E0gngj4rv5jlhYQxf9SSJa1J7QbKa2tGGDgytl0IhEWiLCpveJ17AIyDR73hceW6 Uxq/t7T8OnIESoQXjAg7xnQn4EDMLeB9rVsZs3l6PwvuWtxEZxCJkNJeaLSgxKUPJoUQ T25g== X-Gm-Message-State: AOJu0Yz3rmgeUqP265dLW7VjgGPlm8ejUTHF+T9WWEr2vHllzlLQB0jd MzgCfK9ICtw/WhOD5g28rST/RYKBDs0= X-Google-Smtp-Source: AGHT+IGr2MlviFhrpUPkj+zkI3YlBcOLH49CHoHMOedHC6EElBOgWV2JHSPOfg6mNaQW+SScpQm+wA== X-Received: by 2002:a05:6512:ea0:b0:50e:7b07:2480 with SMTP id bi32-20020a0565120ea000b0050e7b072480mr882109lfb.205.1703678071217; Wed, 27 Dec 2023 03:54:31 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id l13-20020a1709066b8d00b00a26887307besm6526610ejr.180.2023.12.27.03.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 03:54:30 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id D7071BFCDC; Wed, 27 Dec 2023 12:54:28 +0100 (CET) Date: Wed, 27 Dec 2023 12:54:28 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231226222516.2513700-1-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231226222516.2513700-1-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/proresenc: make transparency honored in mov/QT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2023-12-26 23:25:15 +0100, Cl=E9ment B=BDsch wrote: > In the mov muxer (in mov_write_video_tag()), bits_per_coded_sample will > be written under certain conditions and is required to be 32 for the > transparency to be honored in QuickTime. > = > prores_kostya already has this setting but prores_anatoliy and > prores_videotoolbox didn't. > --- > libavcodec/proresenc_anatoliy.c | 3 +++ > libavcodec/videotoolboxenc.c | 2 ++ > 2 files changed, 5 insertions(+) > = > diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anato= liy.c > index a1cb46aa59..16741afd68 100644 > --- a/libavcodec/proresenc_anatoliy.c > +++ b/libavcodec/proresenc_anatoliy.c > @@ -930,6 +930,9 @@ static av_cold int prores_encode_init(AVCodecContext = *avctx) > } > } > = > + if (ctx->need_alpha) > + avctx->bits_per_coded_sample =3D 32; > + > ff_fdctdsp_init(&ctx->fdsp, avctx); > = > avctx->codec_tag =3D AV_RL32((const uint8_t*)profiles[avctx->profile= ].name); > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index 15e0e1fe29..644fd60b00 100644 > --- a/libavcodec/videotoolboxenc.c > +++ b/libavcodec/videotoolboxenc.c > @@ -521,6 +521,8 @@ static CMVideoCodecType get_cm_codec_type(AVCodecCont= ext *avctx, > } > return kCMVideoCodecType_HEVC; > case AV_CODEC_ID_PRORES: > + if (desc && (desc->flags & AV_PIX_FMT_FLAG_ALPHA)) > + avctx->bits_per_coded_sample =3D 32; > switch (profile) { > case AV_PROFILE_PRORES_PROXY: > return MKBETAG('a','p','c','o'); // kCMVideoCodecType_AppleP= roRes422Proxy LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".