From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C4BDE48A46 for ; Wed, 27 Dec 2023 11:37:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A7DD968CADB; Wed, 27 Dec 2023 13:37:48 +0200 (EET) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7880768C6BE for ; Wed, 27 Dec 2023 13:37:42 +0200 (EET) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a270200b9c1so156779166b.2 for ; Wed, 27 Dec 2023 03:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703677061; x=1704281861; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=572UI9tqunpBpBBCcrnWoa2kFog3qNBTr2JXUaGpcj0=; b=aYN1b8bszjJ+jnDyUrlBWQH/9QfEAlvuc2Eo4QNGjgCAil3vVbGCmhhOWKYYDXZ1Ul yymPZs/2mh3+Uxf7JZl9ki0zC61Mw31kvFlw2TlxxVsHtmDjL1J0MUUJDftf4QhLyAxK CRQlKvtad5y5GaZVbqShjHWTseTi2ibMMJ57ffDS++vzIVvzbWfYM826zVF1wi9guJC0 4JDP73mN1wuT/OxPsBeFVgi7hq+okydPPk83/HDXKGs493T1MHsrs6xJgX1WMWetHsXO UZSrCwbcrgtY4+JAquNTbGkJUDkvHBhOism13gJwzrr4L8LceHPS4eN6LaU1pVS0jPoz O2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703677061; x=1704281861; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=572UI9tqunpBpBBCcrnWoa2kFog3qNBTr2JXUaGpcj0=; b=joD9OiW4ZSvCjupbURsI7OOdo4oWu2jbKLUlKPXyMK+RZkZrkO3jpogiW+3CFpX8QV 4sdBtonpl1KlhJkcnWZur9ZE0lZSy83FEyTA7m9A9I/oBlPObdjRb04Fn65gGlVSNQwW Ck3dDz8PEDGnv1+C2kzJvkXYqunv+AXm23ZYJmsda1AssZbBRLC957pUiDwHCbAZ+/T8 ievG1SoMamtlGTtpNJ4DMNchEO8M7K9gagKZ/+XhhfBtrsy18WYYazpaLCyqrr+ivxuv jh+T32/1OJ3QlJDTWRzWIAU+RqzLtwrkfRbvGXQJN3XdMIF57pBZ4NXFLpDTwWBJVrln hGkA== X-Gm-Message-State: AOJu0YwasLDMrzeHHXjcqdt/eHaUpuRoZyOnLL7TZRDgE1pceBKNxZ3A m24dck11COJesiYN30qaydTHFVzPluc= X-Google-Smtp-Source: AGHT+IEKtTT1p9NecKXe7ZPNWHBb5IpbWByOz7+6p+R+kvox31lXs2tQ2YPdel/rCv599Z6disp0vQ== X-Received: by 2002:a17:906:4ad4:b0:a27:2dd1:3ace with SMTP id u20-20020a1709064ad400b00a272dd13acemr1225978ejt.128.1703677060545; Wed, 27 Dec 2023 03:37:40 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id xo3-20020a170907bb8300b00a2534aebc21sm6440754ejc.40.2023.12.27.03.37.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 03:37:40 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id AFD84BFCDC; Wed, 27 Dec 2023 12:37:38 +0100 (CET) Date: Wed, 27 Dec 2023 12:37:38 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20231226162033.782945-1-stefasab@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add quirc filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2023-12-26 22:33:36 -0300, James Almer wrote: > On 12/26/2023 10:25 PM, Stefano Sabatini wrote: > > On date Tuesday 2023-12-26 17:20:33 +0100, Stefano Sabatini wrote: > > > --- > > > Changelog | 1 + > > > configure | 4 + > > > doc/filters.texi | 35 ++++++++ > > > libavfilter/Makefile | 1 + > > > libavfilter/allfilters.c | 1 + > > > libavfilter/vf_quirc.c | 183 +++++++++++++++++++++++++++++++++++++++ > > > 6 files changed, 225 insertions(+) > > > create mode 100644 libavfilter/vf_quirc.c > > > > V2 with a few fixes and all corners put in the metadata (e.g. in case > > the QR code is rotated). > > Looking at the library, the license is very permissive and the code hasn't > been touched in many years. It is also pretty small, so why not just add it > as a native filter instead of requiring an external dependency for what > seems to be a relatively simple process? I see pros and cons, in total that would be about 3K lines of pretty clean code and data, and this would simplify integration for end-users (since they would not need to build the library, which seems not packaged by many distributions), and having the code would help to solve similar problems and probably could be generalized and optimized (e.g. to support other pixel formats). OTOH it would add to the maintenance burden since we would be owners of the code, which also means we would not benefit from fixes to the upstream project, in case they happen (last commit is from March 2023, so not very old): https://github.com/dlbeer/quirc/commit/542848dd6b9b0eaa9587bbf25b9bc67bd8a71fca _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".