From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2E4F547023 for ; Wed, 27 Dec 2023 01:19:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 86E2268CBD7; Wed, 27 Dec 2023 03:19:47 +0200 (EET) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1AB1468C98A for ; Wed, 27 Dec 2023 03:19:41 +0200 (EET) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5553f768149so516412a12.3 for ; Tue, 26 Dec 2023 17:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703639980; x=1704244780; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=pyBwapowmJFclI3jb2dNsqGIjHU43WqLXfbfRxd5w44=; b=cafGlFlZytkqx5zxXK6s11l5v4mpcOBom7/ONYe0O3K4/yMr2eiZ20ATo3+MpC+V24 3i1iJGOVFIMcWbw/q8QO6siEgW7aegGCfBUZYP9+YHigZpLsnWh6C2tA6y/Qt9wgvriY Dcv4XBaNueS3ivZedJVVAtj2Bxow1dzjjD0v+1dQfCz6NqrYGn1G/Ef2+eI0v2bmxnTs 1Wr0zKv/GPvvEzfWgoAelbFcRQ3iWtg/KzPE4TTLCTMx7zP9oNHgPu4aMDtA7vVqVEjN evzvU1R0u0Qny9CnPVM/bZVwusnupPutQ1Kc5/VuKn0A/gQz/KAPkivO+/VBjZ+5htjh Cg9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703639980; x=1704244780; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pyBwapowmJFclI3jb2dNsqGIjHU43WqLXfbfRxd5w44=; b=eJmGI9FtadM6SvZU2BYMjYpOr/kQOMyx3gfYhaYjoNukm1SzL709aTHHerdzOgNVxT JUNMl5oB0giM2JYLevTftqBab5HE/T1kSwfWaHtjpbK5m9jpxXqKGYzLfGozKn+01p2d Xf8SvgrVAlubeOMph7B7NCgrqeHMgJ8p7FZukBbt8UtOVRL/WLsRZNlx5lwTFahq48zz V7ZL2PwKMlcbPAuP4s7UISM9aZkh4cy/93bDK+b8VPvMXocJIleY6Xf9lidC2cgeFkim fA54pLbySWWYWHEGNfsIdb9tgQQjJ8eZjttWMd9Pc9FnfNEvWadYW8laKeRJJPuwCX2l ivfA== X-Gm-Message-State: AOJu0YxPFOWxnq9EyW5x3r/I1PJnF65xuLhaOyuO9IADbvx6GLKbiWb8 wr43HtJJTcYS8m+RmfIm7msmNe0tYI8= X-Google-Smtp-Source: AGHT+IH3po3vfqD/eqWoO0+DkNDVnWCn0IkskAm54A4sY8UfE4sKmV958Q1jW/lYMPRDti5NidwglA== X-Received: by 2002:a50:bae7:0:b0:553:b472:924b with SMTP id x94-20020a50bae7000000b00553b472924bmr5037969ede.22.1703639979927; Tue, 26 Dec 2023 17:19:39 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id v22-20020aa7d656000000b00552870b594fsm7848435edr.31.2023.12.26.17.19.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 17:19:39 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 3367DBFCDC; Wed, 27 Dec 2023 02:19:38 +0100 (CET) Date: Wed, 27 Dec 2023 02:19:38 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20231226162033.782945-1-stefasab@gmail.com> <9aa042cb-da94-47b8-b2f6-71d0a81755c6@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9aa042cb-da94-47b8-b2f6-71d0a81755c6@gmail.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add quirc filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2023-12-26 16:21:55 -0300, James Almer wrote: > On 12/26/2023 1:20 PM, Stefano Sabatini wrote: > > +static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > > +{ > > + AVFilterContext *ctx = inlink->dst; > > + AVFilterLink *outlink = ctx->outputs[0]; > > + QuircContext *quirc = ctx->priv; > > + int codes_count; > > + int i, w, h; > > + uint8_t *image, *imagep, *srcp; > > + > > + image = quirc_begin(quirc->quirc, &w, &h); > > Can't this fail? > Or does the allocation take place in the quirc_resize() > call? correct > > + > > + /* copy input image to quirc buffer */ > > + imagep = image; > > + srcp = frame->data[0]; > > + for (i = 0; i < inlink->h; i++) { > > + memcpy(imagep, srcp, w); > > Can w differ from inlink->w? No, given that the resize is done in config_inputs. > > + imagep += w; > > + srcp += frame->linesize[0]; > > + } > > Maybe instead do > > av_image_copy_plane(image, w, frame->data[0], frame->linesize[0], > w, inlink->h); good catch, thanks for the feedback _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".