From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E01F7482FD for ; Sun, 24 Dec 2023 10:57:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C521768D153; Sun, 24 Dec 2023 12:57:04 +0200 (EET) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E263368D139 for ; Sun, 24 Dec 2023 12:56:58 +0200 (EET) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-9fa45e75ed9so331298466b.1 for ; Sun, 24 Dec 2023 02:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703415418; x=1704020218; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=0Qgs4TBbZAXHnLRd2igkz6egxGbN0x3CzEzvqKUbeaM=; b=PsUfCq2ngAXIaJHDPVpXLqihCjNpRk9eER1b4ah6eeK8R1rq+6FHvXWx7nWVt9lNBe hT867UVJO/Zmx1pLdX0zz9FkN9xFRHEvVMaXrWBMcUu8wT5M5bab/cWdKyoEDKwID9YW aV/bGeW6X8gKZYgIeotVVeObMmBMJ3Ndu4bQvmWJtZsml0PqUNhpLS2aWrivlOo8TH9K C4Xm4IhABqVIIfkcKdt/t/Qtx9GWh5bXmfPUdUkuo15CxG+jelsN+lfY9vGjuVqoTvzS QD8e7rbM7xYjSUKMQ9l3b9E7XONYunmRh5+diH9gYR3lecaEaQxwmjF+yvu/3pi8JMz+ 4dVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703415418; x=1704020218; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Qgs4TBbZAXHnLRd2igkz6egxGbN0x3CzEzvqKUbeaM=; b=FeTXQ2zxpDJVJUMF3D+DQtMmvK8lS2HJ98kKO97GtUht9744N0i32grnK/UzvFJ2Nz 14rL9ppCkup5sjPbdGwHJRioNfcYs2X6maLE4uHV8gPGRqyEOrRDknE68SLNMR1j/qe8 hBuPv63kiVuYOgPsCcRX6r7IofrVJntU3A63EUQY9n3XLZ2MYqoHGo/LRQA952muVhnB QVX2gnF+GtUw9rJPCre9LuLxfWxDFvNeFbNnmtfpoXWBEMdRN8e0gGNDogaE6XkBKS3O 3H06U4C0n2fyfK8OJOdWztOn8jKsbRlZCcWsolszqbaVBVuGD46KQW/LR1rG8lBuOaZf d6jg== X-Gm-Message-State: AOJu0YyTZxUW1Jx1dAW8NbdCpIowSdgtiFZd7YUi7C5vk2Q4SzqABxb1 N0FcYC3zf7paRLBmPbNvtRImfkoDsZU= X-Google-Smtp-Source: AGHT+IHEQRAPHoIW9+mIXTsYIhbDbEhlw3tGmspVWrQFeWykAp+Asw0WTIg7kkl1Bm3U1ukAnZ8L+w== X-Received: by 2002:a17:906:51d8:b0:a26:ef29:8735 with SMTP id v24-20020a17090651d800b00a26ef298735mr105639ejk.42.1703415417805; Sun, 24 Dec 2023 02:56:57 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id l2-20020a170907914200b00a269b4692a9sm3870604ejs.84.2023.12.24.02.56.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Dec 2023 02:56:57 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 48EFDBFCDC; Sun, 24 Dec 2023 11:56:56 +0100 (CET) Date: Sun, 24 Dec 2023 11:56:56 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20231211014429.1841681-1-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231211014429.1841681-1-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] Initial tickering at unifying ProRes encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2023-12-11 02:35:01 +0100, Cl=E9ment B=BDsch wrote: > Hello there, > = > I'm currently investigating an issue=B9 affecting Kostya ProRes encoder > which is not reproducible with Anatoliy encoder (but it's too early to > say if the bug is not present there as well given the differences in > quantization, and it's also unclear if the issue is even actually > there in the first place and not in M2/M3 firmwares). > = > Since these encoders share more than similiarities, I've been looking > into their differences, and unifying their common codepaths was helpful > to my investigation. > = > Attached is an initial patchset working out their differences by either > sharing data or making code identical where relevant. > = > I will continue that work as the investigation progresses. The > quantization work might require more involved changes though. > = > Regards, > = > =B9 https://trac.ffmpeg.org/ticket/10255 Hi Clement. Most patches look good to me. You can skip style comments in patches 3, 4, 15 if they complicate the rebase. About functional changes in 9 and 27, I assume the one in 27 is an overlook, while 9 could be a lecit change but in this case I assume the output changes should be spotted by a test - not sure we have such a test in place to compare kostya/anatoliy encoders output. Or maybe I'm wrong and I misread the changes, but having the test would be good anyway. Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".