From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6A24F46F5B for ; Sun, 24 Dec 2023 10:25:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D2A1868D0F1; Sun, 24 Dec 2023 12:25:38 +0200 (EET) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D01468D026 for ; Sun, 24 Dec 2023 12:25:32 +0200 (EET) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-554cffbad2fso138147a12.1 for ; Sun, 24 Dec 2023 02:25:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703413530; x=1704018330; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ga7EsCderynqFeORKdhAjtkLjuwKywuWSPbh4iEyGKg=; b=DJxp6mEQAOaLYe1UJpS4FyZN1oJ9/jd36ICuVNR/kV4yuHEjOd0pKUsKKGQQWNb6fn ol2bKjxM7h5FmZjn1XDb1zhVjD8kRChhXECcm8DRB+fQVIOZt86nrchiQEAsJD4VqQRD dhpjqF3R/zIMd0MSJnQHmrslmFHcNWCdTsZVuYPqA15Mr9UXzyi/Oap7jiO4bJ5CF98+ VG/G4QicLi35ESHsjXC9YNGpxIyMVlUUdYXgNEPDomQjgDC8/s8jUkpWo1IFbRfJN7Lt jn4OVf9F1tI2sHPxAfhPjST5zPRQbj2ZX18CgjlbOGTOupO0N2FDo58bzxUYbS6b9sTg ESPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703413530; x=1704018330; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ga7EsCderynqFeORKdhAjtkLjuwKywuWSPbh4iEyGKg=; b=FGa9pUl95C7CgumU7J/mUv6TxYOr5nyFZiOtL0K5TQBrv+/QvVQmanrCqkITjlmYeR a1FVZ8vQ+UVJFyIYAbJjJ2u34yaoa+aBzcfEU97noO9TqVPrjjDgmb0zQdO76k24P21R +2iRud7fJl5Gt7IdqakvfMDAVg1wxSDdVmTigfn1XvtYqcHR3ZAxjI4Tr6CXoeHscxnf MtVPl0m59OoQUe70WhQhFIFhu8RCnP6EjvqBCO5JRitFTEc34F0/y2xbRLybXPkpUmN/ 1DPJSySHj1/VcuI8urE0iV/tYKsmiophXGK+oC+z+OuQD0EH88HULzfo0lxwY9ohn4FG pIIQ== X-Gm-Message-State: AOJu0YxhweZxP+xxz91dHWJryeFMixPUddOU1t+IW8vcR8XV/pVMUjri uy69uqyojMBDhobxCoxT09KkPk3LKAw= X-Google-Smtp-Source: AGHT+IGNh9kfCcDbXmq+jggN7kn7yiIbUGME4s+89BLS+p9lNgjx/7TFS2z888WbLKwae69UF4p1+g== X-Received: by 2002:a05:6402:148:b0:553:33eb:58f7 with SMTP id s8-20020a056402014800b0055333eb58f7mr1688926edu.52.1703413529994; Sun, 24 Dec 2023 02:25:29 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id s23-20020aa7c557000000b00551ca461bd7sm4914955edr.48.2023.12.24.02.25.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Dec 2023 02:25:29 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 7AD53BFCDC; Sun, 24 Dec 2023 11:25:28 +0100 (CET) Date: Sun, 24 Dec 2023 11:25:28 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211014429.1841681-1-u@pkh.me> <20231211014429.1841681-30-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231211014429.1841681-30-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 29/35] avcodec/proresenc_anatoliy: replace get_level() with FFABS() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2023-12-11 02:35:30 +0100, Cl=E9ment B=BDsch wrote: > This matches the code from proresenc_kostya. > --- > libavcodec/proresenc_anatoliy.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > = > diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anato= liy.c > index 0318379461..88c6d47ab7 100644 > --- a/libavcodec/proresenc_anatoliy.c > +++ b/libavcodec/proresenc_anatoliy.c > @@ -258,13 +258,6 @@ static void encode_vlc_codeword(PutBitContext *pb, u= nsigned codebook, int val) > #define GET_SIGN(x) ((x) >> 31) > #define MAKE_CODE(x) (((x) * 2) ^ GET_SIGN(x)) > = > -static av_always_inline int get_level(int val) > -{ > - int sign =3D (val >> 31); > - return (val ^ sign) - sign; > -} > - > - > static void encode_dcs(PutBitContext *pb, int16_t *blocks, > int blocks_per_slice, int scale) > { > @@ -305,7 +298,7 @@ static void encode_ac_coeffs(PutBitContext *pb, > = > prev_run =3D run; > run =3D 0; > - level =3D get_level(val); > + level =3D FFABS(val); > code =3D level - 1; LGTM, given that (for sign =3D 1): val ^ sign =3D val + 1 val + 1 - 1 =3D val + 1 + 2**N -1 =3D val + 2**N =3D ABS(val) = _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".