From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 23AA14691F for ; Sat, 23 Dec 2023 23:43:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E7C0368CCE7; Sun, 24 Dec 2023 01:43:43 +0200 (EET) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C87F068C6E6 for ; Sun, 24 Dec 2023 01:43:36 +0200 (EET) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-40d4ee4cbbcso9942015e9.2 for ; Sat, 23 Dec 2023 15:43:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703375014; x=1703979814; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ja+CbDWr57vtyl3u1FVvvB/3zPgtbXDgQmf30WtBue0=; b=mrNLvLuxHrC5CkgDW5/i9+lYibkQPFM1mClHXuQv/0bCDOCUiO4GTM6CYqFKxg417+ QIPYB3qiAMnqtxbxrjmdDbEdlePlnlgjM1tdULsE/X6CSk4CaEdkRnuRLBXCKd1JJq7f 8jjRaqmmGesJy1816B8a3aL1ICEwY4JtsC/DW/sZ0C4/86lsdCmIMVzIW7gggsbMWF4o bb8b5vHL8n/h8tsA33ns+dVyqDDd+W7amMAQ75crGOLAVXle5XoBQLqU1FVZQq1rzjwP L0Mn6CEhDsKrSGZXbybNDYgOoY9lVq4gOND6gKDJEUAUb1srBC9Gwjqb2rnmuhvlbcuP 9pBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703375014; x=1703979814; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ja+CbDWr57vtyl3u1FVvvB/3zPgtbXDgQmf30WtBue0=; b=JLxq8tDQ1cYqX6et4vI7TXwCP3PWnGN3ea3lLDyBSFM3als0UEZH7GcwmrYyYOhQ08 AwpGwNpIeQuKlDXLscdDHs22ke16VmRVKCHuraHrudcFM5FkDSakUhSiyZ0TmBaBm7Ce 8A+qTZUEdmp8wz2s58bpq0eAJ8wuSTiukmbAeRjJSJYCqs7wvkrgnVvfqL0wzNAz+dgH eX/CEQDW9Rd2CdrynwKvobUB1II9iryc8/mdEGc9qtxvaBL6vwoDStgeL37t/gC4jqbY FqnPz3B4Ek6wxsS4+0gHW3pzDrMJ6E6quPf63CYgDZoVEIDkH0mDKVGrwQygdmS+oTnA gSBQ== X-Gm-Message-State: AOJu0Yxe8JVh1O1G1dqvXgDWRjV6M1+e3PhBciAp+UxWlLenU/8BnVWB eH0Yaw6lbANBM1caji+/6628AtnzBS0= X-Google-Smtp-Source: AGHT+IFXbNbYpMaE2kUa/dipU6BndKV/hCUzn59IIvouxpx/zivOCRgVbpzzq+0oTo6krq7Mqz7mZg== X-Received: by 2002:a05:600c:3487:b0:40d:4f62:bfde with SMTP id a7-20020a05600c348700b0040d4f62bfdemr866833wmq.161.1703375014134; Sat, 23 Dec 2023 15:43:34 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id wh14-20020a170906fd0e00b00a234907311asm3440201ejb.55.2023.12.23.15.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Dec 2023 15:43:33 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 1E967BFCDC; Sun, 24 Dec 2023 00:43:32 +0100 (CET) Date: Sun, 24 Dec 2023 00:43:32 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211014429.1841681-1-u@pkh.me> <20231211014429.1841681-28-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231211014429.1841681-28-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 27/35] avcodec/proresenc_anatoliy: remove TO_GOLOMB2() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2023-12-11 02:35:28 +0100, Cl=E9ment B=BDsch wrote: > A few cosmetics aside, this makes the function identical to the one with > the same name in proresenc_kostya. > --- > libavcodec/proresenc_anatoliy.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anato= liy.c > index bdf7bface4..aed5c68b1b 100644 > --- a/libavcodec/proresenc_anatoliy.c > +++ b/libavcodec/proresenc_anatoliy.c > @@ -257,7 +257,6 @@ static void encode_vlc_codeword(PutBitContext *pb, un= signed codebook, int val) > = > #define GET_SIGN(x) ((x) >> 31) > #define MAKE_CODE(x) (((x) * 2) ^ GET_SIGN(x)) > -#define TO_GOLOMB2(val,sign) ((val)=3D=3D0 ? 0 : ((val) << 1) + (sign)) > = > static av_always_inline int get_level(int val) > { > @@ -271,7 +270,6 @@ static void encode_dcs(PutBitContext *pb, int16_t *bl= ocks, > { > int i; > int codebook =3D 5, code, dc, prev_dc, delta, sign, new_sign; > - int diff_sign; > = > prev_dc =3D (blocks[0] - 0x4000) / scale; > encode_vlc_codeword(pb, FIRST_DC_CB, MAKE_CODE(prev_dc)); > @@ -282,8 +280,8 @@ static void encode_dcs(PutBitContext *pb, int16_t *bl= ocks, > dc =3D (blocks[0] - 0x4000) / scale; > delta =3D dc - prev_dc; > new_sign =3D GET_SIGN(delta); > - diff_sign =3D new_sign ^ sign; > - code =3D TO_GOLOMB2(get_level(delta), diff_sign); > + delta =3D (delta ^ sign) - sign; > + code =3D MAKE_CODE(delta); These don't look equivalent, MAKE_CODE((delta ^ sign) - sign) is equivalent to TO_GOLOMB2(get_level(delta), sign) not to TO_GOLOMB2(get_level(delta), diff_sign) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".