From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Add new vf_tiltandshift filter
Date: Wed, 20 Dec 2023 20:50:50 +0100
Message-ID: <ZYNFmv6cr9Q2HNjd@phare.normalesup.org> (raw)
In-Reply-To: <CABLWnS9LcYc4AVeULCZExe7C21Pth4Yu9zaZvUwGzACdVeQkZA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 847 bytes --]
Vittorio Giovara (12023-12-20):
> If there are no more comments, I'll push this today or tomorrow.
I think the change you made after the last request might go too far, but
I have not had time to look at the code carefully enough to be sure.
If a filter can produce several output frames from one input, then it
must send at lease one of the NEW frames.
An illustration to make it clear: if I1 allows to compute O1a, O1b, O1c,
I2 allows to compute O2a, O2b, O2c, etc.
Then when I1 arrives, the filter must output at least O1a, it can output
O1b and O1c or not.
But when I2 arrives, it must output at lease O2a, which means it must
output O1b and O1c if that was not done at the time of I1.
Your filter only outputs one frame per input, but it seems to me it can
create several frames.
Regards,
--
Nicolas George
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-20 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 0:51 Vittorio Giovara
2023-12-12 8:00 ` Nicolas George
2023-12-13 10:06 ` Vittorio Giovara
2023-12-15 17:36 ` Andreas Rheinhardt
2023-12-15 20:12 ` Vittorio Giovara
2023-12-20 19:43 ` Vittorio Giovara
2023-12-20 19:50 ` Nicolas George [this message]
2023-12-20 19:56 ` Vittorio Giovara
2023-12-21 21:43 ` Vittorio Giovara
2023-12-22 15:33 ` Paul B Mahol
2023-12-22 15:40 ` Ronald S. Bultje
2023-12-22 21:48 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYNFmv6cr9Q2HNjd@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git