From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7034B48869 for ; Mon, 18 Dec 2023 22:29:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BA36668D004; Tue, 19 Dec 2023 00:29:51 +0200 (EET) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8A1C868CEE8 for ; Tue, 19 Dec 2023 00:29:45 +0200 (EET) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-55114c073b8so4644543a12.1 for ; Mon, 18 Dec 2023 14:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702938584; x=1703543384; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=65Cyrme3ZIWREMZ5ZmTLEV0VGiN0UNKSrCu770emfVc=; b=PGl/N/7EgtwaJATa78nO+2ZaFxrWt5aHQOLbUtEm/sUtg/l0W9fHfEcJ6oWRTxNEvF PD7ymfrd6EPDAzGQROL9ETjJazXdvLdudDx/LV23IPhqSUKoTPyA/3hMzaP7MA1Uf+Xs EELDi6ym2+WFSANUHw5MzlTRpJ6YHgzKl2/36g5q2njSawgPnDad31bu58Nl8S7FqL8Y yQFjUTzlM6XOw0VICXBDXS0wpuotyeaGuARYJ8CnCuKE9zZgEMA5cRwBcqx041wcebOg dNauipzoLbwoL/A3x8our01UgkV2y/2BfRGN9uZQiHXqwbG6zgD+5t7z3Q/ntzHdbA2Y M7Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702938584; x=1703543384; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=65Cyrme3ZIWREMZ5ZmTLEV0VGiN0UNKSrCu770emfVc=; b=kv7I1JIzLZd2HK0103B/QjGZzFL94pLqawDRs8wtLijoHd5nW7GFd6LikZIDo6CVHk tbpVlxWpP9EVGFManaXGT23o1R9mMJkIQxO7LZgyVjgiBZSHAzmK9mqKG1IhCLgtxDej KeR+4GFOwXduxBhJRpmuxpl/k86U+14cwQYSlOyW5lj0Yp8yoV1ifjlXvA2Q/x89eU/n XOo/zK1RQgXNc+c4f39oajLdZxTxtofybhUVGGpqQitJET+WeSQ3I4l7ZXmL/bMUetnd oDhGqeVEiNnnx55umk/GAcj3kJav8ydJxnRKe/bGxnKdDvMXXphrkEh3zyJHr/D9fGry 4h8g== X-Gm-Message-State: AOJu0Yz64WxF+IJX/TLBPz+QEaiqyf7Twv+kmL2c6SB8giIcZALmrNMG DNbfmBCYygzIj61NVPfeP/2Gi7c/AMk= X-Google-Smtp-Source: AGHT+IExnSARp8sIqnIpfQjKoWaLvysPe7tNmTcVE/CWWbu8IKSqudHmT4eA3Ed4bcFN+dzeMhlNoA== X-Received: by 2002:a50:aa9e:0:b0:553:7a3f:3d63 with SMTP id q30-20020a50aa9e000000b005537a3f3d63mr392541edc.18.1702938584297; Mon, 18 Dec 2023 14:29:44 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id el13-20020a056402360d00b005527de2aecfsm4564153edb.42.2023.12.18.14.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 14:29:43 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id D6792BFCDC; Mon, 18 Dec 2023 23:29:42 +0100 (CET) Date: Mon, 18 Dec 2023 23:29:42 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211014429.1841681-1-u@pkh.me> <20231211014429.1841681-23-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231211014429.1841681-23-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 22/35] avcodec/proresenc_anatoliy: remove IS_NEGATIVE() macro X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2023-12-11 02:35:23 +0100, Cl=E9ment B=BDsch wrote: > This makes the function closer to encode_acs() in proresenc_kostya. > --- > libavcodec/proresenc_anatoliy.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > = > diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anato= liy.c > index 4ea3d89126..43dee7f79b 100644 > --- a/libavcodec/proresenc_anatoliy.c > +++ b/libavcodec/proresenc_anatoliy.c > @@ -257,7 +257,6 @@ static void encode_vlc_codeword(PutBitContext *pb, un= signed codebook, int val) > = > #define GET_SIGN(x) ((x) >> 31) > #define TO_GOLOMB(val) (((val) * 2) ^ GET_SIGN(val)) > -#define IS_NEGATIVE(val) ((GET_SIGN(val) ^ -1) + 1) > #define TO_GOLOMB2(val,sign) ((val)=3D=3D0 ? 0 : ((val) << 1) + (sign)) > = > static av_always_inline int get_level(int val) > @@ -318,7 +317,7 @@ static void encode_ac_coeffs(PutBitContext *pb, > = > prev_level =3D level; > = > - put_bits(pb, 1, IS_NEGATIVE(val)); > + put_sbits(pb, 1, GET_SIGN(val)); Should be good. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".