From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7414C48A7F for ; Fri, 29 Dec 2023 11:57:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 31D5B68CD64; Fri, 29 Dec 2023 13:57:25 +0200 (EET) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7CABA68CBD2 for ; Fri, 29 Dec 2023 13:57:18 +0200 (EET) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a2331e7058aso817172866b.2 for ; Fri, 29 Dec 2023 03:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703851037; x=1704455837; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=0ek9eyKUrKkhBWgKxRy1vSLuPbWeiQLtY7uXq18nvHc=; b=iHWXGhSo4p13T8gKfF2EyL0pnB9qdCLgRTu+g5fdDDBHi83qlqlPKabR4NMTXIt862 UtpX2BvlTGRntXE8PFCe3OdSN5JXVVGsyolNSiq+SzNBw05lCk2l6zkujjQCV1wn4tLe +jnxghrMQOpLbvAJD/oZ3FzKqGtFrD5NkEvXj209z9PH6rIp5txCRAR2yJfw2ylJeGhO cpO/3Ga8qhmbSjC/b70Ox3asvzDXi4c9Y5agBeYSf+9F6vBwDD+ifMDEfF+ux+1lNg6o JUsoDx3UqZNPE+kxoH0oJKFjZR5iXbL9Odb5qj4Yj+cJPIxp5LB25fSheqbkdkb5O+yJ /C0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703851037; x=1704455837; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0ek9eyKUrKkhBWgKxRy1vSLuPbWeiQLtY7uXq18nvHc=; b=Hwh3XJVAs/myXL3zSSVnMji69Q95TNplYgjRkA+a+hStj0RdSJf2PQEKWlv8yoNHAh Nv+Vafv+NyFZCNgkqMMgrqct0j5y4j7w38t2z13BC6jqUCb51Ho4pXDeLX8vP2JisJlF NxxojEEdMJUQps0FokSWRC57F+iiu5RDzsZMk0SRpS9Zy3/0obS7/7IsQwZTY6VOgUZa OAcOGr+FENUxrit1McbmtHwg13thGUuzm999KgQr0p0ACMW2Xcrh/7RkZe/lPR4lgm+Q S0C07xY4FdSg3M+CEJ9jEmsqIF4c9p9E2C8zMe7eK88NO+3bFimhwhspfd02JCATHTJP T1CA== X-Gm-Message-State: AOJu0Yy4yUKe5vHOC9Zmfo2RQuiqo45GwpUc109xY6nZ/kmMOoZF283O 3zYtpxUpJpIyhCOZ73sHtdYFyWa/yQY= X-Google-Smtp-Source: AGHT+IEb5pjMqeOUHuK8wxRMuwV9OXw1efMvWNC1DHA2RKji149qGhAmMSnO0CFnLfPGLQXug89zkw== X-Received: by 2002:a17:906:4a86:b0:a23:2ccc:8ea9 with SMTP id x6-20020a1709064a8600b00a232ccc8ea9mr2654884eju.299.1703851036634; Fri, 29 Dec 2023 03:57:16 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id m4-20020a170906258400b00a26f6be432asm4051134ejb.70.2023.12.29.03.57.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Dec 2023 03:57:16 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 2E476BFCDC; Fri, 29 Dec 2023 12:57:15 +0100 (CET) Date: Fri, 29 Dec 2023 12:57:15 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20231226162033.782945-1-stefasab@gmail.com> <4425335c-a8d6-448f-9387-676e593ad3b8@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4425335c-a8d6-448f-9387-676e593ad3b8@gmail.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add quirc filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Wednesday 2023-12-27 21:57:19 -0300, James Almer wrote: > On 12/27/2023 8:20 PM, Stefano Sabatini wrote: [...] > > > I really think this should be ported as a native filter. It's not big and > > > complex like a scaler (sws, zscale) which should not live within > > > libavfilter. > > > > > Any change can be contributed back to libquirc > > > > This is not realistic, given that a reimplementation would be possibly > > completely refactored to fit into FFmpeg. > > > > > (A library > > > that's not going to be abandoned like it happened with libdcadec after it > > > was merged into lavc, > > > > OTOH, this library is quite outside the scope of the FFmpeg, so it > > makes sense to keep it as external dependency. This is a quite > > different use case than a decoder, a QR-decoder library can make sense > > outside of a multimedia library, for a decoder you would need a > > complete multimedia library anyway. > > > > I was checking the code, and porting would be a serious effort and > > comprise several thousands lines of code (against the moderate effort > > of wrapping it - which is already done), also some of the logic would > > not really fit into FFmpeg because it is quite specific to this > > application domain (QR code decoding), so it makes sense for it to > > live within an external library. Not to mention that this would be > > a duplication of effort. > > Image analysis is within FFmpeg's scope, which QR code identification and > decoding would be about. > > > > > *Unless* someone is willing to port/reimplement the code, but this > > should not be a blocker for the wrapper and can be done as a separate > > step. > > No, i'm not blocking anything. Just stating that ideally this would be a > native module. I'm not against this of course, but as I already stated this would require more effort. It is probably worth it (polynomials and Galois fields based error correction) as they would be probably reused in other parts of the code. Ditto for the QR encoder. But I plan to have this functionality in with the wrappers - this should also help with an eventual native port of the features. I plan to push this patch in a few days, unless I see comments. Thanks for the feedback. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".