From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle
Date: Wed, 13 Dec 2023 11:03:55 +0100
Message-ID: <ZXmBi81GtakwsWXB@phare.normalesup.org> (raw)
In-Reply-To: <F8973AA1-9931-4FA9-8BB6-C9F814AC353E@remlab.net>
Rémi Denis-Courmont (12023-12-12):
> ...and test for overflow errors in errno.m (which shall have been
> zeroed beforehand). AFAIK, you need to do both if you want strict
> error detection.
Or we can consider that 30064771114 is just another valid way if writing
42 = 042 = 0x2a. It would be better to check, but it is less critical
than checking for garbage at the and, which itself is less critical than
checking that the number is entirely absent.
> Don't some distros forbid the use of the n specifier for (debatable)
> "security reasons"? Or is that only for formatting, and not in
> scanning?
First time I ear of that. We use %n in quite a few places — not only
code by me — and we did not have a problem.
If there is a real security consideration about %n, I would like a
pointer to the explanations; but I strongly doubt there are, it is just
another conversion specifier with all the usual caveats. If not, and
there are distros who forbid it for no valid reason, then I say to hell
with them.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-13 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 22:10 [FFmpeg-devel] [PATCH] " Lena via ffmpeg-devel
2023-12-11 0:34 ` Andreas Rheinhardt
2023-12-11 1:35 ` Lena via ffmpeg-devel
2023-12-11 1:52 ` Lena via ffmpeg-devel
2023-12-12 0:47 ` Stefano Sabatini
2023-12-12 13:59 ` [FFmpeg-devel] [PATCH v2] " Lena via ffmpeg-devel
2023-12-12 14:07 ` Nicolas George
2023-12-12 15:31 ` Rémi Denis-Courmont
2023-12-13 10:03 ` Nicolas George [this message]
2023-12-14 10:32 ` [FFmpeg-devel] [PATCH v3] " Lena via ffmpeg-devel
2023-12-16 15:31 ` Stefano Sabatini
2023-12-17 17:29 ` [FFmpeg-devel] [PATCH v4] " Lena via ffmpeg-devel
2023-12-17 18:17 ` Stefano Sabatini
2023-12-14 10:52 ` [FFmpeg-devel] [PATCH v2] " Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXmBi81GtakwsWXB@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git