From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 37B3A4862F for ; Tue, 12 Dec 2023 07:00:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D56F068D1A5; Tue, 12 Dec 2023 09:00:34 +0200 (EET) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 38DED68CD84 for ; Tue, 12 Dec 2023 09:00:28 +0200 (EET) Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3333fbbeab9so4701090f8f.2 for ; Mon, 11 Dec 2023 23:00:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702364427; x=1702969227; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dMTb6LhCEy9mL/tB7WDWtaTY23vbsb0o5e4VAMLmF2A=; b=MbYXd03sTWeN0yUFRe8RoX25jPdL/YS3GqxHZdbt/a8hiy3okamfydXOoLndVwKUOw +3bXmCzVCkOIIYGDLP+9hXZiMps7gPT333kCNoqHpqmxLiB8q03N17d7WDsjuKx0owtj ztOk219KoA+jt3Exzf8QY0Wxv0DsFTwIVl/FpV5jIRRDJ0A8AZw1SRVKdreAVqdw/fyq kMZP95nGiNqkCuSOER1h3Ae3dJJenTOZdFgAfLYVBJZ9BjJ4UCgxD0IbPqHZwtlQtNXC 3ZC+vcXvZ1TS6BEMxASb4WDVuinuwEHXKkxuu+ZiR7Aj+zBIitwNynIrOVdlgC5HIbfD NxhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702364427; x=1702969227; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dMTb6LhCEy9mL/tB7WDWtaTY23vbsb0o5e4VAMLmF2A=; b=ZGjwHy9naWaer7gpETEbVqNwMswpMrQdk+jrd41Az0Z+FvMBkOZysGueHmbfHUYHG7 FptWCtYmVxkjLkEB93wAN+MzJthBe21D7HRQQGUttFLRLnw3zqjUEY2NqbKNFBV7Eqf/ 1STUgJmx14juvVT2pVKETMVZpdqV62IBz9HULWlAyAJwicJHPLMVKfgMmnlPppC6Q6zq O+95MX9H/0uVUzop8zyYXEBYkd2dOT4Iil7vvXtFxIizMsSAU6pYFNuV3CCxnwnODboV pff6ZKBMPTXsRoW3guMBp6dgZpQegJV9Q+rBDuUIFwabHsQpqGBNI2nI2ukHeoBfPOGr pZGQ== X-Gm-Message-State: AOJu0YymtFg7yLAxYqowlk3ykrdNAa8vokx70FG9OgYatBIYa03npY4t LJAALyV9OiLKe0JuXXhVNcF6hMSNdgI= X-Google-Smtp-Source: AGHT+IGFR9U2CAgkGr+3t/i++lXUW1d2YaREu4NBsv9faL+DwY+urllC1Rc19N/QOAq+wyAdJ2nY3g== X-Received: by 2002:adf:fe4d:0:b0:333:4a18:7b5b with SMTP id m13-20020adffe4d000000b003334a187b5bmr2751156wrs.124.1702364427027; Mon, 11 Dec 2023 23:00:27 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id c15-20020adfe74f000000b0033335644478sm10113745wrn.114.2023.12.11.23.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 23:00:26 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 5C6BFBFCDA; Tue, 12 Dec 2023 08:00:25 +0100 (CET) Date: Tue, 12 Dec 2023 08:00:25 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211014429.1841681-1-u@pkh.me> <20231211014429.1841681-4-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231211014429.1841681-4-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 03/35] avcodec/proresenc_kostya: remove redundant codebook assignments X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2023-12-11 02:35:04 +0100, Cl=E9ment B=BDsch wrote: > This is already assigned at declaration. > --- > libavcodec/proresenc_kostya.c | 2 -- > 1 file changed, 2 deletions(-) > = > diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c > index 7aed3974c3..6e1d5a0cef 100644 > --- a/libavcodec/proresenc_kostya.c > +++ b/libavcodec/proresenc_kostya.c > @@ -440,7 +440,6 @@ static void encode_dcs(PutBitContext *pb, int16_t *bl= ocks, > prev_dc =3D (blocks[0] - 0x4000) / scale; > encode_vlc_codeword(pb, FIRST_DC_CB, MAKE_CODE(prev_dc)); > sign =3D 0; > - codebook =3D 3; > blocks +=3D 64; > = > for (i =3D 1; i < blocks_per_slice; i++, blocks +=3D 64) { > @@ -676,7 +675,6 @@ static int estimate_dcs(int *error, int16_t *blocks, = int blocks_per_slice, > prev_dc =3D (blocks[0] - 0x4000) / scale; > bits =3D estimate_vlc(FIRST_DC_CB, MAKE_CODE(prev_dc)); > sign =3D 0; > - codebook =3D 3; > blocks +=3D 64; > *error +=3D FFABS(blocks[0] - 0x4000) % scale; Since this is the only value assigned with declaration, maybe it's better to drop the codebook =3D 3 in the assignment, but LGTM anyway. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".